Skip to content

@W-17572026: Fix failing checkout test #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unandyala merged 3 commits into from
Jan 10, 2025
Merged

@W-17572026: Fix failing checkout test #2195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bebe1a4
Add changelog
unandyala Jan 9, 2025
a228a38
Add changelog
unandyala Jan 9, 2025
394473d
Add changelog
unandyala Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/template-retail-react-app/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
## v5.1.0-dev (TBD)

- Fixed failing checkout tests [#2195](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2195)
- [BUG] Fixed "getCheckboxProps is not a function" when rendering checkout page in generated app.[#2140](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2140)
- Replace transfer basket call with merge basket on checkout [#2138])(https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2138)
- Replace transfer basket call with merge basket on checkout [#2138](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2138)

### Accessibility Improvements
- [a11y] Fix LinkList component to follow a11y practise [#2098])(https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2098)
Expand Down
4 changes: 2 additions & 2 deletions packages/template-retail-react-app/app/pages/checkout/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ test('Can proceed through checkout steps as guest', async () => {
// Fill out credit card payment form
await user.type(screen.getByLabelText(/card number/i), '4111111111111111')
await user.type(screen.getByLabelText(/name on card/i), 'Testy McTester')
await user.type(screen.getByLabelText(/expiration date/i), '1224')
await user.type(screen.getByLabelText(/expiration date/i), '1240')
await user.type(screen.getByLabelText(/^security code$/i /* not "security code info" */), '123')

// Same as shipping checkbox selected by default
Expand Down Expand Up @@ -485,7 +485,7 @@ test('Can proceed through checkout as registered customer', async () => {
// (we no longer have saved payment methods)
await user.type(screen.getByLabelText(/card number/i), '4111111111111111')
await user.type(screen.getByLabelText(/name on card/i), 'Testy McTester')
await user.type(screen.getByLabelText(/expiration date/i), '1224')
await user.type(screen.getByLabelText(/expiration date/i), '1240')
await user.type(screen.getByLabelText(/^security code$/i /* not "security code info" */), '123')

// Same as shipping checkbox selected by default
Expand Down
Loading