Skip to content

Update references to 2024 in Retail React App Template mock test data#2196

Closed
bendvc wants to merge 2 commits intodevelopfrom
bendvc/update-retail-template-expiration-dates
Closed

Update references to 2024 in Retail React App Template mock test data#2196
bendvc wants to merge 2 commits intodevelopfrom
bendvc/update-retail-template-expiration-dates

Conversation

@bendvc
Copy link
Contributor

@bendvc bendvc commented Jan 13, 2025

Description

We still have some references to 2024 in our test data. Even though these do not cause tests failures, it would be nice to update them so that if we ever find ourselves in the same position, finding and replacing will be easier.

Changes

  • Update test and mock data references to 2024
  • Unify all expiration dates to 2040 january

How to Test-Drive This PR

  • CI still passes

General

  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

@bendvc bendvc requested a review from a team as a code owner January 13, 2025 17:43
Copy link
Contributor

@kevinxh kevinxh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping in and fix this! Salute

@bendvc bendvc requested review from a team and unandyala January 13, 2025 17:46
@bendvc bendvc removed the request for review from unandyala January 13, 2025 18:03
@bendvc bendvc closed this Jan 13, 2025
@bendvc bendvc deleted the bendvc/update-retail-template-expiration-dates branch July 16, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants