Skip to content

@W-17458080 - Use env vars to configure redirect and callback uris for social/passwordless login & reset password#2198

Merged
yunakim714 merged 4 commits intofeature-passwordless-social-loginfrom
W-17458080-control-uri-with-env-var
Jan 14, 2025
Merged

@W-17458080 - Use env vars to configure redirect and callback uris for social/passwordless login & reset password#2198
yunakim714 merged 4 commits intofeature-passwordless-social-loginfrom
W-17458080-control-uri-with-env-var

Conversation

@yunakim714
Copy link
Collaborator

@yunakim714 yunakim714 commented Jan 13, 2025

Description

Customers may want to change the application behavior for social and passwordless login without having to redeploy their bundle. Environment variables will make this easily configurable.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • Customers can change the callback & redirect uri's for social login, passwordless login, and password reset with the following environment variables:
    • SOCIAL_LOGIN_REDIRECT_URI
    • PASSWORDLESS_LOGIN_CALLBACK_URI
    • PASSWORD_RESET_CALLBACK_URI

How to Test-Drive This PR

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@yunakim714 yunakim714 requested a review from a team as a code owner January 13, 2025 19:01
@yunakim714 yunakim714 requested a review from hajinsuha1 January 13, 2025 19:30
// When setting this to true, make sure to also set the PWA_KIT_SLAS_CLIENT_SECRET
// environment variable as this endpoint will return HTTP 501 if it is not set
useSLASPrivateClient: true,
useSLASPrivateClient: false,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current client ID in the config is a public client, do we want to change this back to false?

@yunakim714 yunakim714 merged commit 1c687fd into feature-passwordless-social-login Jan 14, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants