@W-17458080 - Use env vars to configure redirect and callback uris for social/passwordless login & reset password#2198
Merged
yunakim714 merged 4 commits intofeature-passwordless-social-loginfrom Jan 14, 2025
Conversation
yunakim714
commented
Jan 13, 2025
| // When setting this to true, make sure to also set the PWA_KIT_SLAS_CLIENT_SECRET | ||
| // environment variable as this endpoint will return HTTP 501 if it is not set | ||
| useSLASPrivateClient: true, | ||
| useSLASPrivateClient: false, |
Collaborator
Author
There was a problem hiding this comment.
The current client ID in the config is a public client, do we want to change this back to false?
hajinsuha1
approved these changes
Jan 14, 2025
alexvuong
approved these changes
Jan 14, 2025
1c687fd
into
feature-passwordless-social-login
5 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Customers may want to change the application behavior for social and passwordless login without having to redeploy their bundle. Environment variables will make this easily configurable.
Types of Changes
Changes
How to Test-Drive This PR
Go to https://runtime-admin-staging.mobify-storefront.com/salesforce-internal/wasatch-mrt/reset-password-poc/environment-variables (make sure bundle 131 is deployed)
Change the SOCIAL_LOGIN_REDIRECT_URI environment variable to a random path
Go to https://wasatch-mrt-reset-password-poc.mrt-storefront-staging.com/
Click on the Google login button
Open
Networkin DevTools and verify that the redirect URI of the API request is equivalent to the env var valueThen delete the env var
Go back to the storefront and click Google again
Verify that the redirect URI is now the default value, or
/social-callbackChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization