Release preview of v2.9.0 of PWA Kit (@W-17624115@)#2211
Merged
joeluong-sfcc merged 2 commits intorelease-2.9.xfrom Jan 21, 2025
Merged
Release preview of v2.9.0 of PWA Kit (@W-17624115@)#2211joeluong-sfcc merged 2 commits intorelease-2.9.xfrom
joeluong-sfcc merged 2 commits intorelease-2.9.xfrom
Conversation
* test v2 ci * modify bootstrap.js * update test.yml * revert changes * remove install system dep steps and check-dependencies.js check * skip test * upgrade lighthouse dep to match v3 * add comment * bump version * pass channel_id to SLAS * add datadog install to workflow * fix test * bump version and update changelogs * update engines section in package.json * update CI to include node 20 and npm 10 * update package-lock.json * update exclude * exclude node 14 npm 10 * remove comments and add back in check dependency script * change version number * update babel configs * remove comment
vmarta
approved these changes
Jan 17, 2025
Contributor
vmarta
left a comment
vmarta
left a comment
There was a problem hiding this comment.
Cool, I see all packages versioned at: v2.9.0-preview.0 👍
joeluong-sfcc
changed the title
vcua-mobify
approved these changes
Jan 17, 2025
Contributor
vcua-mobify
left a comment
vcua-mobify
left a comment
There was a problem hiding this comment.
LGTM
To summarize the changes in this release, they are:
- Node 20 upgrade
- Adding channel_id to SLAS calls
- Fixing CC expiry on tests
- Datadog setup in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization