@W-17554979@ Commerce-sdk-react readme updates#2212
Merged
vcua-mobify merged 3 commits intodevelopfrom Jan 17, 2025
Merged
Conversation
vcua-mobify
commented
Jan 17, 2025
| ) | ||
| } | ||
| ``` | ||
| #### Disable slas private warnings |
Contributor
Author
There was a problem hiding this comment.
I'm opting to remove this section around how you can set a client secret directly to the SDK since this can lead to the client secret appearing client-side. Even in the non-PWA scenario, you will want to protect the client secret by adding it server side via a BFF layer.
unandyala
approved these changes
Jan 17, 2025
|
|
||
| const AppConfig = ({children}) => { | ||
| const headers = { | ||
| 'correlation-id': correlationId |
Contributor
There was a problem hiding this comment.
May be add comment explaining the need for correlation id
Contributor
Author
There was a problem hiding this comment.
This bit was just me copying the code that we already have inside app-config in the template-retail-react-app and the generator so that the example more closely aligns with the actual code that developers will see.
joeluong-sfcc
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The readme is used to generate SDK docs: https://salesforcecommercecloud.github.io/pwa-kit/#:~:text=library%20supports%20the-,Public%20Client%20login%20flow.,-Shopper%20Session%20Initialization
This PR is done in collaboration with the docs team to update SLAS private client documentation.