Skip to content

Fix some failing tests in product details due to default DNT state#2217

Merged
jeremy-jung1 merged 3 commits intodnt-ui-branchfrom
change-banner-text
Jan 22, 2025
Merged

Fix some failing tests in product details due to default DNT state#2217
jeremy-jung1 merged 3 commits intodnt-ui-branchfrom
change-banner-text

Conversation

@jeremy-jung1
Copy link
Collaborator

@jeremy-jung1 jeremy-jung1 commented Jan 22, 2025

Description

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1) npm run test in template retail react app and see that it passes

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@jeremy-jung1 jeremy-jung1 requested a review from a team as a code owner January 22, 2025 20:13
@jeremy-jung1 jeremy-jung1 changed the base branch from develop to dnt-ui-branch January 22, 2025 20:14
This reverts commit d11cf25.
@jeremy-jung1 jeremy-jung1 changed the title Change banner text in DNT notification Fix some failing tests in product details due to default DNT state Jan 22, 2025
@jeremy-jung1 jeremy-jung1 merged commit 7cec56d into dnt-ui-branch Jan 22, 2025
26 checks passed
@jeremy-jung1 jeremy-jung1 mentioned this pull request Jan 22, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants