Passwordless redirect unit test#2235
Merged
hajinsuha1 merged 3 commits intoW-17550783-passwordless-login-redirectfrom Feb 3, 2025
Merged
Passwordless redirect unit test#2235hajinsuha1 merged 3 commits intoW-17550783-passwordless-login-redirectfrom
hajinsuha1 merged 3 commits intoW-17550783-passwordless-login-redirectfrom
Conversation
hajinsuha1
commented
Feb 3, 2025
| navigate(redirectTo) | ||
| } | ||
| }, [isRegistered]) | ||
| }, [isRegistered, redirectPath]) |
Collaborator
Author
There was a problem hiding this comment.
needed to add redirectPath to the dependency array because I wasn't sure how to make isRegistered change to trigger this useEffect.
However this shouldn't change the current behaviour because redirectPath is only set when the user navigates to the /passwordless-landing-page
hajinsuha1
commented
Feb 3, 2025
| .mockImplementation((helperType) => mockAuthHelperFunctions[helperType]), | ||
| useCustomerBaskets: () => {return {data: mockMergedBasket, isSuccess: true}}, | ||
| useCustomerType: jest.fn(() => {return {isRegistered: false, customerType: 'guest'}}) | ||
| useCustomerType: jest.fn(() => {return {isRegistered: true, customerType: 'guest'}}) |
Collaborator
Author
There was a problem hiding this comment.
the other way of doing this is by mocking the /passwordless/token api using global.server.use but because of the /jwks validation I was having issues. So instead I just mocked that the user isRegistered
yunakim714
approved these changes
Feb 3, 2025
hajinsuha1
merged commit 73f6482
into
W-17550783-passwordless-login-redirect
8 of 9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization