Skip to content

Route serialization to support Shopper SEO URL mapping integration #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hajinsuha1 merged 172 commits into from
Apr 11, 2025
Merged

Route serialization to support Shopper SEO URL mapping integration #2300

Show file tree
Hide file tree
Changes from 166 commits
Commits
Show all changes
172 commits
Select commit Hold shift + click to select a range
f178dec
implement route serialization/deserialization
hajinsuha1 Mar 5, 2025
7b8b80b
initial pass at implementing route serialization via a componentMap
hajinsuha1 Mar 7, 2025
4f30443
update error handling message format
hajinsuha1 Mar 7, 2025
55c4415
cleanup and fix getRoutes to not duplicate routes
hajinsuha1 Mar 7, 2025
5da9d8e
Convert extendRoutes to an async method
vmarta Mar 8, 2025
4d13fe3
create a helper function generateComponentMapFromModules
hajinsuha1 Mar 10, 2025
8a54875
Add todos
vmarta Mar 10, 2025
4604d76
Temporarily modify the typescript-minimal project
vmarta Mar 10, 2025
e6542fc
initial impl of adding base template components to component map
hajinsuha1 Mar 10, 2025
7a1f51f
Minor refactoring
vmarta Mar 10, 2025
ddb88d2
Call every extension's route function in parallel
vmarta Mar 10, 2025
138f44b
create a prefixDisplayName utils
hajinsuha1 Mar 11, 2025
3bfa646
update error handling
hajinsuha1 Mar 11, 2025
2054078
fix deserialization of components from pwa-kit-react-sdk
hajinsuha1 Mar 11, 2025
a547b24
Merge branch 'vm/async-extendRoutes' into route-serialization-to-supp…
hajinsuha1 Mar 11, 2025
63a9d1f
merge
hajinsuha1 Mar 11, 2025
d90c79c
initial implementation of serialize/deserialize
hajinsuha1 Mar 12, 2025
c67fefa
cleanup
hajinsuha1 Mar 12, 2025
af9f3df
make serialize() and getComponentMap() synchronous
hajinsuha1 Mar 13, 2025
b002c86
Pass in the request path
vmarta Mar 13, 2025
bd74cf8
cache getRoutes using CacheResult decorator
hajinsuha1 Mar 14, 2025
b84c8c3
move deserialization logic to constructor of ApplicationExtension
hajinsuha1 Mar 14, 2025
3a9f90d
call this.getComponentMap within deserialize and fix typing
hajinsuha1 Mar 14, 2025
4a3a6ce
cleanup serialize logic
hajinsuha1 Mar 14, 2025
6d92af9
Explore passing in locals and how to manage access token
vmarta Mar 14, 2025
9f6c055
Remove extendRoutes from the API
vmarta Mar 15, 2025
6d5fb39
Allow configuring of the auth property name in locals
vmarta Mar 15, 2025
0115d21
comments + create DeserializedExtension type
hajinsuha1 Mar 17, 2025
fa85193
make getComponentMap abstract
hajinsuha1 Mar 17, 2025
040e3f1
add ComponentMap type to getComponentMap method in ChakraStorefront a…
hajinsuha1 Mar 17, 2025
86a78ed
add displayName to StoreLocatorPage
hajinsuha1 Mar 17, 2025
0a7e855
Rename the property in locals
vmarta Mar 17, 2025
9acff92
add unit tests for cacheResult
hajinsuha1 Mar 17, 2025
c5d924b
Create a new extension for a better example
vmarta Mar 17, 2025
2206dd5
Add some console logs
vmarta Mar 17, 2025
392387a
refactor Switch component to use RoutesProvider and create RoutesCons…
hajinsuha1 Mar 17, 2025
0c1bd41
update CacheResult decorator to support async methods and modify test…
hajinsuha1 Mar 17, 2025
08e72bd
enhance CacheResult decorator to support both async and sync methods …
hajinsuha1 Mar 18, 2025
0dbbb34
refactor getRoutes method to support both sync and async returns and …
hajinsuha1 Mar 18, 2025
8324897
refactor ApplicationExtension to enforce getComponentMap() for async …
hajinsuha1 Mar 18, 2025
5586726
cleanup ApplicationExtension and apply CacheResult to getRoutes metho…
hajinsuha1 Mar 18, 2025
645a91f
move CacheResult decorator logic to applyCacheForMethod in Applicatio…
hajinsuha1 Mar 18, 2025
d0ffc37
don't make getComponentMap abstract but make it optional
hajinsuha1 Mar 18, 2025
f97aaed
remove unused ComponentMap import from test files
hajinsuha1 Mar 18, 2025
42879f5
Experiment with having partial route
vmarta Mar 18, 2025
b71c0b9
Experiment with correct way to get app origin
vmarta Mar 18, 2025
bb692bc
Add todo
vmarta Mar 18, 2025
0d2ed3b
Some cleanup
vmarta Mar 18, 2025
35a453e
lint
hajinsuha1 Mar 19, 2025
272639f
cleanup
hajinsuha1 Mar 19, 2025
2067892
Fix the partial route with correct path
vmarta Mar 19, 2025
0e44b84
Remove no longer necessary code
vmarta Mar 19, 2025
1579626
Combine params into a single object
vmarta Mar 19, 2025
806fa87
Remove some console logs
vmarta Mar 19, 2025
85f9516
add async route handling and serialization tests for ApplicationExten…
hajinsuha1 Mar 19, 2025
11b5af3
Add comment to clarify
vmarta Mar 19, 2025
6402e62
handle all condiiton in deserialize and move applyCacheForMethod to a…
hajinsuha1 Mar 19, 2025
e8bba80
refactor: rename getRoutes to getRoutesAsync for clarity and update r…
hajinsuha1 Mar 19, 2025
af93217
refactor: remove isGetRoutesAsync method as it's no longer needed
hajinsuha1 Mar 19, 2025
579bdf3
Implement getRoutes and getRoutesAsync
vmarta Mar 20, 2025
18adf16
Add comment
vmarta Mar 20, 2025
d9b32e2
Add comment
vmarta Mar 20, 2025
4ad2535
Merge branch 'vm/async-extendRoutes' into route-serialization-to-supp…
hajinsuha1 Mar 20, 2025
965a34a
update getRoutesAsync to also return SerializedRoute and serialize to…
hajinsuha1 Mar 20, 2025
6baf649
cleanup decorator and chakra-storefront
hajinsuha1 Mar 20, 2025
5dbe489
update URLMapping.getRoutesAsync and BeforeRouteMatchParams to suppor…
hajinsuha1 Mar 20, 2025
26da1ee
address PR feedback
hajinsuha1 Mar 20, 2025
f1eab7c
update error message
hajinsuha1 Mar 20, 2025
0a1626c
fix cacheMethodResult
hajinsuha1 Mar 20, 2025
c622823
Add type to allow for `componentName` property
vmarta Mar 20, 2025
92a1c9a
fix ApplicationExtension.test.tsx
hajinsuha1 Mar 20, 2025
f615878
Merge branch 'vm/async-extendRoutes' into route-serialization-to-supp…
hajinsuha1 Mar 20, 2025
38e352f
Remove params for `getRoutes`
vmarta Mar 20, 2025
4119cda
Remove params for getRoutes
vmarta Mar 20, 2025
6677213
refactor: update route handling to use RouteProps exclusively and imp…
hajinsuha1 Mar 20, 2025
0058e80
Merge branch 'vm/async-extendRoutes' into route-serialization-to-supp…
hajinsuha1 Mar 20, 2025
fa4540a
refactor: rename GetRoutesParams to GetRoutesAsyncParams for to fix e…
hajinsuha1 Mar 20, 2025
4af8642
update unit tests
hajinsuha1 Mar 20, 2025
7fdd261
Revert "Remove params for `getRoutes`"
vmarta Mar 20, 2025
bcdcea3
Revert "Remove params for getRoutes"
vmarta Mar 20, 2025
7b48662
Merge branch 'vm/async-extendRoutes' into route-serialization-to-supp…
hajinsuha1 Mar 21, 2025
62e0060
reorganize imports for RoutesContext and unit tests
hajinsuha1 Mar 21, 2025
347c486
Merge branch 'route-serialization-to-support-shopper-seo-integration'…
hajinsuha1 Mar 21, 2025
de121c3
Add isServerSide utility function and corresponding tests
hajinsuha1 Mar 21, 2025
2152142
lint
hajinsuha1 Mar 21, 2025
ab23cd6
[REVERT] temporary logging for testing
hajinsuha1 Mar 21, 2025
5236d90
Remove unused properties from global Window interface in type definit…
hajinsuha1 Mar 21, 2025
131f670
update changelog
hajinsuha1 Mar 21, 2025
6e257cd
Refactor so that extension is the one in control of serialization
vmarta Mar 21, 2025
edcae1d
Update packages/pwa-kit-extension-sdk/src/react/classes/ApplicationEx…
hajinsuha1 Mar 24, 2025
04ee8fb
update unit tests and add error handling
hajinsuha1 Mar 24, 2025
c6be840
Merge branch 'route-serialization-to-support-shopper-seo-integration'…
hajinsuha1 Mar 24, 2025
c8e8035
lint
hajinsuha1 Mar 24, 2025
88419bf
lint
hajinsuha1 Mar 24, 2025
e9c00dd
lint extension-url-mapping
hajinsuha1 Mar 24, 2025
1de2122
Update comments
vmarta Mar 24, 2025
38425c2
Update tests
vmarta Mar 24, 2025
2bcbbc2
Update tests
vmarta Mar 24, 2025
7ba4d99
Revert changes to typescript-minimal
vmarta Mar 24, 2025
7c731f2
Merge branch 'feature/extensibility-v2' into vm/async-extendRoutes
vmarta Mar 24, 2025
a2096c3
Update package-lock.json
vmarta Mar 24, 2025
18a566f
Update changelog files
vmarta Mar 24, 2025
0e0edcb
Update readme files
vmarta Mar 24, 2025
422bd78
Merge branch 'vm/async-extendRoutes' into route-serialization-to-supp…
hajinsuha1 Mar 25, 2025
7ed9fbd
Refactor ApplicationExtension tests to use correct component types an…
hajinsuha1 Mar 25, 2025
e08d7ce
Remove extension-url-mapping package and associated files
hajinsuha1 Mar 25, 2025
bab7884
fix unit tests
hajinsuha1 Mar 25, 2025
c594557
Revert "Remove extension-url-mapping package and associated files"
hajinsuha1 Mar 25, 2025
794b0a3
lint
hajinsuha1 Mar 25, 2025
0cd67cc
Revert "Revert changes to typescript-minimal"
hajinsuha1 Mar 25, 2025
54ec28a
remove extension-url-mapping, logging, changes to typescript-minimal
hajinsuha1 Mar 25, 2025
6d7c6a9
update maxSize for build/vendor.js to 353 kB in template-retail-react…
hajinsuha1 Mar 25, 2025
12b071b
update CHANGELOG.md for template-retail-react-app
hajinsuha1 Mar 25, 2025
5f5de44
Add jsdoc to some types
vmarta Mar 25, 2025
ad8933a
Update packages/pwa-kit-extension-sdk/src/react/classes/ApplicationEx…
hajinsuha1 Mar 26, 2025
f65cf58
address PR feedback (remove unnecessary code)
hajinsuha1 Mar 26, 2025
876b4c2
Revert "remove extension-url-mapping, logging, changes to typescript-…
hajinsuha1 Mar 26, 2025
ad6d337
update ApplicationExtension unit test
hajinsuha1 Mar 26, 2025
f05a70a
Revert "Revert "remove extension-url-mapping, logging, changes to typ…
hajinsuha1 Mar 26, 2025
16f461b
Merge branch 'vm/async-extendRoutes' into route-serialization-to-supp…
hajinsuha1 Mar 26, 2025
052c99f
Merge branch 'feature/extensibility-v2' of https://github.com/Salesfo…
hajinsuha1 Mar 28, 2025
6d32d9d
don't allow returning partial routes from getRoutesAsync
hajinsuha1 Mar 28, 2025
6e3a71d
introduce SerializedRouteProps
hajinsuha1 Mar 28, 2025
8b17606
refactor serialize and deserialize to be more specific to routes (ser…
hajinsuha1 Apr 4, 2025
d1f42db
Merge branch 'feature/extensibility-v2' into route-serialization-to-s…
hajinsuha1 Apr 4, 2025
3cc8230
update changelog
hajinsuha1 Apr 4, 2025
23f3f26
Merge branch 'route-serialization-to-support-shopper-seo-integration'…
hajinsuha1 Apr 4, 2025
673728e
[App Extensibility ⚙️] Pin Specific Versions for Extensions in Genera…
adamraya Mar 31, 2025
d904807
Initial refactor of ssr into setup-server
bendvc Mar 27, 2025
ca31a1e
Refactor some of the utils and create middleware
bendvc Mar 28, 2025
4ef75d1
Remove wishlist from configurate list of pages for now
bendvc Mar 28, 2025
46ccd7b
Fix some lint errors
bendvc Mar 31, 2025
cc16ffc
Fix jwks path and replace constants with configurable values
bendvc Mar 31, 2025
a9a3bed
Empty commit
bendvc Mar 31, 2025
c658d3f
Fix regression and fix some tests config
bendvc Mar 31, 2025
572e689
Fix mock config
bendvc Mar 31, 2025
03dc975
Don't send undefined redirect urls
bendvc Apr 1, 2025
152aa8a
Use extension config not app config in checkout
bendvc Apr 1, 2025
6ed7d9f
Fix idps destructure
bendvc Apr 1, 2025
b5cd201
Fix test and pr feedback
bendvc Apr 1, 2025
d5d983e
Remove debugging logs
bendvc Apr 2, 2025
3c48a34
Removed unused error handler middleware
bendvc Apr 2, 2025
73d4793
Adding flex value as this component is used in display flex
bendvc Apr 2, 2025
14325a9
Better fix, still not great
bendvc Apr 2, 2025
d5e2de7
Fix issue with null pointer
bendvc Apr 2, 2025
caa865b
Lint
bendvc Apr 2, 2025
a45ea36
Update with-layout.tsx
bendvc Apr 2, 2025
9fbd8e7
Revert "remove extension-url-mapping, logging, changes to typescript-…
hajinsuha1 Apr 4, 2025
7dc6873
remove extension-url-mapping, logging, changes to typescript-minimal""
hajinsuha1 Apr 4, 2025
713d4e0
Revert "remove extension-url-mapping, logging, changes to typescript-…
hajinsuha1 Apr 4, 2025
fd025e6
Add displayName to Sample component and update component reference in…
hajinsuha1 Apr 4, 2025
5cf6e06
Commit for testing serialization
hajinsuha1 Apr 4, 2025
07e29dd
Merge branch 'route-serialization-to-support-shopper-seo-integration'…
hajinsuha1 Apr 4, 2025
533020b
fix package.json
hajinsuha1 Apr 4, 2025
840161e
Revert "Commit for testing serialization"
hajinsuha1 Apr 7, 2025
1504b0a
fix componentMap for testing in extension url mapping
hajinsuha1 Apr 7, 2025
26a60d6
Commit for testing serialization
hajinsuha1 Apr 7, 2025
b43928d
Merge branch 'feature/extensibility-v2' into route-serialization-to-s…
hajinsuha1 Apr 8, 2025
585669d
[App Extensibility] make sure DNT feature still works as expected (@W…
vmarta Apr 5, 2025
d0299fb
Add `build:watch` script, like what other packages have (#2346)
vmarta Apr 7, 2025
73f09f1
[App Extensibility] Bring back and fix the recently-skipped tests (@W…
vmarta Apr 8, 2025
66fc821
Initial commit
bendvc Apr 2, 2025
5bcec25
Lint
bendvc Apr 3, 2025
3d5febc
return empty routes when possible
hajinsuha1 Apr 10, 2025
a49f564
Merge branch 'route-serialization-to-support-shopper-seo-integration'…
hajinsuha1 Apr 10, 2025
a200b71
update unit tests
hajinsuha1 Apr 10, 2025
59c8eb7
Revert "Commit for testing serialization"
hajinsuha1 Apr 10, 2025
e6405b4
address PR feedback
hajinsuha1 Apr 11, 2025
02ef399
Revert "Revert "Commit for testing serialization""
hajinsuha1 Apr 11, 2025
80a9fb0
introduce NOT_CACHED symbol so that _cachedRoutes never has to be null
hajinsuha1 Apr 11, 2025
24b2195
fix unit tests
hajinsuha1 Apr 11, 2025
ba61551
add todo comment
hajinsuha1 Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions packages/extension-url-mapping/.eslintrc.js
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/extension-url-mapping/.prettierignore
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions packages/extension-url-mapping/.prettierrc.yaml
View file
Open in desktop

This file was deleted.

108 changes: 0 additions & 108 deletions packages/extension-url-mapping/README.md
View file
Open in desktop

This file was deleted.

89 changes: 0 additions & 89 deletions packages/extension-url-mapping/config/README.md
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions packages/extension-url-mapping/config/default.json
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions packages/extension-url-mapping/extension-meta.json
View file
Open in desktop

This file was deleted.

Loading
Loading