Skip to content

Fix server timing header delimiter#2314

Merged
kevinxh merged 6 commits intodevelopfrom
bugfix/server-timing
Mar 12, 2025
Merged

Fix server timing header delimiter#2314
kevinxh merged 6 commits intodevelopfrom
bugfix/server-timing

Conversation

@kevinxh
Copy link
Contributor

@kevinxh kevinxh commented Mar 12, 2025

Description

This is a follow up for PR - #2295

Apparently I missed a : sign, this PR fixes the issue and add tests

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@kevinxh kevinxh requested a review from a team as a code owner March 12, 2025 17:59
@kevinxh kevinxh added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Mar 12, 2025
@kevinxh kevinxh requested review from adamraya and vcua-mobify March 12, 2025 18:08
@kevinxh kevinxh merged commit 7de8580 into develop Mar 12, 2025
35 checks passed
@kevinxh kevinxh deleted the bugfix/server-timing branch March 12, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants