Skip to content

[App Extensibility] Bring back recently-commented-out Github actions (@W-18219092@)#2351

Merged
vmarta merged 53 commits intofeature/extensibility-v2from
vm/bring-back-github-actions
Apr 24, 2025
Merged

[App Extensibility] Bring back recently-commented-out Github actions (@W-18219092@)#2351
vmarta merged 53 commits intofeature/extensibility-v2from
vm/bring-back-github-actions

Conversation

@vmarta
Copy link
Contributor

@vmarta vmarta commented Apr 9, 2025 •
edited
Loading

Recently, while we were merging the latest changes from develop, we had to skip/comment out some CI actions: bundle size test, smoke-testing the npm scripts, and lighthouse tests. In this PR, we're bringing them back.

Since there's no more retail-react-app package in the extensibility branch, the tests will run against a generated project instead.

While bringing back the above tests, I also took some time to rearrange some stuffs. Highlights of the changes:

  • bundle size: the related steps are now all together in 1 action and also ran with a separate job.
  • smoke testing the npm scripts: it's ran earlier in the workflow (before the unit tests), so that the smaller tests could run first (and fail more quickly)
  • lighthouse test: it's currently commented out because the result is not useful when run against a local dev server.

Take a look at the comments below to see more details of the changes.

TODOs:

  • remove console logs

How to test drive the PR

Browse the test workflow and make sure that the jobs are all passing.

vmarta added 30 commits April 8, 2025 17:18
@vmarta
Actions: bundle size and npm scripts
c72e794
@vmarta
Tweak condition
b4703b4
@vmarta
Lighthouse test
d5d5cc1
@vmarta
Fix test workflow
fc57780
@vmarta
Try different way to set env variable
a2683da
@vmarta
Aargh, forgot to close the quote
32a38ea
@vmarta
Comment out lighthouse test for now
651ad64
@vmarta
Move to separate job those that don't test code correctness
b6e961b
@vmarta
Refactor the MRT's node version
42ed6d8
@vmarta
Try fixing error
cdf9b69
@vmarta
Try fixing error
4f982ca
@vmarta
Experiment with bundlesize
3a50d09
@vmarta
Check bundle sizes
024c0a8
@vmarta
Simplify code with github.action_path
565fefd
@vmarta
Debugging
8728f09
@vmarta
Workaround for bug with bundlesize
08a0ff4 
bundlesize cannot handle absolute path to the config file. See siddharthkp/bundlesize#326
@vmarta
Lighthouse test now accepts config filename to be more reusable
6e64b34
@vmarta
Experiment with passing in json config
e35e4aa
@vmarta
Experiment with passing in json config
1158ef2
@vmarta
For the other jobs, run the npm-scripts test
a2c1732
@vmarta
Add comment to clarify
e03a9dd
@vmarta
Remove duplicate test
74116b7 
It's already run in the generated and generated-windows jobs.
@vmarta
Revert "Remove duplicate test"
643927b 
This reverts commit 74116b7.
@vmarta
Smoke testing npm scripts now run in all nodes and OSes
2e98294
@vmarta
Delete no-longer-needed code
b92ccff
@vmarta
Test running an invalid command
757aaa6
@vmarta
Test running an invalid command
98d9429
@vmarta
Move more things to setup_ubuntu and setup_windows
d50e055
@vmarta
Move more things to setup_ubuntu and setup_windows
6803ca5
@vmarta
Move more things to setup_ubuntu and setup_windows
570222d
vmarta
vmarta commented Apr 21, 2025
View reviewed changes
.github/workflows/test.yml Outdated
npm install -g npm@${{ matrix.npm }}
node packages/pwa-kit-create-app/scripts/create-mobify-app-dev.js --outputDir ${{ env.PROJECT_DIR }}
env:
GENERATOR_PRESET: retail-react-app-test-project
Copy link
Contributor Author

@vmarta vmarta Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since retail-react-app no longer exists, we generate a project with this preset.

.github/workflows/test.yml

# - name: Run smoke tests
# if: env.IS_TEMPLATE_FROM_RETAIL_REACT_APP == 'true'
# uses: "./.github/actions/smoke_tests"
Copy link
Contributor Author

@vmarta vmarta Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action is no longer needed, since it's covered somewhere else.

.github/workflows/test.yml
Comment on lines +340 to +342
# NOTE: Commenting out this lighthouse test because it's run against a _local_ server that skews the performance metrics to be better than they really are.
# TODO: perhaps run lighthouse in another workflow (e2e one) that deploys to MRT and test against that.
# lighthouse:
Copy link
Contributor Author

@vmarta vmarta Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think as it is currently (and previously), the lighthouse test result is not useful because the performance score is too high (in the 90s). And it's because we were running the test against a local dev server.

Copy link
Contributor

@shethj shethj Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have a long-running demo site deployed, should we run these test against a deployed site ?

Copy link
Contributor Author

@vmarta vmarta Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it makes sense to run them in the E2E workflow.

.github/workflows/test.yml
# project_dir: ${{ env.PROJECT_DIR }}
# config_filename: lighthouserc.retail-react-app.js

bundle-sizes:
Copy link
Contributor Author

@vmarta vmarta Apr 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running bundle-size related steps in a separate job (rather than within pwa-kit job) because if they fail, it's clearer where the failure is. And they won't interfere with the rest of pwa-kit job.

In other words, I think of pwa-kit job as responsible for testing the code correctness, while other jobs like the bundle-sizes are for testing the performance.

Copy link
Contributor

@adamraya adamraya Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have project-specific bundle size limits, not a single global bundle-size test. Since we generate different projects in CI, each with specific presets, every project should have its own custom file size limits.

Copy link
Contributor Author

@vmarta vmarta Apr 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, the bundle_size_test action does accept input that allows you to configure the size limits. In this case, the limits are defined as '{"build/main.js": "10kB", "build/vendor.js": "390kB"}' (see line 398 below). But we can imagine for other jobs/workflows, we'll pass in different limits.

.github/actions/npm_scripts/action.yml
@@ -1,14 +1,12 @@
name: smoke_tests
name: npm_scripts
Copy link
Contributor Author

@vmarta vmarta Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming this CI action to be clearer that we're actually smoke testing the npm scripts (and not retail-react-app site).

.github/actions/setup_ubuntu/action.yml
Comment on lines -16 to -20
# Build the PWA
# npm run lerna -- run analyze-build --scope "@salesforce/retail-react-app"

# Report bundle sizes
# node ./scripts/report-bundle-size.js
Copy link
Contributor Author

@vmarta vmarta Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bundle-related stuffs are moved to their own action file.

Focusing this setup_ubuntu action for mainly setting up node and npm. So that the action is more generic and reusable.

.github/workflows/test.yml
Comment on lines +31 to +35
# The current recommended version for Managed Runtime:
# https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/upgrade-node-version.html
# NOTE: if you update these values, please also update `IS_MRT_NODE`.
MRT_NODE: 22
MRT_NPM: 10
Copy link
Contributor Author

@vmarta vmarta Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonus: refactor the MRT node version, so that there are less places we need to update, when we bump up the node version in the future.

scripts/report-bundle-size.js Outdated
const value = bundle.size
childProc.spawnSync('dog', [
// TODO: is dog installed yet?
const {status, stderr, error} = childProc.spawnSync('dog', [
Copy link
Contributor Author

@vmarta vmarta Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since last October, our datadog has failed to run properly because it has not been installed when this command runs.

scripts/smoke-test-npm-scripts.js
/^start.*$/,
/^compile-translations.*$/,
/^extract-default-translations.*$/,
/^bump-version.*$/
Copy link
Contributor Author

@vmarta vmarta Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer have bump-version script at the individual package level.

@vmarta vmarta requested review from adamraya and shethj April 21, 2025 19:00
adamraya
adamraya reviewed Apr 22, 2025
View reviewed changes
.github/workflows/test.yml
Comment on lines +387 to +392
- name: Generate retail-react-app-test-project
run: |-
node packages/pwa-kit-create-app/scripts/create-mobify-app-dev.js --outputDir ${{ env.PROJECT_DIR }}
env:
GENERATOR_PRESET: retail-react-app-test-project
timeout-minutes: 8
Copy link
Contributor

@adamraya adamraya Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you consider creating a reusable action for generating a project?

Copy link
Contributor Author

@vmarta vmarta Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did. But there are already existing actions that generate a project (like generate_app and e2e_generate_app) and they're not what I needed.

I guess we can create a new action and call it like generate_app_with_preset.

adamraya
adamraya reviewed Apr 22, 2025
View reviewed changes
.github/workflows/test.yml
uses: "./.github/actions/bundle_size_test"
with:
cwd: ${{ env.PROJECT_DIR }}
config: '{"build/main.js": "10kB", "build/vendor.js": "390kB"}'
Copy link
Contributor

@adamraya adamraya Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reasoning of defining the file sizes in the GitHub workflow rather than define these values in the package.json file?

Copy link
Contributor Author

@vmarta vmarta Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we no longer have retail-react-app package, we don't have a file where we can put those config values. The typescript-minimal template is not a good place either, because by default, it's minimal and does not have the same content as retail-react-app.

Alternatively, we can have a config file and put it inside the actions/bundle_size_test folder. But I ran into a bug:

pwa-kit/.github/actions/bundle_size_test/action.yml

Lines 18 to 20 in f096f6f

# NOTE: A bug prevented us from running bundlesize with a config file:
# npx bundlesize --scope ${{ github.action_path }}/bundlesize.config.json
# For more details, see https://github.com/siddharthkp/bundlesize/issues/326

adamraya
adamraya reviewed Apr 22, 2025
View reviewed changes
.github/actions/bundle_size_test/action.yml Outdated
json_string='${{ inputs.config }}'

# Parse the given json string and build the command to run
echo $json_string | jq -r 'to_entries[] | "npx bundlesize -f \"" + .key + "\" -s " + .value' | while read -r command; do
Copy link
Contributor

@adamraya adamraya Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some error handling in the jq parsing and print a message to the command failed?

@vmarta vmarta marked this pull request as ready for review April 22, 2025 20:42
@vmarta vmarta requested a review from a team as a code owner April 22, 2025 20:42
shethj
shethj reviewed Apr 23, 2025
View reviewed changes
.github/actions/lighthouse_ci/lighthouserc.retail-react-app.js
assert: {
aggregationMethod: 'median',
assertions: {
// NOTE: Adjust the scores accordingly as the performance is improved
Copy link
Contributor

@shethj shethj Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: Does the CI fail if these scores aren't met or do we just report the results and continue ?

Copy link
Contributor Author

@vmarta vmarta Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the lines below, we chose to use error (instead of warn), so CI will fail. And it will also report the result and continue because the lighthouse test runs in a separate job.

@vmarta vmarta merged commit cb384b5 into feature/extensibility-v2 Apr 24, 2025
33 checks passed
@vmarta vmarta deleted the vm/bring-back-github-actions branch April 24, 2025 00:34
adamraya added a commit that referenced this pull request May 6, 2025
@adamraya @vcua-mobify
@vmarta @hajinsuha1 @yunakim714 @bendvc @mitesh-patel-crm @kevinxh @carson-campbell @alexvuong @shethj
[App Extensibility ⚙️] Deploy -extensibility-preview.04 (@W-1791007…
b5f6205 
…5@) (#2402)

* @W-17589798@ Bump develop to v3.10.0-dev (#2278)

* Update changelog files

* Bump to the preview versions

* Bump up preview versions

* @W-17589798@ Release preview version 3.9.0-preview.2 (#2264)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* @W-17589798@ Release preview version 3.9.0-preview.3 (#2268)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* @W-17589798@ Release preview version 3.9.0-preview.4 (#2272)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

* Fix import error template retail react app (#2270)

* revert babel.config.js workaround

* move everything out of utils into ssr.js or default.js

* update default.js templates

* update ssr.js templates

* rerun ci jobs

* rerun ci jobs

* Bump versions

---------

Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Update CHANGELOG.md

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* @W-17589798@ Release preview version 3.9.0-preview.5 (#2274)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

* Fix import error template retail react app (#2270)

* revert babel.config.js workaround

* move everything out of utils into ssr.js or default.js

* update default.js templates

* update ssr.js templates

* rerun ci jobs

* rerun ci jobs

* Bump versions

---------

Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Update CHANGELOG.md

* Add missing `_app-config` template changes (#2273)

* @W-17589798@ Release preview version 3.9.0-preview.4 (#2272)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

* Fix import error template retail react app (#2270)

* revert babel.config.js workaround

* move everything out of utils into ssr.js or default.js

* update default.js templates

* update ssr.js templates

* rerun ci jobs

* rerun ci jobs

* Bump versions

---------

Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Update CHANGELOG.md

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* add missing app config template changes

* update both app config templates

---------

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Bump version to 3.9.0-preview.5

* Update CHANGELOG.md

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>
Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>

* @W-17589798@ PWA Kit v3.9.0, commerce-sdk-react 3.2.0, retail-react-app 6.0.0 Release (#2277)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

* Fix import error template retail react app (#2270)

* revert babel.config.js workaround

* move everything out of utils into ssr.js or default.js

* update default.js templates

* update ssr.js templates

* rerun ci jobs

* rerun ci jobs

* Bump versions

---------

Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Update CHANGELOG.md

* Add missing `_app-config` template changes (#2273)

* @W-17589798@ Release preview version 3.9.0-preview.4 (#2272)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

* Fix import error template retail react app (#2270)

* revert babel.config.js workaround

* move everything out of utils into ssr.js or default.js

* update default.js templates

* update ssr.js templates

* rerun ci jobs

* rerun ci jobs

* Bump versions

---------

Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Update CHANGELOG.md

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* add missing app config template changes

* update both app config templates

---------

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Bump version to 3.9.0-preview.5

* Update CHANGELOG.md

* Bump versions

* Update changelogs

* Update CHANGELOG.md

* Update peer dep in package-lock

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>
Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>

* Bump version to 3.10.0-dev

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>
Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>

* Undo change

not sure whats going on this this new line issue.

* Clean up storefront extension dependencies

* Added missing commerce-react dep

* Re-order package.json

* More dependency cleanup

* Revert changes to storefront package.json

* More dep clean up

* Remove some unused deps

* Re lock projects

* @W-17643479@ Add page meta data to search results and product pages (#2282)

* Add page meta data to search results and product pages

* Changelog

* Apply suggestions

---------

Signed-off-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Don't use dependencies in extensions

* [App Extensibility ⚙️] Fix Issues with Pushing Bundles to MRT (@W-17779391@) (#2281)

* Remove core-polyfill

* Fix commerce-sdk-react peerDependency version

* Update package-lock.json

* Update bump-version script

* PR Feedback

* Add more docs

* Revert "Add more docs"

This reverts commit 59715d2.

* Revert "PR Feedback"

This reverts commit 42b10d6.

* Revert "Update bump-version script"

This reverts commit 7387793.

* Move deps to peer deps

* Fix merge conflicts and re-lock packages

* Forgot to commit lock files

* @W-17286066 Remove forced garbage collection per invocation (#2285)

* Remove forced garbage collection on each invocation.
* Allow FORCE_GC env-var to enable old behavior.
* Added /memtest endpoint to mrt reference app.
* updated CHANGELOG.md with link to PR.

* Update TUTORIAL.md

Signed-off-by: Kevin He <kevin.he@salesforce.com>

* Fix tests

Recent changes to "@testing-library/user-event" broke our tests.

* Make same change for template

* Enable Social & Passwordless Login in Demo Storefront (#2284)

* Increas max size for vendor

* Use `^` in starter extension

* [App Extensibility ⚙️] Fix Slow Dev Server start on Windows (@W-17792667@) (#2289)

* Use thread-loader

* Replace event-emitter with EventTarget

* Clean up

* Fix test

* Add evt.detail to tests

* Update thread-loader config

* Remove extensions from typescript-minimal & Update changelogs

* Solve merge conflicts

* Increase build/main.js maxSize

* Revert social and passwordless login in develop (#2292)

* use . for server timing delimiter

* add changelog

* update react query performance delimiter

* update getProps performance header delimiter

* Update TUTORIAL.md

Signed-off-by: Kevin He <kevin.he@salesforce.com>

* @W-17760517@ Automatically update bug bounty instance on new release (#2291)

* Add new preset

* New workflow for bug bounty deploy

* Fix indent

* Add runs-on

* Install deps

* temp remove step conditions

* set credentials file to default

* Test version check

* Trigger on Github release

* Test

* Test2

* test 3

* test 4

* test5

* test6

* test7

* test8

* test9

* test10

* test11

* test12

* test13

* test 14

* test 15

* test16

* test17

* test18

* test19

* test20

* test21

* test22

* test23

* test24

* test25

* test26

* Restore actual changes

* Test by reversing condition

* Revert conditional to what we want

* apply suggestions + refactor

* flip condition for testing

* Fix file structure

* Add checkout

* Specify shell

* Set token as input

* Checkout before node setup

* Use correct condition

* Allow custom bundle message on deploy

* Add quotes

* Set tag name

* Remove bracket

* Update condition

* [App Extensibility ⚙️] Polish Project Generator (@W-17910008@) (#2293)

* Remove Do you want to use Extensibility question & Fix outputDir

* Remove debug logs

* Remove Choose a project preset to get started question

* Clean up extensionName redundancy

* Update TUTORIAL.md

* lint

* Bump core to 3.9.1 and point versions for independent packages

* Cherry pick PR2285

* Update readmes

* Update package-lock.json

* Bad merge

* Fix bad merge again

* Lint fix

* update cloudwatch sender maxRetries to 0

* add comment

* add changelog

* bump version to v3.9.2

* empty commit

* @W-17900760@ Deploy Demo Storefront with SLAS Private Client (#2297)

* WIP

* Use zzrf-001 stg

* Set output

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* Add logging

* fix conditional

* Add brackets

* fix

* fix

* adjust

* test

* test

* test

* flip condition for testing

* Update handlebars for RefArchGlobal locales

* Add US locale + currency to RefArchGlobal and set as default

* Add site alias

* Enable passwordless and social login

* Adjust comment since handlebars don't add a newline

* Apply aliases

* Adjust newline

* Comment

* Add siteid and locale to demo path

* Enable site setting

* Re-add handlebar helper

* showDefaults: true

* Use translatable title for demo store

* Fix lint

* Deploy to production demo site

* Re-enable bug bounty deploy

* Use Salesforce Cloud as default logo for extensible projects

* Change condition so we run a deploy

* Restore latest release condition

* Revert "Use Salesforce Cloud as default logo for extensible projects"

This reverts commit 6ec6c7b.

* Use a non-extensible template for demo site

* Deploy demo site

* Revert deployment condition

* Apply suggestions

* Fallback name if no release tag name

* test

* test

* New step for bundle name

* fix else

* Use new step with everything else

* redeploy demo site

* Fix conditions after release

* Test matrix

* Handle secrets outside of matrix

* test

* Fix api key name

* Set flags and don't fail-fast

* Reapply on release condition

* fix server timing header delimiter

* skip changelog

* add tests

* remove comment

* lint

* resolve conflict

* @W-17405592 - DataCloud Events in PWA (#2229) (#2318)

Send analytics events from the PWA Kit to Data Cloud

---------

Signed-off-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
Co-authored-by: Carson Campbell <170666418+carson-campbell@users.noreply.github.com>

* [App Extensibility ⚙️] Add script to display all files in an extension that can be overridden (@W-17555422@) (#2299)

* Init list-overridables script

* Support loadable overridables import

* Look for overridable imports in the configured extensions

* Split command into two

* Reuse helpers getConfiguredExtensions

* lint

* Fix tests

* Clean up

* Fix check-overrides using findOverrideFiles

* Fix duplicate imports

* Reuse resolver getPackageName

* clean up

* lint

* Fix tests

* Update hasCorrespondingOverridableImport path matching

* Include the file list that match overridable imports

* Simplify hasCorrespondingOverridableImport

* lint

* Extract utils from webpack overrride-resolver loader

* Add js docs

* Add tests

* Fix Windows tests

* Use path.sep to normalize paths

* Clean up use webpack plugin alternative approach

* OverrideStatsPlugin Webpack plugin

* Fix list-overrides on Windows

* Update pwa-kit-extension-sdk lock files

* Add sourceExtension to override stats

* PR Feedback

* Add OverrideStatsPlugin tests

* Add types to OverrideStatsPlugin tests

* Add more types

* PR Feedback

* Update test to use virtual filesystem

* lint

* Add docs

* Add more tests to overrides-resolver-loader

* PR Feedback docs

* Bypass test on Windows

* Update lock files

* Lint Fixes

* Fix chakra imports

* Lint

* Use Act in test, and port network mocks

* Add global mock for cc-datacloud-typescript lib

Because this was a module we couldn't use jest without having to either use an experimental flag on jest.

* Bump bundle max sizes

* Enable ssh to test workflow failures

* Undo e2e

* Add action to display content of .bin for debugging

* Fix workflow

* Update test.yml

* Relock packages in an attempt to fix ci errors

* Remove debugging

* more debugging

* Update test.yml

* Add debugging logs

* more debugging

* more debugging

* more logging

* Fix for node 22

Node 22 doesn't like using npm pack without a version, might be a bug with verdaccio

* Remove debug logs and add latest when using npm pack

* Remove more debug logs

* Move move storefront to storefront-old

* Move retail template to extension folder

* '/app' becomes '/src'

* Move the README

* Copy setup files

* Fix location of setup files

* These files aren't required in an extension

* Remove old config and replace with new config

* Move types

* Move meta data file

* Migrate router to extension with changes.

* Update jest-setup

* Migrate jest.config.

* Migrate package.json

* Remove special components and add their replacements

* Migrate changes to useAddressFields component

* Migrate changes for header component

* Migrate associated tests

* Migrate tests for link component

* Migrate changes for product-tile component

* Migrate search component

* Migrate search partial component

* Migrate seo component

* Migrate constants file

* Migrate hooks index

* Migrate use-active-data hook and tests

* Migrate various hook changes and test fixes

* Migrate mock data

Note: Unsure about whether mockedRegisteredCustomerWithNoNumber should have been re-added

* Migrate account pages.

* Migrade checkout page changes

* Migrate checkout partial changes

* Migrate product-list components

* Migrate theme colors

* Migrate utils

* migrate project files/configs

* Remove unused files in extension projects

* Move static folder

* Update eslint ignore

* Remove some more unused scripts/folders

* Fix lint warnings

* Fix import paths for hooks

* Migrate theme index

* Replace `@salesforce/template-retail-react-app` imports with relative ones

* Linting

* Migrate page-designer assets

* Migrate page-designer layouts

* Migrate page-designer misc

* Migrate utils

* Migrate theme base and project folders

* Migrate theme foundations

* Update imports for account pages

* Update cart page imports

* Migrate home page

* Migrate login page

* Migrate login-redirect page

* Migrate page-not-found page

* Migrate the product-details page

* Migrate product-list page

* Migrate registration page

* Migrate reset password

* Migrate checkout page

* Migrate cart pages

* Migrate account pages

* Lint

* Chane aliased imports to relative imports for new code

* Remove `template-retail-react-app` from generator

* Migrate mocks folder

* Migrate search component partials folder

* Migrate svg assets

* Migrate contexts file

* Delete chakra storefront old project

* Re-generate lock files across mono repo

* Add data cloud types and update code to work with as an extension

* Fix login page

* Lint

* W-17908517 - Fix basket loading after logging out (#2323)

* fix basket loading after logging out

* Fix some tests, rework others

Re-worked the data cloud tests, still a work in progress.

* Fix some failing tests

Skip header tests
Skip datacloud tests

* Remove references to old template

Remove ci bundle analyzer action

* Remove smoke and lighthouse tests for defunct retail template

* Remove other instance of smoke test script runner

* Update test.yml

* Remove code that was added back via a merge

* Remove code that was added as a result of a bad merge

* Update peer deps for storefront extension

* Remove mobify object from extensions package.json files (#2336)

* [App Extensibility] replace `extendRoutes` with `getRoutes` and `getRoutesAsync` @W-17916765@ (#2308)

* Convert extendRoutes to an async method

* Add todos

* Temporarily modify the typescript-minimal project

* Minor refactoring

* Call every extension's route function in parallel

For a simpler implementation, replaced extendRoutes with getRoutes. Probably safer too, since we think there's no need to have access to the existing/previous routes.

* Pass in the request path

* Explore passing in locals and how to manage access token

* Remove extendRoutes from the API

* Allow configuring of the auth property name in locals

* Rename the property in locals

* Create a new extension for a better example

* Add some console logs

* Experiment with having partial route

Partial route in the getRoutes, and then completing it during beforeRouteMatch.

* Experiment with correct way to get app origin

* Add todo

* Some cleanup

* Fix the partial route with correct path

* Remove no longer necessary code

* Combine params into a single object

* Remove some console logs

* Add comment to clarify

* Implement getRoutes and getRoutesAsync

Co-Authored-By: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-Authored-By: Ben Chypak <bchypak@salesforce.com>

* Add comment

* Add comment

* Add type to allow for `componentName` property

* Remove params for `getRoutes`

Only `getRoutesAsync` who needs the params.

* Remove params for getRoutes

* Revert "Remove params for `getRoutes`"

This reverts commit 38e352f.

* Revert "Remove params for getRoutes"

This reverts commit 4119cda.

* Update comments

* Update tests

* Update tests

* Revert changes to typescript-minimal

* Update package-lock.json

* Update changelog files

* Update readme files

* Add jsdoc to some types

* Rename test to make it clearer

* Empty commit

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Ben Chypak <bchypak@salesforce.com>

* Initial refactor of ssr into setup-server

* Refactor some of the utils and create middleware

* Remove wishlist from configurate list of pages for now

* Fix some lint errors

* [App Extensibility ⚙️] Pin Specific Versions for Extensions in Generated Project (@W-17779226@) (#2339)

* Use npm view to get the latest version

* Update available-app-extensions.json

* lint

* Prepend caret (^) to the version number

* [Snyk] Dependency updates (#2338)

* Update nanoid dependency

* Override path-to-regexp version

* Update CHANGELOG.md

* Apply snyk version bumps

* Update changelogs

* Update CHANGELOG.md

* Update changelogs

* Fix jwks path and replace constants with configurable values

* Empty commit

* Fix regression and fix some tests config

* Fix mock config

* Don't send undefined redirect urls

* Use extension config not app config in checkout

* Fix idps destructure

* Fix test and pr feedback

* Initial commit

* Remove debugging logs

* Removed unused error handler middleware

* Adding flex value as this component is used in display flex

* Better fix, still not great

* Fix issue with null pointer

* Lint

* Update with-layout.tsx

* Lint

* [App Extensibility] make sure DNT feature still works as expected (@W-18128633@) (#2345)

* Show DNT banner

* Make default DNT state configurable

* Add `build:watch` script, like what other packages have (#2346)

* [App Extensibility] Bring back and fix the recently-skipped tests (@W-18120857@) (#2349)

* Bring back the data-cloud tests

For some reason, jest cannot mock js-cookie. It crashed with out-of-memory error.

So I decided to avoid mocking it. Calling `Cookie.get` would return either a string or undefined (if not found). So I adjusted our mocks to allow for undefined value as well.

* Fix header tests

My Account icon actually gets rendered with 'My account' label (note that it's a small-case "a").

* Revert "Bring back the data-cloud tests"

This reverts commit 16978e1.

* Mock js-cookie in a different way

Such that we won't run into the out-of-memory error.

* Route serialization to support Shopper SEO URL mapping integration (#2300)

* update Switch component to load routes from RoutesProvider and RoutesContext
* Server: update react-rendering.js to serialize extensions that have getRoutesAsync implemented and save it under window.__EXTENSIONS__ global variable
* update ApplicationExtension to cache results from getRoutesAsync to _cachedRoutes property
* update ApplicationExtension to deserialize routes from window.__EXTENSIONS__ when on the client and save it under _cachedRoutes

* [App Extensibility] Bring back recently-commented-out Github actions (@W-18219092@) (#2351)

* Actions: bundle size and npm scripts

* Tweak condition

* Lighthouse test

* Fix test workflow

* Try different way to set env variable

* Aargh, forgot to close the quote

* Comment out lighthouse test for now

* Move to separate job those that don't test code correctness

* Refactor the MRT's node version

* Try fixing error

* Try fixing error

* Experiment with `bundlesize`

* Check bundle sizes

* Simplify code with github.action_path

* Debugging

* Workaround for bug with bundlesize

bundlesize cannot handle absolute path to the config file. See siddharthkp/bundlesize#326

* Lighthouse test now accepts config filename to be more reusable

* Experiment with passing in json config

* Experiment with passing in json config

* For the other jobs, run the npm-scripts test

* Add comment to clarify

* Remove duplicate test

It's already run in the generated and generated-windows jobs.

* Revert "Remove duplicate test"

This reverts commit 74116b7.

* Smoke testing npm scripts now run in all nodes and OSes

* Delete no-longer-needed code

* Test running an invalid command

* Test running an invalid command

* Move more things to setup_ubuntu and setup_windows

* Move more things to setup_ubuntu and setup_windows

* Move more things to setup_ubuntu and setup_windows

* Debugging

* Debugging

* Debugging

* Debugging

* Debugging

* Debugging

* Debugging

* Debugging

* New step to verify Node and NPM versions

* Debugging windows

* Some refactoring

* Prints clearer message

* Clean up code

* A bit of reordering

* Add comments

* Add comments

* Add error handling for jq

* Extract the app generation into its own action

* Fix the error handling

* Fix action

* The timeout-minutes cannot be used inside an action

* Remove console log

* Sync with latest develop branch

* Initial implementation

* Update package lock files

* @W-13747172 Fix a11y (#2375)

* fix a11y

* @W-17830285@ Add custom parameters to SLAS authorize calls (#2358)

* Allow custom parameters to SLAS authorize calls

* Update CHANGELOG.md

* Move extractCustomParameters to utils

* Use options and body instead of parameters for consistency

* Ensure only custom parameters are set from register to login

* Don't send custom params to shopperCustomer register

* Allow custom params to be set via login.mutateAsync

* Update tests using ShopperCustomers

* Apply feedback

* Add comments

* Lint

* Pin to previous version of cc-datacloud-typescript

Their latest 1.1.0 release that's out today was causing an error with building our pwa-kit project.

* Revert "Pin to previous version of cc-datacloud-typescript"

This reverts commit e558f52.

* Make constants file, clean up, remove logs

* Update CHANGELOG.md

* Add tests for utilities.

* Committing temp version bump

* Revert "Committing temp version bump"

This reverts commit 398cfce.

* Fix failing tests

* Update package lock files

* Try replacing `sh.cat` with native file reading

See if such replacement works well on a Windows machine.

* Debug: see what gets generated

* Fix regression in getAsseturl

* Debugging

* Refactor file copying logic

* Clean up

* Revert "Try replacing `sh.cat` with native file reading"

This reverts commit dc26b6e.

* Remove debug code

* Add changelog for the chakra-storefront

* Update CHANGELOG.md

* [App Extensibility ⚙️] Remove `extension-` prefix requirement (@W-18131976@) (#2390)

* Remove extension prefix

* Clean changes in template-typescript-minimal

* Optimize detecting extensions logic

* WIP Fix tests

* Fix tests

* Fix tests

* Move import constant

* Refactor packagePath ternary

* Condensed fullPackagePath into one line

* Update package namespace and name extract logic

* Use validate-npm-package-name in generator

* lint

* Adjust generator copy

* Update packages/pwa-kit-create-app/scripts/create-mobify-app.js

Co-authored-by: Kevin He <kevin.he@salesforce.com>
Signed-off-by: Adam Raya <adamraya@users.noreply.github.com>

* PR Feedback detectExtensions args

---------

Signed-off-by: Adam Raya <adamraya@users.noreply.github.com>
Co-authored-by: Kevin He <kevin.he@salesforce.com>

* Update packages/pwa-kit-react-sdk/src/ssr/universal/utils.ts

Co-authored-by: Adam Raya <adamraya@users.noreply.github.com>
Signed-off-by: Ben Chypak <bchypak@mobify.com>

* PR feedback round 1

* Remove test configuration

* Remove sample override for testing

* Fix lint error

* Revert override

* Regenerate lock files

---------

Signed-off-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
Signed-off-by: Kevin He <kevin.he@salesforce.com>
Signed-off-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
Signed-off-by: Adam Raya <adamraya@users.noreply.github.com>
Signed-off-by: Ben Chypak <bchypak@mobify.com>
Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
Co-authored-by: Ben Chypak <bchypak@salesforce.com>
Co-authored-by: Ben Chypak <bchypak@mobify.com>
Co-authored-by: mitesh-patel-crm <85328777+mitesh-patel-crm@users.noreply.github.com>
Co-authored-by: Kevin He <kevin.he@salesforce.com>
Co-authored-by: mitesh.patel <mitesh.patel@salesforce.com>
Co-authored-by: Carson Campbell <170666418+carson-campbell@users.noreply.github.com>
Co-authored-by: Alex Vuong <alex.vuong@salesforce.com>
Co-authored-by: Jainam Sheth <j.sheth@salesforce.com>
adamraya added a commit that referenced this pull request May 7, 2025
@adamraya @vcua-mobify
@vmarta @hajinsuha1 @yunakim714 @bendvc @mitesh-patel-crm @kevinxh @carson-campbell @alexvuong @shethj
[App Extensibility ⚙️] Bump preview version to `-extensibility-previe…
ef57257 
…w.5` (#2404)

* [App Extensibility ⚙️] Deploy `-extensibility-preview.04` (@W-17910075@)  (#2402)

* @W-17589798@ Bump develop to v3.10.0-dev (#2278)

* Update changelog files

* Bump to the preview versions

* Bump up preview versions

* @W-17589798@ Release preview version 3.9.0-preview.2 (#2264)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* @W-17589798@ Release preview version 3.9.0-preview.3 (#2268)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* @W-17589798@ Release preview version 3.9.0-preview.4 (#2272)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

* Fix import error template retail react app (#2270)

* revert babel.config.js workaround

* move everything out of utils into ssr.js or default.js

* update default.js templates

* update ssr.js templates

* rerun ci jobs

* rerun ci jobs

* Bump versions

---------

Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Update CHANGELOG.md

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* @W-17589798@ Release preview version 3.9.0-preview.5 (#2274)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

* Fix import error template retail react app (#2270)

* revert babel.config.js workaround

* move everything out of utils into ssr.js or default.js

* update default.js templates

* update ssr.js templates

* rerun ci jobs

* rerun ci jobs

* Bump versions

---------

Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Update CHANGELOG.md

* Add missing `_app-config` template changes (#2273)

* @W-17589798@ Release preview version 3.9.0-preview.4 (#2272)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

* Fix import error template retail react app (#2270)

* revert babel.config.js workaround

* move everything out of utils into ssr.js or default.js

* update default.js templates

* update ssr.js templates

* rerun ci jobs

* rerun ci jobs

* Bump versions

---------

Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Update CHANGELOG.md

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* add missing app config template changes

* update both app config templates

---------

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Bump version to 3.9.0-preview.5

* Update CHANGELOG.md

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>
Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>

* @W-17589798@ PWA Kit v3.9.0, commerce-sdk-react 3.2.0, retail-react-app 6.0.0 Release (#2277)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

* Fix import error template retail react app (#2270)

* revert babel.config.js workaround

* move everything out of utils into ssr.js or default.js

* update default.js templates

* update ssr.js templates

* rerun ci jobs

* rerun ci jobs

* Bump versions

---------

Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Update CHANGELOG.md

* Add missing `_app-config` template changes (#2273)

* @W-17589798@ Release preview version 3.9.0-preview.4 (#2272)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

* Fix import error template retail react app (#2270)

* revert babel.config.js workaround

* move everything out of utils into ssr.js or default.js

* update default.js templates

* update ssr.js templates

* rerun ci jobs

* rerun ci jobs

* Bump versions

---------

Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Update CHANGELOG.md

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* add missing app config template changes

* update both app config templates

---------

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Bump version to 3.9.0-preview.5

* Update CHANGELOG.md

* Bump versions

* Update changelogs

* Update CHANGELOG.md

* Update peer dep in package-lock

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>
Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>

* Bump version to 3.10.0-dev

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>
Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>

* Undo change

not sure whats going on this this new line issue.

* Clean up storefront extension dependencies

* Added missing commerce-react dep

* Re-order package.json

* More dependency cleanup

* Revert changes to storefront package.json

* More dep clean up

* Remove some unused deps

* Re lock projects

* @W-17643479@ Add page meta data to search results and product pages (#2282)

* Add page meta data to search results and product pages

* Changelog

* Apply suggestions

---------

Signed-off-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Don't use dependencies in extensions

* [App Extensibility ⚙️] Fix Issues with Pushing Bundles to MRT (@W-17779391@) (#2281)

* Remove core-polyfill

* Fix commerce-sdk-react peerDependency version

* Update package-lock.json

* Update bump-version script

* PR Feedback

* Add more docs

* Revert "Add more docs"

This reverts commit 59715d2.

* Revert "PR Feedback"

This reverts commit 42b10d6.

* Revert "Update bump-version script"

This reverts commit 7387793.

* Move deps to peer deps

* Fix merge conflicts and re-lock packages

* Forgot to commit lock files

* @W-17286066 Remove forced garbage collection per invocation (#2285)

* Remove forced garbage collection on each invocation.
* Allow FORCE_GC env-var to enable old behavior.
* Added /memtest endpoint to mrt reference app.
* updated CHANGELOG.md with link to PR.

* Update TUTORIAL.md

Signed-off-by: Kevin He <kevin.he@salesforce.com>

* Fix tests

Recent changes to "@testing-library/user-event" broke our tests.

* Make same change for template

* Enable Social & Passwordless Login in Demo Storefront (#2284)

* Increas max size for vendor

* Use `^` in starter extension

* [App Extensibility ⚙️] Fix Slow Dev Server start on Windows (@W-17792667@) (#2289)

* Use thread-loader

* Replace event-emitter with EventTarget

* Clean up

* Fix test

* Add evt.detail to tests

* Update thread-loader config

* Remove extensions from typescript-minimal & Update changelogs

* Solve merge conflicts

* Increase build/main.js maxSize

* Revert social and passwordless login in develop (#2292)

* use . for server timing delimiter

* add changelog

* update react query performance delimiter

* update getProps performance header delimiter

* Update TUTORIAL.md

Signed-off-by: Kevin He <kevin.he@salesforce.com>

* @W-17760517@ Automatically update bug bounty instance on new release (#2291)

* Add new preset

* New workflow for bug bounty deploy

* Fix indent

* Add runs-on

* Install deps

* temp remove step conditions

* set credentials file to default

* Test version check

* Trigger on Github release

* Test

* Test2

* test 3

* test 4

* test5

* test6

* test7

* test8

* test9

* test10

* test11

* test12

* test13

* test 14

* test 15

* test16

* test17

* test18

* test19

* test20

* test21

* test22

* test23

* test24

* test25

* test26

* Restore actual changes

* Test by reversing condition

* Revert conditional to what we want

* apply suggestions + refactor

* flip condition for testing

* Fix file structure

* Add checkout

* Specify shell

* Set token as input

* Checkout before node setup

* Use correct condition

* Allow custom bundle message on deploy

* Add quotes

* Set tag name

* Remove bracket

* Update condition

* [App Extensibility ⚙️] Polish Project Generator (@W-17910008@) (#2293)

* Remove Do you want to use Extensibility question & Fix outputDir

* Remove debug logs

* Remove Choose a project preset to get started question

* Clean up extensionName redundancy

* Update TUTORIAL.md

* lint

* Bump core to 3.9.1 and point versions for independent packages

* Cherry pick PR2285

* Update readmes

* Update package-lock.json

* Bad merge

* Fix bad merge again

* Lint fix

* update cloudwatch sender maxRetries to 0

* add comment

* add changelog

* bump version to v3.9.2

* empty commit

* @W-17900760@ Deploy Demo Storefront with SLAS Private Client (#2297)

* WIP

* Use zzrf-001 stg

* Set output

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* Add logging

* fix conditional

* Add brackets

* fix

* fix

* adjust

* test

* test

* test

* flip condition for testing

* Update handlebars for RefArchGlobal locales

* Add US locale + currency to RefArchGlobal and set as default

* Add site alias

* Enable passwordless and social login

* Adjust comment since handlebars don't add a newline

* Apply aliases

* Adjust newline

* Comment

* Add siteid and locale to demo path

* Enable site setting

* Re-add handlebar helper

* showDefaults: true

* Use translatable title for demo store

* Fix lint

* Deploy to production demo site

* Re-enable bug bounty deploy

* Use Salesforce Cloud as default logo for extensible projects

* Change condition so we run a deploy

* Restore latest release condition

* Revert "Use Salesforce Cloud as default logo for extensible projects"

This reverts commit 6ec6c7b.

* Use a non-extensible template for demo site

* Deploy demo site

* Revert deployment condition

* Apply suggestions

* Fallback name if no release tag name

* test

* test

* New step for bundle name

* fix else

* Use new step with everything else

* redeploy demo site

* Fix conditions after release

* Test matrix

* Handle secrets outside of matrix

* test

* Fix api key name

* Set flags and don't fail-fast

* Reapply on release condition

* fix server timing header delimiter

* skip changelog

* add tests

* remove comment

* lint

* resolve conflict

* @W-17405592 - DataCloud Events in PWA (#2229) (#2318)

Send analytics events from the PWA Kit to Data Cloud

---------

Signed-off-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
Co-authored-by: Carson Campbell <170666418+carson-campbell@users.noreply.github.com>

* [App Extensibility ⚙️] Add script to display all files in an extension that can be overridden (@W-17555422@) (#2299)

* Init list-overridables script

* Support loadable overridables import

* Look for overridable imports in the configured extensions

* Split command into two

* Reuse helpers getConfiguredExtensions

* lint

* Fix tests

* Clean up

* Fix check-overrides using findOverrideFiles

* Fix duplicate imports

* Reuse resolver getPackageName

* clean up

* lint

* Fix tests

* Update hasCorrespondingOverridableImport path matching

* Include the file list that match overridable imports

* Simplify hasCorrespondingOverridableImport

* lint

* Extract utils from webpack overrride-resolver loader

* Add js docs

* Add tests

* Fix Windows tests

* Use path.sep to normalize paths

* Clean up use webpack plugin alternative approach

* OverrideStatsPlugin Webpack plugin

* Fix list-overrides on Windows

* Update pwa-kit-extension-sdk lock files

* Add sourceExtension to override stats

* PR Feedback

* Add OverrideStatsPlugin tests

* Add types to OverrideStatsPlugin tests

* Add more types

* PR Feedback

* Update test to use virtual filesystem

* lint

* Add docs

* Add more tests to overrides-resolver-loader

* PR Feedback docs

* Bypass test on Windows

* Update lock files

* Lint Fixes

* Fix chakra imports

* Lint

* Use Act in test, and port network mocks

* Add global mock for cc-datacloud-typescript lib

Because this was a module we couldn't use jest without having to either use an experimental flag on jest.

* Bump bundle max sizes

* Enable ssh to test workflow failures

* Undo e2e

* Add action to display content of .bin for debugging

* Fix workflow

* Update test.yml

* Relock packages in an attempt to fix ci errors

* Remove debugging

* more debugging

* Update test.yml

* Add debugging logs

* more debugging

* more debugging

* more logging

* Fix for node 22

Node 22 doesn't like using npm pack without a version, might be a bug with verdaccio

* Remove debug logs and add latest when using npm pack

* Remove more debug logs

* Move move storefront to storefront-old

* Move retail template to extension folder

* '/app' becomes '/src'

* Move the README

* Copy setup files

* Fix location of setup files

* These files aren't required in an extension

* Remove old config and replace with new config

* Move types

* Move meta data file

* Migrate router to extension with changes.

* Update jest-setup

* Migrate jest.config.

* Migrate package.json

* Remove special components and add their replacements

* Migrate changes to useAddressFields component

* Migrate changes for header component

* Migrate associated tests

* Migrate tests for link component

* Migrate changes for product-tile component

* Migrate search component

* Migrate search partial component

* Migrate seo component

* Migrate constants file

* Migrate hooks index

* Migrate use-active-data hook and tests

* Migrate various hook changes and test fixes

* Migrate mock data

Note: Unsure about whether mockedRegisteredCustomerWithNoNumber should have been re-added

* Migrate account pages.

* Migrade checkout page changes

* Migrate checkout partial changes

* Migrate product-list components

* Migrate theme colors

* Migrate utils

* migrate project files/configs

* Remove unused files in extension projects

* Move static folder

* Update eslint ignore

* Remove some more unused scripts/folders

* Fix lint warnings

* Fix import paths for hooks

* Migrate theme index

* Replace `@salesforce/template-retail-react-app` imports with relative ones

* Linting

* Migrate page-designer assets

* Migrate page-designer layouts

* Migrate page-designer misc

* Migrate utils

* Migrate theme base and project folders

* Migrate theme foundations

* Update imports for account pages

* Update cart page imports

* Migrate home page

* Migrate login page

* Migrate login-redirect page

* Migrate page-not-found page

* Migrate the product-details page

* Migrate product-list page

* Migrate registration page

* Migrate reset password

* Migrate checkout page

* Migrate cart pages

* Migrate account pages

* Lint

* Chane aliased imports to relative imports for new code

* Remove `template-retail-react-app` from generator

* Migrate mocks folder

* Migrate search component partials folder

* Migrate svg assets

* Migrate contexts file

* Delete chakra storefront old project

* Re-generate lock files across mono repo

* Add data cloud types and update code to work with as an extension

* Fix login page

* Lint

* W-17908517 - Fix basket loading after logging out (#2323)

* fix basket loading after logging out

* Fix some tests, rework others

Re-worked the data cloud tests, still a work in progress.

* Fix some failing tests

Skip header tests
Skip datacloud tests

* Remove references to old template

Remove ci bundle analyzer action

* Remove smoke and lighthouse tests for defunct retail template

* Remove other instance of smoke test script runner

* Update test.yml

* Remove code that was added back via a merge

* Remove code that was added as a result of a bad merge

* Update peer deps for storefront extension

* Remove mobify object from extensions package.json files (#2336)

* [App Extensibility] replace `extendRoutes` with `getRoutes` and `getRoutesAsync` @W-17916765@ (#2308)

* Convert extendRoutes to an async method

* Add todos

* Temporarily modify the typescript-minimal project

* Minor refactoring

* Call every extension's route function in parallel

For a simpler implementation, replaced extendRoutes with getRoutes. Probably safer too, since we think there's no need to have access to the existing/previous routes.

* Pass in the request path

* Explore passing in locals and how to manage access token

* Remove extendRoutes from the API

* Allow configuring of the auth property name in locals

* Rename the property in locals

* Create a new extension for a better example

* Add some console logs

* Experiment with having partial route

Partial route in the getRoutes, and then completing it during beforeRouteMatch.

* Experiment with correct way to get app origin

* Add todo

* Some cleanup

* Fix the partial route with correct path

* Remove no longer necessary code

* Combine params into a single object

* Remove some console logs

* Add comment to clarify

* Implement getRoutes and getRoutesAsync

Co-Authored-By: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-Authored-By: Ben Chypak <bchypak@salesforce.com>

* Add comment

* Add comment

* Add type to allow for `componentName` property

* Remove params for `getRoutes`

Only `getRoutesAsync` who needs the params.

* Remove params for getRoutes

* Revert "Remove params for `getRoutes`"

This reverts commit 38e352f.

* Revert "Remove params for getRoutes"

This reverts commit 4119cda.

* Update comments

* Update tests

* Update tests

* Revert changes to typescript-minimal

* Update package-lock.json

* Update changelog files

* Update readme files

* Add jsdoc to some types

* Rename test to make it clearer

* Empty commit

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Ben Chypak <bchypak@salesforce.com>

* Initial refactor of ssr into setup-server

* Refactor some of the utils and create middleware

* Remove wishlist from configurate list of pages for now

* Fix some lint errors

* [App Extensibility ⚙️] Pin Specific Versions for Extensions in Generated Project (@W-17779226@) (#2339)

* Use npm view to get the latest version

* Update available-app-extensions.json

* lint

* Prepend caret (^) to the version number

* [Snyk] Dependency updates (#2338)

* Update nanoid dependency

* Override path-to-regexp version

* Update CHANGELOG.md

* Apply snyk version bumps

* Update changelogs

* Update CHANGELOG.md

* Update changelogs

* Fix jwks path and replace constants with configurable values

* Empty commit

* Fix regression and fix some tests config

* Fix mock config

* Don't send undefined redirect urls

* Use extension config not app config in checkout

* Fix idps destructure

* Fix test and pr feedback

* Initial commit

* Remove debugging logs

* Removed unused error handler middleware

* Adding flex value as this component is used in display flex

* Better fix, still not great

* Fix issue with null pointer

* Lint

* Update with-layout.tsx

* Lint

* [App Extensibility] make sure DNT feature still works as expected (@W-18128633@) (#2345)

* Show DNT banner

* Make default DNT state configurable

* Add `build:watch` script, like what other packages have (#2346)

* [App Extensibility] Bring back and fix the recently-skipped tests (@W-18120857@) (#2349)

* Bring back the data-cloud tests

For some reason, jest cannot mock js-cookie. It crashed with out-of-memory error.

So I decided to avoid mocking it. Calling `Cookie.get` would return either a string or undefined (if not found). So I adjusted our mocks to allow for undefined value as well.

* Fix header tests

My Account icon actually gets rendered with 'My account' label (note that it's a small-case "a").

* Revert "Bring back the data-cloud tests"

This reverts commit 16978e1.

* Mock js-cookie in a different way

Such that we won't run into the out-of-memory error.

* Route serialization to support Shopper SEO URL mapping integration (#2300)

* update Switch component to load routes from RoutesProvider and RoutesContext
* Server: update react-rendering.js to serialize extensions that have getRoutesAsync implemented and save it under window.__EXTENSIONS__ global variable
* update ApplicationExtension to cache results from getRoutesAsync to _cachedRoutes property
* update ApplicationExtension to deserialize routes from window.__EXTENSIONS__ when on the client and save it under _cachedRoutes

* [App Extensibility] Bring back recently-commented-out Github actions (@W-18219092@) (#2351)

* Actions: bundle size and npm scripts

* Tweak condition

* Lighthouse test

* Fix test workflow

* Try different way to set env variable

* Aargh, forgot to close the quote

* Comment out lighthouse test for now

* Move to separate job those that don't test code correctness

* Refactor the MRT's node version

* Try fixing error

* Try fixing error

* Experiment with `bundlesize`

* Check bundle sizes

* Simplify code with github.action_path

* Debugging

* Workaround for bug with bundlesize

bundlesize cannot handle absolute path to the config file. See siddharthkp/bundlesize#326

* Lighthouse test now accepts config filename to be more reusable

* Experiment with passing in json config

* Experiment with passing in json config

* For the other jobs, run the npm-scripts test

* Add comment to clarify

* Remove duplicate test

It's already run in the generated and generated-windows jobs.

* Revert "Remove duplicate test"

This reverts commit 74116b7.

* Smoke testing npm scripts now run in all nodes and OSes

* Delete no-longer-needed code

* Test running an invalid command

* Test running an invalid command

* Move more things to setup_ubuntu and setup_windows

* Move more things to setup_ubuntu and setup_windows

* Move more things to setup_ubuntu and setup_windows

* Debugging

* Debugging

* Debugging

* Debugging

* Debugging

* Debugging

* Debugging

* Debugging

* New step to verify Node and NPM versions

* Debugging windows

* Some refactoring

* Prints clearer message

* Clean up code

* A bit of reordering

* Add comments

* Add comments

* Add error handling for jq

* Extract the app generation into its own action

* Fix the error handling

* Fix action

* The timeout-minutes cannot be used inside an action

* Remove console log

* Sync with latest develop branch

* Initial implementation

* Update package lock files

* @W-13747172 Fix a11y (#2375)

* fix a11y

* @W-17830285@ Add custom parameters to SLAS authorize calls (#2358)

* Allow custom parameters to SLAS authorize calls

* Update CHANGELOG.md

* Move extractCustomParameters to utils

* Use options and body instead of parameters for consistency

* Ensure only custom parameters are set from register to login

* Don't send custom params to shopperCustomer register

* Allow custom params to be set via login.mutateAsync

* Update tests using ShopperCustomers

* Apply feedback

* Add comments

* Lint

* Pin to previous version of cc-datacloud-typescript

Their latest 1.1.0 release that's out today was causing an error with building our pwa-kit project.

* Revert "Pin to previous version of cc-datacloud-typescript"

This reverts commit e558f52.

* Make constants file, clean up, remove logs

* Update CHANGELOG.md

* Add tests for utilities.

* Committing temp version bump

* Revert "Committing temp version bump"

This reverts commit 398cfce.

* Fix failing tests

* Update package lock files

* Try replacing `sh.cat` with native file reading

See if such replacement works well on a Windows machine.

* Debug: see what gets generated

* Fix regression in getAsseturl

* Debugging

* Refactor file copying logic

* Clean up

* Revert "Try replacing `sh.cat` with native file reading"

This reverts commit dc26b6e.

* Remove debug code

* Add changelog for the chakra-storefront

* Update CHANGELOG.md

* [App Extensibility ⚙️] Remove `extension-` prefix requirement (@W-18131976@) (#2390)

* Remove extension prefix

* Clean changes in template-typescript-minimal

* Optimize detecting extensions logic

* WIP Fix tests

* Fix tests

* Fix tests

* Move import constant

* Refactor packagePath ternary

* Condensed fullPackagePath into one line

* Update package namespace and name extract logic

* Use validate-npm-package-name in generator

* lint

* Adjust generator copy

* Update packages/pwa-kit-create-app/scripts/create-mobify-app.js

Co-authored-by: Kevin He <kevin.he@salesforce.com>
Signed-off-by: Adam Raya <adamraya@users.noreply.github.com>

* PR Feedback detectExtensions args

---------

Signed-off-by: Adam Raya <adamraya@users.noreply.github.com>
Co-authored-by: Kevin He <kevin.he@salesforce.com>

* Update packages/pwa-kit-react-sdk/src/ssr/universal/utils.ts

Co-authored-by: Adam Raya <adamraya@users.noreply.github.com>
Signed-off-by: Ben Chypak <bchypak@mobify.com>

* PR feedback round 1

* Remove test configuration

* Remove sample override for testing

* Fix lint error

* Revert override

* Regenerate lock files

---------

Signed-off-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
Signed-off-by: Kevin He <kevin.he@salesforce.com>
Signed-off-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
Signed-off-by: Adam Raya <adamraya@users.noreply.github.com>
Signed-off-by: Ben Chypak <bchypak@mobify.com>
Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
Co-authored-by: Ben Chypak <bchypak@salesforce.com>
Co-authored-by: Ben Chypak <bchypak@mobify.com>
Co-authored-by: mitesh-patel-crm <85328777+mitesh-patel-crm@users.noreply.github.com>
Co-authored-by: Kevin He <kevin.he@salesforce.com>
Co-authored-by: mitesh.patel <mitesh.patel@salesforce.com>
Co-authored-by: Carson Campbell <170666418+carson-campbell@users.noreply.github.com>
Co-authored-by: Alex Vuong <alex.vuong@salesforce.com>
Co-authored-by: Jainam Sheth <j.sheth@salesforce.com>

* [App Extensibility ⚙️] Update create_mrt GitHub Action for -extensibility-preview.04 release (@W-17910075@)(#2403)

* Bump versions to `-extensibility-preview.5`

* Update Changelogs

* Use caret on peerDependencies

---------

Signed-off-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
Signed-off-by: Kevin He <kevin.he@salesforce.com>
Signed-off-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
Signed-off-by: Adam Raya <adamraya@users.noreply.github.com>
Signed-off-by: Ben Chypak <bchypak@mobify.com>
Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
Co-authored-by: Ben Chypak <bchypak@salesforce.com>
Co-authored-by: Ben Chypak <bchypak@mobify.com>
Co-authored-by: mitesh-patel-crm <85328777+mitesh-patel-crm@users.noreply.github.com>
Co-authored-by: Kevin He <kevin.he@salesforce.com>
Co-authored-by: mitesh.patel <mitesh.patel@salesforce.com>
Co-authored-by: Carson Campbell <170666418+carson-campbell@users.noreply.github.com>
Co-authored-by: Alex Vuong <alex.vuong@salesforce.com>
Co-authored-by: Jainam Sheth <j.sheth@salesforce.com>
alexvuong added a commit that referenced this pull request Jul 16, 2025
@adamraya @vcua-mobify
@vmarta @hajinsuha1 @yunakim714 @bendvc @mitesh-patel-crm @kevinxh @carson-campbell @alexvuong @shethj
[App Extensibility ⚙️] Bump preview version to `-extensibility-previe…
ccd7311 
…w.5` (#2404)

* [App Extensibility ⚙️] Deploy `-extensibility-preview.04` (@W-17910075@)  (#2402)

* @W-17589798@ Bump develop to v3.10.0-dev (#2278)

* Update changelog files

* Bump to the preview versions

* Bump up preview versions

* @W-17589798@ Release preview version 3.9.0-preview.2 (#2264)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* @W-17589798@ Release preview version 3.9.0-preview.3 (#2268)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* @W-17589798@ Release preview version 3.9.0-preview.4 (#2272)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

* Fix import error template retail react app (#2270)

* revert babel.config.js workaround

* move everything out of utils into ssr.js or default.js

* update default.js templates

* update ssr.js templates

* rerun ci jobs

* rerun ci jobs

* Bump versions

---------

Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Update CHANGELOG.md

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* @W-17589798@ Release preview version 3.9.0-preview.5 (#2274)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

* Fix import error template retail react app (#2270)

* revert babel.config.js workaround

* move everything out of utils into ssr.js or default.js

* update default.js templates

* update ssr.js templates

* rerun ci jobs

* rerun ci jobs

* Bump versions

---------

Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Update CHANGELOG.md

* Add missing `_app-config` template changes (#2273)

* @W-17589798@ Release preview version 3.9.0-preview.4 (#2272)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

* Fix import error template retail react app (#2270)

* revert babel.config.js workaround

* move everything out of utils into ssr.js or default.js

* update default.js templates

* update ssr.js templates

* rerun ci jobs

* rerun ci jobs

* Bump versions

---------

Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Update CHANGELOG.md

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* add missing app config template changes

* update both app config templates

---------

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Bump version to 3.9.0-preview.5

* Update CHANGELOG.md

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>
Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>

* @W-17589798@ PWA Kit v3.9.0, commerce-sdk-react 3.2.0, retail-react-app 6.0.0 Release (#2277)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

* Fix import error template retail react app (#2270)

* revert babel.config.js workaround

* move everything out of utils into ssr.js or default.js

* update default.js templates

* update ssr.js templates

* rerun ci jobs

* rerun ci jobs

* Bump versions

---------

Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Update CHANGELOG.md

* Add missing `_app-config` template changes (#2273)

* @W-17589798@ Release preview version 3.9.0-preview.4 (#2272)

* Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263)

* update bootstrap default.js.hbs to include login options
* update ssr.js templates

* Revert/page meta data tags 3.9.x (#2259)

* Revert page-meta-data changes

* Update CHANGELOG.md

* Fix changelog

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>

* Bump to version 3.9.0-preview.2

* Fix lint errors in default.js templates (#2265)

* fix lint errors

* rerun ci jobs

* Update app config templates (#2267)

* lint default.js in templates folder (#2266)

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Bump to version 3.9.0-preview.3

* Update CHANGELOG.md

* Fix import error template retail react app (#2270)

* revert babel.config.js workaround

* move everything out of utils into ssr.js or default.js

* update default.js templates

* update ssr.js templates

* rerun ci jobs

* rerun ci jobs

* Bump versions

---------

Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Update CHANGELOG.md

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* add missing app config template changes

* update both app config templates

---------

Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>

* Bump version to 3.9.0-preview.5

* Update CHANGELOG.md

* Bump versions

* Update changelogs

* Update CHANGELOG.md

* Update peer dep in package-lock

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>
Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>

* Bump version to 3.10.0-dev

---------

Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com>
Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>

* Undo change

not sure whats going on this this new line issue.

* Clean up storefront extension dependencies

* Added missing commerce-react dep

* Re-order package.json

* More dependency cleanup

* Revert changes to storefront package.json

* More dep clean up

* Remove some unused deps

* Re lock projects

* @W-17643479@ Add page meta data to search results and product pages (#2282)

* Add page meta data to search results and product pages

* Changelog

* Apply suggestions

---------

Signed-off-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Don't use dependencies in extensions

* [App Extensibility ⚙️] Fix Issues with Pushing Bundles to MRT (@W-17779391@) (#2281)

* Remove core-polyfill

* Fix commerce-sdk-react peerDependency version

* Update package-lock.json

* Update bump-version script

* PR Feedback

* Add more docs

* Revert "Add more docs"

This reverts commit 59715d2.

* Revert "PR Feedback"

This reverts commit 42b10d6.

* Revert "Update bump-version script"

This reverts commit 7387793.

* Move deps to peer deps

* Fix merge conflicts and re-lock packages

* Forgot to commit lock files

* @W-17286066 Remove forced garbage collection per invocation (#2285)

* Remove forced garbage collection on each invocation.
* Allow FORCE_GC env-var to enable old behavior.
* Added /memtest endpoint to mrt reference app.
* updated CHANGELOG.md with link to PR.

* Update TUTORIAL.md

Signed-off-by: Kevin He <kevin.he@salesforce.com>

* Fix tests

Recent changes to "@testing-library/user-event" broke our tests.

* Make same change for template

* Enable Social & Passwordless Login in Demo Storefront (#2284)

* Increas max size for vendor

* Use `^` in starter extension

* [App Extensibility ⚙️] Fix Slow Dev Server start on Windows (@W-17792667@) (#2289)

* Use thread-loader

* Replace event-emitter with EventTarget

* Clean up

* Fix test

* Add evt.detail to tests

* Update thread-loader config

* Remove extensions from typescript-minimal & Update changelogs

* Solve merge conflicts

* Increase build/main.js maxSize

* Revert social and passwordless login in develop (#2292)

* use . for server timing delimiter

* add changelog

* update react query performance delimiter

* update getProps performance header delimiter

* Update TUTORIAL.md

Signed-off-by: Kevin He <kevin.he@salesforce.com>

* @W-17760517@ Automatically update bug bounty instance on new release (#2291)

* Add new preset

* New workflow for bug bounty deploy

* Fix indent

* Add runs-on

* Install deps

* temp remove step conditions

* set credentials file to default

* Test version check

* Trigger on Github release

* Test

* Test2

* test 3

* test 4

* test5

* test6

* test7

* test8

* test9

* test10

* test11

* test12

* test13

* test 14

* test 15

* test16

* test17

* test18

* test19

* test20

* test21

* test22

* test23

* test24

* test25

* test26

* Restore actual changes

* Test by reversing condition

* Revert conditional to what we want

* apply suggestions + refactor

* flip condition for testing

* Fix file structure

* Add checkout

* Specify shell

* Set token as input

* Checkout before node setup

* Use correct condition

* Allow custom bundle message on deploy

* Add quotes

* Set tag name

* Remove bracket

* Update condition

* [App Extensibility ⚙️] Polish Project Generator (@W-17910008@) (#2293)

* Remove Do you want to use Extensibility question & Fix outputDir

* Remove debug logs

* Remove Choose a project preset to get started question

* Clean up extensionName redundancy

* Update TUTORIAL.md

* lint

* Bump core to 3.9.1 and point versions for independent packages

* Cherry pick PR2285

* Update readmes

* Update package-lock.json

* Bad merge

* Fix bad merge again

* Lint fix

* update cloudwatch sender maxRetries to 0

* add comment

* add changelog

* bump version to v3.9.2

* empty commit

* @W-17900760@ Deploy Demo Storefront with SLAS Private Client (#2297)

* WIP

* Use zzrf-001 stg

* Set output

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* Add logging

* fix conditional

* Add brackets

* fix

* fix

* adjust

* test

* test

* test

* flip condition for testing

* Update handlebars for RefArchGlobal locales

* Add US locale + currency to RefArchGlobal and set as default

* Add site alias

* Enable passwordless and social login

* Adjust comment since handlebars don't add a newline

* Apply aliases

* Adjust newline

* Comment

* Add siteid and locale to demo path

* Enable site setting

* Re-add handlebar helper

* showDefaults: true

* Use translatable title for demo store

* Fix lint

* Deploy to production demo site

* Re-enable bug bounty deploy

* Use Salesforce Cloud as default logo for extensible projects

* Change condition so we run a deploy

* Restore latest release condition

* Revert "Use Salesforce Cloud as default logo for extensible projects"

This reverts commit 6ec6c7b.

* Use a non-extensible template for demo site

* Deploy demo site

* Revert deployment condition

* Apply suggestions

* Fallback name if no release tag name

* test

* test

* New step for bundle name

* fix else

* Use new step with everything else

* redeploy demo site

* Fix conditions after release

* Test matrix

* Handle secrets outside of matrix

* test

* Fix api key name

* Set flags and don't fail-fast

* Reapply on release condition

* fix server timing header delimiter

* skip changelog

* add tests

* remove comment

* lint

* resolve conflict

* @W-17405592 - DataCloud Events in PWA (#2229) (#2318)

Send analytics events from the PWA Kit to Data Cloud

---------

Signed-off-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
Co-authored-by: Carson Campbell <170666418+carson-campbell@users.noreply.github.com>

* [App Extensibility ⚙️] Add script to display all files in an extension that can be overridden (@W-17555422@) (#2299)

* Init list-overridables script

* Support loadable overridables import

* Look for overridable imports in the configured extensions

* Split command into two

* Reuse helpers getConfiguredExtensions

* lint

* Fix tests

* Clean up

* Fix check-overrides using findOverrideFiles

* Fix duplicate imports

* Reuse resolver getPackageName

* clean up

* lint

* Fix tests

* Update hasCorrespondingOverridableImport path matching

* Include the file list that match overridable imports

* Simplify hasCorrespondingOverridableImport

* lint

* Extract utils from webpack overrride-resolver loader

* Add js docs

* Add tests

* Fix Windows tests

* Use path.sep to normalize paths

* Clean up use webpack plugin alternative approach

* OverrideStatsPlugin Webpack plugin

* Fix list-overrides on Windows

* Update pwa-kit-extension-sdk lock files

* Add sourceExtension to override stats

* PR Feedback

* Add OverrideStatsPlugin tests

* Add types to OverrideStatsPlugin tests

* Add more types

* PR Feedback

* Update test to use virtual filesystem

* lint

* Add docs

* Add more tests to overrides-resolver-loader

* PR Feedback docs

* Bypass test on Windows

* Update lock files

* Lint Fixes

* Fix chakra imports

* Lint

* Use Act in test, and port network mocks

* Add global mock for cc-datacloud-typescript lib

Because this was a module we couldn't use jest without having to either use an experimental flag on jest.

* Bump bundle max sizes

* Enable ssh to test workflow failures

* Undo e2e

* Add action to display content of .bin for debugging

* Fix workflow

* Update test.yml

* Relock packages in an attempt to fix ci errors

* Remove debugging

* more debugging

* Update test.yml

* Add debugging logs

* more debugging

* more debugging

* more logging

* Fix for node 22

Node 22 doesn't like using npm pack without a version, might be a bug with verdaccio

* Remove debug logs and add latest when using npm pack

* Remove more debug logs

* Move move storefront to storefront-old

* Move retail template to extension folder

* '/app' becomes '/src'

* Move the README

* Copy setup files

* Fix location of setup files

* These files aren't required in an extension

* Remove old config and replace with new config

* Move types

* Move meta data file

* Migrate router to extension with changes.

* Update jest-setup

* Migrate jest.config.

* Migrate package.json

* Remove special components and add their replacements

* Migrate changes to useAddressFields component

* Migrate changes for header component

* Migrate associated tests

* Migrate tests for link component

* Migrate changes for product-tile component

* Migrate search component

* Migrate search partial component

* Migrate seo component

* Migrate constants file

* Migrate hooks index

* Migrate use-active-data hook and tests

* Migrate various hook changes and test fixes

* Migrate mock data

Note: Unsure about whether mockedRegisteredCustomerWithNoNumber should have been re-added

* Migrate account pages.

* Migrade checkout page changes

* Migrate checkout partial changes

* Migrate product-list components

* Migrate theme colors

* Migrate utils

* migrate project files/configs

* Remove unused files in extension projects

* Move static folder

* Update eslint ignore

* Remove some more unused scripts/folders

* Fix lint warnings

* Fix import paths for hooks

* Migrate theme index

* Replace `@salesforce/template-retail-react-app` imports with relative ones

* Linting

* Migrate page-designer assets

* Migrate page-designer layouts

* Migrate page-designer misc

* Migrate utils

* Migrate theme base and project folders

* Migrate theme foundations

* Update imports for account pages

* Update cart page imports

* Migrate home page

* Migrate login page

* Migrate login-redirect page

* Migrate page-not-found page

* Migrate the product-details page

* Migrate product-list page

* Migrate registration page

* Migrate reset password

* Migrate checkout page

* Migrate cart pages

* Migrate account pages

* Lint

* Chane aliased imports to relative imports for new code

* Remove `template-retail-react-app` from generator

* Migrate mocks folder

* Migrate search component partials folder

* Migrate svg assets

* Migrate contexts file

* Delete chakra storefront old project

* Re-generate lock files across mono repo

* Add data cloud types and update code to work with as an extension

* Fix login page

* Lint

* W-17908517 - Fix basket loading after logging out (#2323)

* fix basket loading after logging out

* Fix some tests, rework others

Re-worked the data cloud tests, still a work in progress.

* Fix some failing tests

Skip header tests
Skip datacloud tests

* Remove references to old template

Remove ci bundle analyzer action

* Remove smoke and lighthouse tests for defunct retail template

* Remove other instance of smoke test script runner

* Update test.yml

* Remove code that was added back via a merge

* Remove code that was added as a result of a bad merge

* Update peer deps for storefront extension

* Remove mobify object from extensions package.json files (#2336)

* [App Extensibility] replace `extendRoutes` with `getRoutes` and `getRoutesAsync` @W-17916765@ (#2308)

* Convert extendRoutes to an async method

* Add todos

* Temporarily modify the typescript-minimal project

* Minor refactoring

* Call every extension's route function in parallel

For a simpler implementation, replaced extendRoutes with getRoutes. Probably safer too, since we think there's no need to have access to the existing/previous routes.

* Pass in the request path

* Explore passing in locals and how to manage access token

* Remove extendRoutes from the API

* Allow configuring of the auth property name in locals

* Rename the property in locals

* Create a new extension for a better example

* Add some console logs

* Experiment with having partial route

Partial route in the getRoutes, and then completing it during beforeRouteMatch.

* Experiment with correct way to get app origin

* Add todo

* Some cleanup

* Fix the partial route with correct path

* Remove no longer necessary code

* Combine params into a single object

* Remove some console logs

* Add comment to clarify

* Implement getRoutes and getRoutesAsync

Co-Authored-By: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-Authored-By: Ben Chypak <bchypak@salesforce.com>

* Add comment

* Add comment

* Add type to allow for `componentName` property

* Remove params for `getRoutes`

Only `getRoutesAsync` who needs the params.

* Remove params for getRoutes

* Revert "Remove params for `getRoutes`"

This reverts commit 38e352f.

* Revert "Remove params for getRoutes"

This reverts commit 4119cda.

* Update comments

* Update tests

* Update tests

* Revert changes to typescript-minimal

* Update package-lock.json

* Update changelog files

* Update readme files

* Add jsdoc to some types

* Rename test to make it clearer

* Empty commit

---------

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Ben Chypak <bchypak@salesforce.com>

* Initial refactor of ssr into setup-server

* Refactor some of the utils and create middleware

* Remove wishlist from configurate list of pages for now

* Fix some lint errors

* [App Extensibility ⚙️] Pin Specific Versions for Extensions in Generated Project (@W-17779226@) (#2339)

* Use npm view to get the latest version

* Update available-app-extensions.json

* lint

* Prepend caret (^) to the version number

* [Snyk] Dependency updates (#2338)

* Update nanoid dependency

* Override path-to-regexp version

* Update CHANGELOG.md

* Apply snyk version bumps

* Update changelogs

* Update CHANGELOG.md

* Update changelogs

* Fix jwks path and replace constants with configurable values

* Empty commit

* Fix regression and fix some tests config

* Fix mock config

* Don't send undefined redirect urls

* Use extension config not app config in checkout

* Fix idps destructure

* Fix test and pr feedback

* Initial commit

* Remove debugging logs

* Removed unused error handler middleware

* Adding flex value as this component is used in display flex

* Better fix, still not great

* Fix issue with null pointer

* Lint

* Update with-layout.tsx

* Lint

* [App Extensibility] make sure DNT feature still works as expected (@W-18128633@) (#2345)

* Show DNT banner

* Make default DNT state configurable

* Add `build:watch` script, like what other packages have (#2346)

* [App Extensibility] Bring back and fix the recently-skipped tests (@W-18120857@) (#2349)

* Bring back the data-cloud tests

For some reason, jest cannot mock js-cookie. It crashed with out-of-memory error.

So I decided to avoid mocking it. Calling `Cookie.get` would return either a string or undefined (if not found). So I adjusted our mocks to allow for undefined value as well.

* Fix header tests

My Account icon actually gets rendered with 'My account' label (note that it's a small-case "a").

* Revert "Bring back the data-cloud tests"

This reverts commit 16978e1.

* Mock js-cookie in a different way

Such that we won't run into the out-of-memory error.

* Route serialization to support Shopper SEO URL mapping integration (#2300)

* update Switch component to load routes from RoutesProvider and RoutesContext
* Server: update react-rendering.js to serialize extensions that have getRoutesAsync implemented and save it under window.__EXTENSIONS__ global variable
* update ApplicationExtension to cache results from getRoutesAsync to _cachedRoutes property
* update ApplicationExtension to deserialize routes from window.__EXTENSIONS__ when on the client and save it under _cachedRoutes

* [App Extensibility] Bring back recently-commented-out Github actions (@W-18219092@) (#2351)

* Actions: bundle size and npm scripts

* Tweak condition

* Lighthouse test

* Fix test workflow

* Try different way to set env variable

* Aargh, forgot to close the quote

* Comment out lighthouse test for now

* Move to separate job those that don't test code correctness

* Refactor the MRT's node version

* Try fixing error

* Try fixing error

* Experiment with `bundlesize`

* Check bundle sizes

* Simplify code with github.action_path

* Debugging

* Workaround for bug with bundlesize

bundlesize cannot handle absolute path to the config file. See siddharthkp/bundlesize#326

* Lighthouse test now accepts config filename to be more reusable

* Experiment with passing in json config

* Experiment with passing in json config

* For the other jobs, run the npm-scripts test

* Add comment to clarify

* Remove duplicate test

It's already run in the generated and generated-windows jobs.

* Revert "Remove duplicate test"

This reverts commit 74116b7.

* Smoke testing npm scripts now run in all nodes and OSes

* Delete no-longer-needed code

* Test running an invalid command

* Test running an invalid command

* Move more things to setup_ubuntu and setup_windows

* Move more things to setup_ubuntu and setup_windows

* Move more things to setup_ubuntu and setup_windows

* Debugging

* Debugging

* Debugging

* Debugging

* Debugging

* Debugging

* Debugging

* Debugging

* New step to verify Node and NPM versions

* Debugging windows

* Some refactoring

* Prints clearer message

* Clean up code

* A bit of reordering

* Add comments

* Add comments

* Add error handling for jq

* Extract the app generation into its own action

* Fix the error handling

* Fix action

* The timeout-minutes cannot be used inside an action

* Remove console log

* Sync with latest develop branch

* Initial implementation

* Update package lock files

* @W-13747172 Fix a11y (#2375)

* fix a11y

* @W-17830285@ Add custom parameters to SLAS authorize calls (#2358)

* Allow custom parameters to SLAS authorize calls

* Update CHANGELOG.md

* Move extractCustomParameters to utils

* Use options and body instead of parameters for consistency

* Ensure only custom parameters are set from register to login

* Don't send custom params to shopperCustomer register

* Allow custom params to be set via login.mutateAsync

* Update tests using ShopperCustomers

* Apply feedback

* Add comments

* Lint

* Pin to previous version of cc-datacloud-typescript

Their latest 1.1.0 release that's out today was causing an error with building our pwa-kit project.

* Revert "Pin to previous version of cc-datacloud-typescript"

This reverts commit e558f52.

* Make constants file, clean up, remove logs

* Update CHANGELOG.md

* Add tests for utilities.

* Committing temp version bump

* Revert "Committing temp version bump"

This reverts commit 398cfce.

* Fix failing tests

* Update package lock files

* Try replacing `sh.cat` with native file reading

See if such replacement works well on a Windows machine.

* Debug: see what gets generated

* Fix regression in getAsseturl

* Debugging

* Refactor file copying logic

* Clean up

* Revert "Try replacing `sh.cat` with native file reading"

This reverts commit dc26b6e.

* Remove debug code

* Add changelog for the chakra-storefront

* Update CHANGELOG.md

* [App Extensibility ⚙️] Remove `extension-` prefix requirement (@W-18131976@) (#2390)

* Remove extension prefix

* Clean changes in template-typescript-minimal

* Optimize detecting extensions logic

* WIP Fix tests

* Fix tests

* Fix tests

* Move import constant

* Refactor packagePath ternary

* Condensed fullPackagePath into one line

* Update package namespace and name extract logic

* Use validate-npm-package-name in generator

* lint

* Adjust generator copy

* Update packages/pwa-kit-create-app/scripts/create-mobify-app.js

Co-authored-by: Kevin He <kevin.he@salesforce.com>
Signed-off-by: Adam Raya <adamraya@users.noreply.github.com>

* PR Feedback detectExtensions args

---------

Signed-off-by: Adam Raya <adamraya@users.noreply.github.com>
Co-authored-by: Kevin He <kevin.he@salesforce.com>

* Update packages/pwa-kit-react-sdk/src/ssr/universal/utils.ts

Co-authored-by: Adam Raya <adamraya@users.noreply.github.com>
Signed-off-by: Ben Chypak <bchypak@mobify.com>

* PR feedback round 1

* Remove test configuration

* Remove sample override for testing

* Fix lint error

* Revert override

* Regenerate lock files

---------

Signed-off-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
Signed-off-by: Kevin He <kevin.he@salesforce.com>
Signed-off-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
Signed-off-by: Adam Raya <adamraya@users.noreply.github.com>
Signed-off-by: Ben Chypak <bchypak@mobify.com>
Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
Co-authored-by: Ben Chypak <bchypak@salesforce.com>
Co-authored-by: Ben Chypak <bchypak@mobify.com>
Co-authored-by: mitesh-patel-crm <85328777+mitesh-patel-crm@users.noreply.github.com>
Co-authored-by: Kevin He <kevin.he@salesforce.com>
Co-authored-by: mitesh.patel <mitesh.patel@salesforce.com>
Co-authored-by: Carson Campbell <170666418+carson-campbell@users.noreply.github.com>
Co-authored-by: Alex Vuong <alex.vuong@salesforce.com>
Co-authored-by: Jainam Sheth <j.sheth@salesforce.com>

* [App Extensibility ⚙️] Update create_mrt GitHub Action for -extensibility-preview.04 release (@W-17910075@)(#2403)

* Bump versions to `-extensibility-preview.5`

* Update Changelogs

* Use caret on peerDependencies

---------

Signed-off-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
Signed-off-by: Kevin He <kevin.he@salesforce.com>
Signed-off-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
Signed-off-by: Adam Raya <adamraya@users.noreply.github.com>
Signed-off-by: Ben Chypak <bchypak@mobify.com>
Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
Co-authored-by: Vincent Marta <vmarta@salesforce.com>
Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
Co-authored-by: Ben Chypak <bchypak@salesforce.com>
Co-authored-by: Ben Chypak <bchypak@mobify.com>
Co-authored-by: mitesh-patel-crm <85328777+mitesh-patel-crm@users.noreply.github.com>
Co-authored-by: Kevin He <kevin.he@salesforce.com>
Co-authored-by: mitesh.patel <mitesh.patel@salesforce.com>
Co-authored-by: Carson Campbell <170666418+carson-campbell@users.noreply.github.com>
Co-authored-by: Alex Vuong <alex.vuong@salesforce.com>
Co-authored-by: Jainam Sheth <j.sheth@salesforce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamraya adamraya adamraya approved these changes

@shethj shethj shethj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmarta @adamraya @shethj