[App Extensibility] Sync with latest develop branch (@W-18121817@)#2377
Conversation
* fix basket loading after logging out
* Update nanoid dependency * Override path-to-regexp version * Update CHANGELOG.md * Apply snyk version bumps * Update changelogs * Update CHANGELOG.md * Update changelogs
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
* fix a11y
* Allow custom parameters to SLAS authorize calls * Update CHANGELOG.md * Move extractCustomParameters to utils * Use options and body instead of parameters for consistency * Ensure only custom parameters are set from register to login * Don't send custom params to shopperCustomer register * Allow custom params to be set via login.mutateAsync * Update tests using ShopperCustomers * Apply feedback * Add comments * Lint
Their latest 1.1.0 release that's out today was causing an error with building our pwa-kit project.
This reverts commit e558f52.
vcua-mobify
left a comment
vcua-mobify
left a comment
There was a problem hiding this comment.
+1 as the builds are now passing.
Also, there's a new PR from last week that we might want to add either as part of this or in a follow up: 76fc5b0
This reverts commit 398cfce.
See if such replacement works well on a Windows machine.
vmarta
force-pushed
the
vm/sync-extensibility-with-latest-develop
branch
from
c3b630a to
dc26b6e
Compare
vmarta
force-pushed
the
vm/sync-extensibility-with-latest-develop
branch
from
52894c8 to
91f5c62
Compare
| sh.cp('-rf', p.join(appExtensionTmpPath, '.*'), appExtensionDestDir) | ||
| // Copy regular files | ||
| sh.cp('-rf', p.join(appExtensionTmpPath, '*'), appExtensionDestDir) | ||
| copyAllFiles(appExtensionTmpPath, appExtensionDestDir) |
There was a problem hiding this comment.
The changes in this file are new.. they're not from the develop branch. They fix the failing project generation on windows machine.
Otherwise, you would see an error like this:
There was a problem hiding this comment.
Should we add this change and the ones you've noted below back to the develop branch afterward?
There was a problem hiding this comment.
@vcua-mobify Good question. Fortunately we don't need to bring those changes back to develop. They're only needed for the extensibility branch as the issue is newly introduced there.
|
|
||
| // Copy the base template either from the package or npm. | ||
| sh.cp('-rf', p.join(packagePath, '{*,.*}'), outputDir) | ||
| copyAllFiles(packagePath, outputDir) |
There was a problem hiding this comment.
A similar problem here on Windows machine. The error looks like this:
| * @param {*} answers | ||
| * @param {*} param2 | ||
| */ | ||
| const runGenerator = async ( |
There was a problem hiding this comment.
No need to have async here actually.
In fact, it was causing a weird issue where an error was not surfaced. An error inside the runGenerator function was strangely not caught at the end (see line 1314).
So it looked as if everything was fine, and a successful message was printed out. This is probably why the failing project generation on Windows machine was not noticed until now.
5 participants
Merging in the latest changes from
developbranch. Just a few commits: