Skip to content

Send Cart URL to MIAW#2388

Merged
khan-salesforce merged 1 commit intofeature-shopper-agent-exp-v3.0from
addCartURL
May 2, 2025
Merged

Send Cart URL to MIAW#2388
khan-salesforce merged 1 commit intofeature-shopper-agent-exp-v3.0from
addCartURL

Conversation

@khan-salesforce
Copy link

@khan-salesforce khan-salesforce commented Apr 30, 2025

Send Cart URL to MIAW

Description

Allows a Cart URL defined in environment variables to be sent to MIAW

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@khan-salesforce khan-salesforce requested a review from a team as a code owner April 30, 2025 21:30
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Apr 30, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@khan-salesforce khan-salesforce added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Apr 30, 2025
Copy link

@avinashkasipathy avinashkasipathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking for my understanding - why do we need this URL string passed through MIAW ?

@khan-salesforce
Copy link
Author

Asking for my understanding - why do we need this URL string passed through MIAW ?

It's for the Cart team to build a cart link from. Because the cart link doesn't have to follow any specific convention, and there doesn't seem to be an ECOM API they can call to get the base cart link, they need the site owners to provide it.

commerceOrgId: 'f_ecom_zzeu_052',
siteId: 'RefArchGlobal'
siteId: 'RefArchGlobal',
cartUrl: 'https://agentgatos-production.mobify-storefront.com/cart'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it work with site/locale config here? If the customer sets up the storefront to have site/locale as path, the cart page would become /siteId/en-GB/cart.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I've talked to Mukul about this, for now we might have to reconstruct the cart link via agentforce incorporating the locale? But users could also choose to have a completely separate convention.

Do you now if there is an ECOM API where we can get a cart link? We couldn't find one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, no. pwa-kit constructs url based on the config.app.url within the code base and not based on any ECOM API atm. To see how we construct url. See here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI spun up another work item to sync up with Mukul and Thomas Loche around this. For now, I'm merging to our branch to unblock the Cart teams for integration purposes.

@khan-salesforce khan-salesforce merged commit a111942 into feature-shopper-agent-exp-v3.0 May 2, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants