Closed
Conversation
* Skip the CHANGELOG check github action when not on `develop` branch @W-17704536@ * meaningless whitespace commit to trigger github actions CI * Add auto-pass CI check behavior to satisfy other jobs with `depends-on: changelog-check` * ensure changelog-check always runs * add a whitespace change to the allow-listed PUBLIC_PACKAGES to validate PR check functionality https://github.com/SalesforceCommerceCloud/pwa-kit/blob/develop/.github/actions/changelog-check/action.yml#L58 * roll back demonstrative change
* allow source map for both client and server on MRT using variable env
* Fix hreflang links
* Update changelog files * Bump to the preview versions * Bump up preview versions * @W-17589798@ Release preview version 3.9.0-preview.2 (#2264) * Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263) * update bootstrap default.js.hbs to include login options * update ssr.js templates * Revert/page meta data tags 3.9.x (#2259) * Revert page-meta-data changes * Update CHANGELOG.md * Fix changelog --------- Co-authored-by: Vincent Marta <vmarta@salesforce.com> * Bump to version 3.9.0-preview.2 * Fix lint errors in default.js templates (#2265) * fix lint errors * rerun ci jobs --------- Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> * @W-17589798@ Release preview version 3.9.0-preview.3 (#2268) * Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263) * update bootstrap default.js.hbs to include login options * update ssr.js templates * Revert/page meta data tags 3.9.x (#2259) * Revert page-meta-data changes * Update CHANGELOG.md * Fix changelog --------- Co-authored-by: Vincent Marta <vmarta@salesforce.com> * Bump to version 3.9.0-preview.2 * Fix lint errors in default.js templates (#2265) * fix lint errors * rerun ci jobs * Update app config templates (#2267) * lint default.js in templates folder (#2266) Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> * Bump to version 3.9.0-preview.3 * Update CHANGELOG.md --------- Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> * @W-17589798@ Release preview version 3.9.0-preview.4 (#2272) * Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263) * update bootstrap default.js.hbs to include login options * update ssr.js templates * Revert/page meta data tags 3.9.x (#2259) * Revert page-meta-data changes * Update CHANGELOG.md * Fix changelog --------- Co-authored-by: Vincent Marta <vmarta@salesforce.com> * Bump to version 3.9.0-preview.2 * Fix lint errors in default.js templates (#2265) * fix lint errors * rerun ci jobs * Update app config templates (#2267) * lint default.js in templates folder (#2266) Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> * Bump to version 3.9.0-preview.3 * Update CHANGELOG.md * Fix import error template retail react app (#2270) * revert babel.config.js workaround * move everything out of utils into ssr.js or default.js * update default.js templates * update ssr.js templates * rerun ci jobs * rerun ci jobs * Bump versions --------- Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> * Update CHANGELOG.md --------- Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> * @W-17589798@ Release preview version 3.9.0-preview.5 (#2274) * Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263) * update bootstrap default.js.hbs to include login options * update ssr.js templates * Revert/page meta data tags 3.9.x (#2259) * Revert page-meta-data changes * Update CHANGELOG.md * Fix changelog --------- Co-authored-by: Vincent Marta <vmarta@salesforce.com> * Bump to version 3.9.0-preview.2 * Fix lint errors in default.js templates (#2265) * fix lint errors * rerun ci jobs * Update app config templates (#2267) * lint default.js in templates folder (#2266) Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> * Bump to version 3.9.0-preview.3 * Update CHANGELOG.md * Fix import error template retail react app (#2270) * revert babel.config.js workaround * move everything out of utils into ssr.js or default.js * update default.js templates * update ssr.js templates * rerun ci jobs * rerun ci jobs * Bump versions --------- Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> * Update CHANGELOG.md * Add missing `_app-config` template changes (#2273) * @W-17589798@ Release preview version 3.9.0-preview.4 (#2272) * Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263) * update bootstrap default.js.hbs to include login options * update ssr.js templates * Revert/page meta data tags 3.9.x (#2259) * Revert page-meta-data changes * Update CHANGELOG.md * Fix changelog --------- Co-authored-by: Vincent Marta <vmarta@salesforce.com> * Bump to version 3.9.0-preview.2 * Fix lint errors in default.js templates (#2265) * fix lint errors * rerun ci jobs * Update app config templates (#2267) * lint default.js in templates folder (#2266) Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> * Bump to version 3.9.0-preview.3 * Update CHANGELOG.md * Fix import error template retail react app (#2270) * revert babel.config.js workaround * move everything out of utils into ssr.js or default.js * update default.js templates * update ssr.js templates * rerun ci jobs * rerun ci jobs * Bump versions --------- Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> * Update CHANGELOG.md --------- Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> * add missing app config template changes * update both app config templates --------- Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> * Bump version to 3.9.0-preview.5 * Update CHANGELOG.md --------- Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> * @W-17589798@ PWA Kit v3.9.0, commerce-sdk-react 3.2.0, retail-react-app 6.0.0 Release (#2277) * Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263) * update bootstrap default.js.hbs to include login options * update ssr.js templates * Revert/page meta data tags 3.9.x (#2259) * Revert page-meta-data changes * Update CHANGELOG.md * Fix changelog --------- Co-authored-by: Vincent Marta <vmarta@salesforce.com> * Bump to version 3.9.0-preview.2 * Fix lint errors in default.js templates (#2265) * fix lint errors * rerun ci jobs * Update app config templates (#2267) * lint default.js in templates folder (#2266) Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> * Bump to version 3.9.0-preview.3 * Update CHANGELOG.md * Fix import error template retail react app (#2270) * revert babel.config.js workaround * move everything out of utils into ssr.js or default.js * update default.js templates * update ssr.js templates * rerun ci jobs * rerun ci jobs * Bump versions --------- Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> * Update CHANGELOG.md * Add missing `_app-config` template changes (#2273) * @W-17589798@ Release preview version 3.9.0-preview.4 (#2272) * Update default.js.hbs and ssr.js.hbs templates to support new login flows (#2263) * update bootstrap default.js.hbs to include login options * update ssr.js templates * Revert/page meta data tags 3.9.x (#2259) * Revert page-meta-data changes * Update CHANGELOG.md * Fix changelog --------- Co-authored-by: Vincent Marta <vmarta@salesforce.com> * Bump to version 3.9.0-preview.2 * Fix lint errors in default.js templates (#2265) * fix lint errors * rerun ci jobs * Update app config templates (#2267) * lint default.js in templates folder (#2266) Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> * Bump to version 3.9.0-preview.3 * Update CHANGELOG.md * Fix import error template retail react app (#2270) * revert babel.config.js workaround * move everything out of utils into ssr.js or default.js * update default.js templates * update ssr.js templates * rerun ci jobs * rerun ci jobs * Bump versions --------- Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> * Update CHANGELOG.md --------- Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> * add missing app config template changes * update both app config templates --------- Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> * Bump version to 3.9.0-preview.5 * Update CHANGELOG.md * Bump versions * Update changelogs * Update CHANGELOG.md * Update peer dep in package-lock --------- Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> * Bump version to 3.10.0-dev --------- Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com> Co-authored-by: Adam Raya Navarro <arayanavarro@salesforce.com> Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
…2282) * Add page meta data to search results and product pages * Changelog * Apply suggestions --------- Signed-off-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
* Remove forced garbage collection on each invocation. * Allow FORCE_GC env-var to enable old behavior. * Added /memtest endpoint to mrt reference app. * updated CHANGELOG.md with link to PR.
…er-timing-delimiter @W-17907321 Fix server-timing header delimiter
…2291) * Add new preset * New workflow for bug bounty deploy * Fix indent * Add runs-on * Install deps * temp remove step conditions * set credentials file to default * Test version check * Trigger on Github release * Test * Test2 * test 3 * test 4 * test5 * test6 * test7 * test8 * test9 * test10 * test11 * test12 * test13 * test 14 * test 15 * test16 * test17 * test18 * test19 * test20 * test21 * test22 * test23 * test24 * test25 * test26 * Restore actual changes * Test by reversing condition * Revert conditional to what we want * apply suggestions + refactor * flip condition for testing * Fix file structure * Add checkout * Specify shell * Set token as input * Checkout before node setup * Use correct condition * Allow custom bundle message on deploy * Add quotes * Set tag name * Remove bracket * Update condition
…lease-3.9.1 Merge release 3.9.1 into develop
* WIP * Use zzrf-001 stg * Set output * test * test * test * test * test * test * test * test * test * test * test * test * Add logging * fix conditional * Add brackets * fix * fix * adjust * test * test * test * flip condition for testing * Update handlebars for RefArchGlobal locales * Add US locale + currency to RefArchGlobal and set as default * Add site alias * Enable passwordless and social login * Adjust comment since handlebars don't add a newline * Apply aliases * Adjust newline * Comment * Add siteid and locale to demo path * Enable site setting * Re-add handlebar helper * showDefaults: true * Use translatable title for demo store * Fix lint * Deploy to production demo site * Re-enable bug bounty deploy * Use Salesforce Cloud as default logo for extensible projects * Change condition so we run a deploy * Restore latest release condition * Revert "Use Salesforce Cloud as default logo for extensible projects" This reverts commit 6ec6c7b. * Use a non-extensible template for demo site * Deploy demo site * Revert deployment condition * Apply suggestions * Fallback name if no release tag name * test * test * New step for bundle name * fix else * Use new step with everything else * redeploy demo site * Fix conditions after release * Test matrix * Handle secrets outside of matrix * test * Fix api key name * Set flags and don't fail-fast * Reapply on release condition
…iming Fix server timing header delimiter
Merge 3.9.2 back to develop
* Minor typo fix * skip changelog
…562031/whitespace @W-18562031 first PR: whitespace update
…578168V3 @W-18578168 Unit test for checkout footer component
…into t/cc-sharks/W-18600278/productTest
…forceCommerceCloud/pwa-kit into t/cc-sharks/W-18600278/productTest
Release pwa kit v3.10.0 (@W-18465775@)
…orm/W-18541064/addUnitTest @W-18541064 - Add first Unit Test
…8600278/productTest Add product-view test for quantity buttons
…velop Sync with the latest release v3.10.0 (@W-18465775@)
* improve a11y to reduce flakiness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization