Skip to content

Fix a11y failing tets on PDP#2485

Merged
alexvuong merged 4 commits intodevelopfrom
alex/fix-a11y-e2e
May 27, 2025
Merged

Fix a11y failing tets on PDP#2485
alexvuong merged 4 commits intodevelopfrom
alex/fix-a11y-e2e

Conversation

@alexvuong
Copy link
Contributor

@alexvuong alexvuong commented May 26, 2025

Description

This PR adjusted a11y tests to improve flakiness. There are some new violations for color contrasts that consistent showed up. I've update snapshots to accept them for now since there is no concrete solution to resolve them. Some of the nodes reported of violations could be a false positive due to transition effect on the page.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@alexvuong alexvuong requested a review from a team as a code owner May 26, 2025 17:44
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented May 26, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@alexvuong alexvuong changed the title Checking pdp add to wish button before scanning a11y Fix a11y failing tets on PDP May 26, 2025
@alexvuong alexvuong merged commit ed90c37 into develop May 27, 2025
82 checks passed
@alexvuong alexvuong deleted the alex/fix-a11y-e2e branch July 16, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants