@W-18669904 - Added a test to PDP(product-view) page for checking translations#2528
Merged
snilakandan13 merged 15 commits intodevelopfrom Jun 10, 2025
Merged
Conversation
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
snilakandan13
added
the
skip changelog
…b.com/SalesforceCommerceCloud/pwa-kit into t/commerce/W-18669904/addingTestToPDP
aditek-sf
previously approved these changes
Jun 6, 2025
shauryemahajanSF
previously approved these changes
Jun 6, 2025
alexvuong
reviewed
Jun 6, 2025
packages/template-retail-react-app/app/pages/product-detail/index.test.js
Outdated
Show resolved
Hide resolved
snilakandan13
dismissed stale reviews from shauryemahajanSF and aditek-sf
via
6303c85
snilakandan13
changed the title
aditek-sf
previously approved these changes
Jun 9, 2025
shauryemahajanSF
previously approved these changes
Jun 9, 2025
alexvuong
reviewed
Jun 10, 2025
| // Wait for at least one product title to be rendered | ||
| const titles = await screen.findAllByText(/Black Single Pleat Athletic Fit Wool Suit/i) | ||
| expect(titles.length).toBeGreaterThan(0) | ||
| // Check Add to Cart button in French |
Contributor
There was a problem hiding this comment.
We don't need comment to explain the code, it is self-explanatory most of the cases. We'd want to use comment for the "why"
alexvuong
previously approved these changes
Jun 10, 2025
…b.com/SalesforceCommerceCloud/pwa-kit into t/commerce/W-18669904/addingTestToPDP
alexvuong
approved these changes
Jun 10, 2025
shauryemahajanSF
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@W-18669904
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization