Skip to content

@W-18670270 Update unit test#2538

Merged
yhsieh1 merged 3 commits intodevelopfrom
t/commerce/W-18670270/update-unit-test
Jun 9, 2025
Merged

@W-18670270 Update unit test#2538
yhsieh1 merged 3 commits intodevelopfrom
t/commerce/W-18670270/update-unit-test

Conversation

@yhsieh1
Copy link
Contributor

@yhsieh1 yhsieh1 commented Jun 9, 2025 •
edited
Loading

Description

Update unit test to increase coverage

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@yhsieh1 yhsieh1 requested a review from a team as a code owner June 9, 2025 17:09
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Jun 9, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

@yhsieh1 yhsieh1 added skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated and removed skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated labels Jun 9, 2025
kevinxh
kevinxh reviewed Jun 9, 2025
View reviewed changes
packages/template-retail-react-app/app/hooks/use-derived-product.test.js Outdated
Comment on lines +132 to +138
stockLevel: 10
}
}

renderWithProviders(<MockComponent product={mockBundleData} />)

expect(screen.getByText(/Quantity: 1/)).toBeInTheDocument()
Copy link
Contributor

@kevinxh kevinxh Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if the stockLevel should be related to the quantity in any way? stock level is 10 but quantity is 1.

Copy link
Contributor Author

@yhsieh1 yhsieh1 Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinxh Thanks for catching this. This is un-related and can be removed.

@yhsieh1 yhsieh1 merged commit 8c44ea7 into develop Jun 9, 2025
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinxh kevinxh kevinxh approved these changes

@patricksullivansf patricksullivansf patricksullivansf approved these changes

Assignees

No one assigned

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yhsieh1 @cc-prodsec @kevinxh @patricksullivansf