Skip to content

Update Feature Branch with Develop branch#2559

Closed
ddiazccrz wants to merge 89 commits intofeature/bonus-productsfrom
develop
Closed

Update Feature Branch with Develop branch#2559
ddiazccrz wants to merge 89 commits intofeature/bonus-productsfrom
develop

Conversation

@ddiazccrz
Copy link
Contributor

Description

Updating the feature branch with the latest from develop

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

shethj and others added 30 commits May 30, 2025 11:33
kevinxh and others added 22 commits June 10, 2025 12:41
…698408

@W-18698408 : Removed unneeded hyphen as part of onboarding.
…669904/addingTestToPDP

@W-18669904 - Added a test to PDP(product-view) page for checking translations
Migrate store locator from feature branch to develop
* update existing translations with updated localization
…e-sdk-react-refactor-2

Make API clients injectable in commerce-sdk-react (CommerceApiProvider)
…597966/revertBonusLabelChange

@W-18597966 - Revert Bonus Label Change
@ddiazccrz ddiazccrz requested a review from a team as a code owner June 12, 2025 17:18
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Jun 12, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@ddiazccrz ddiazccrz added ready for review PR is ready to be reviewed skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated labels Jun 12, 2025
Copy link
Contributor

@sf-jhalak-maheshwari sf-jhalak-maheshwari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a conflict we need to fix, other than that it looks good :)

@ddiazccrz ddiazccrz closed this Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review PR is ready to be reviewed skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.