[Fix E2E Tests] Improve E2E Test and Tracking Consent Banner Handling (@W-18764173@) by adamraya · Pull Request #2575 · SalesforceCommerceCloud/pwa-kit

adamraya · 2025-06-16T21:19:54Z

Description

The PR fixes failing E2E tests by improving handling the Tracking Consent form that was causing issues with tests. The PR also improves the login/registration user validation by checking the URL and email.

Types of Changes

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Documentation update
Breaking change (could cause existing functionality to not work as expected)
Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop

Adding a required argument to a function

Changing the data type of a function parameter or return value

Adding a new peer dependency to package.json

Changes

Improved Tracking consent form handling.
Improved login/registration user validation via URL and email.

How to Test-Drive This PR

Run the full E2E tests:

npm run test:e2e

or use the Playwright UI:

npm run test:e2e:ui

or run specific tests e.g.:

# Tracking consent handling test
npm run test:e2e -- --grep "Shopper can use the consent tracking form"

# Login/registration user validation test
npm run test:e2e -- --grep "Registered shopper can checkout items|Registered shopper can add item to wishlist"

Checklists

General

Changes are covered by test cases
CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

There are no changes to UI

or...

Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
Changes comply with WCAG 2.0 guidelines levels A and AA
Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

Changes include a UI text update in the Retail React App (which requires translation)

cc-prodsec · 2025-06-16T21:20:06Z

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

alexvuong · 2025-06-17T17:56:56Z

e2e/scripts/pageHelpers.js

    expect((await tokenResponsePromise).status()).toBe(200)

-    await expect(page.getByRole('heading', {name: /Account Details/i})).toBeVisible()
+    await page.waitForLoadState('networkidle', { timeout: 10000 })


this option is discouraged. Can we find the alternative?

wait for request/response is a better option: https://github.com/SalesforceCommerceCloud/storefrontdata

alexvuong · 2025-06-17T22:12:43Z

e2e/scripts/pageHelpers.js

        userCredentials: registeredUserCredentials
    })

+    // If login fails, try registration with fallback


Clean up some of these comment perhaps? I don't think we need them all

shethj

LGTM 🚀

shethj · 2025-06-18T00:10:31Z

e2e/scripts/pageHelpers.js

-        await tokenResponsePromise
-        expect((await tokenResponsePromise).status()).toBe(200)
+
+        const loginResponse = await loginResponsePromise


Good work asserting on the response rather than waiting for an element to show up. We use this as a best practice because playwright behaves more stable when waiting for a response.

…/SalesforceCommerceCloud/pwa-kit into adamraya/W-18764173-fix-e2e-test

* Handle SDK Client not initialized * Added tests for useResolvedClient * Handle missing SDK Client ShopperContext * ShopperCustomers - Handle SDK Client no init * ShopperExperience - Handle missing SDK Client * ShopperGiftCertificates - Handle missing SDK Client * ShopperLogin: Handle missing SDK client * ShopperOrders - Handle Missing SDK Client * ShopperProducts: Handle missing SDK Client * ShopperPromotions: Handle missing SDK client * ShopperSearch - Handle missing SDK Client * ShopperSEO: Handle missing SDK Client * ShopperStores: Handle missing SDK Client * Fix linting errors * Update useResolvedClient tests * Update changelog * implemented the voiceover feature for the email confirmation modal on PWA kit. * Update changelog * Extract CLIENT_KEY literal to constnt * updated the chanege log file to point to current changes and saved changes to email confirmation modal code * linted the files and built translations * changed role and aria label tags to solve unsuccessful check issues * Implemented changes to create more successful checks after facing a testing Library ElementError: Found multiple elements with the text: /check your email/i * Linted my files * Remove additional hook for client validation * Fix linting * Add comments * rename apiClients variable to add clarity Co-authored-by: Kevin He <kevin.he@salesforce.com> Signed-off-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> * update variable name for apiClients * linted more files to fix unsuccessful check error * linted more files to fix unsuccessful check error * Update packages/template-retail-react-app/CHANGELOG.md Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> * taking off the visible focus outline around the modal border * Initial Commit Follow `plugin_einstein_api` implementation for event data creation. * Update CHANGELOG.md * Update CHANGELOG.md * Add some additional tests * PR Feedback * adding an a11y tag to changes made docuemented in the change log reading document * Fix bar reference to master.variantId * removed redundant aria label that repeating email confirmation title * mitigating the need for additional translations * feat: cursor rules for unit tests * Update packages/template-retail-react-app/CHANGELOG.md Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> * Update packages/template-retail-react-app/CHANGELOG.md Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> * Update change log * Fixing bad merge * Update sample query implementation in query.ts * [Fix E2E Tests] Improve E2E Test and Tracking Consent Banner Handling (@W-18764173@) (#2575) * Improve e2e tests and Tracking Consent banner handling * Clean up * More clean up * Remove spacing changes * PR Feedback * Remove comments * rules only * Update translations (#2616) * update translations * @W-18541294@ Private client proxy updates (#2608) * Ensure only requests to /shopper/auth/ are allowed by the SLAS private client proxy * Remove console.logs * Stop swallowing errors from SLAS * Update CHANGELOG.md * Fix login and logout * Remove console logs * Lint * Add and fix tests * Cleanup regex --------- Signed-off-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> Signed-off-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Jainam Sheth <j.sheth@salesforce.com> Co-authored-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> Co-authored-by: Larnelle Ankunda <lankunda@salesforce.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Co-authored-by: Ben Chypak <bchypak@salesforce.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Shailesh Zirpe <szirpe+sf@salesforce.com> Co-authored-by: Shailesh Zirpe <42553862+szirpesf@users.noreply.github.com> Co-authored-by: Adam Raya <adamraya@users.noreply.github.com> Co-authored-by: Alex Vuong <alex.vuong@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Handle SDK Client not initialized * Added tests for useResolvedClient * Handle missing SDK Client ShopperContext * ShopperCustomers - Handle SDK Client no init * ShopperExperience - Handle missing SDK Client * ShopperGiftCertificates - Handle missing SDK Client * ShopperLogin: Handle missing SDK client * ShopperOrders - Handle Missing SDK Client * ShopperProducts: Handle missing SDK Client * ShopperPromotions: Handle missing SDK client * ShopperSearch - Handle missing SDK Client * ShopperSEO: Handle missing SDK Client * ShopperStores: Handle missing SDK Client * Fix linting errors * Update useResolvedClient tests * Update changelog * implemented the voiceover feature for the email confirmation modal on PWA kit. * Update changelog * Extract CLIENT_KEY literal to constnt * updated the chanege log file to point to current changes and saved changes to email confirmation modal code * linted the files and built translations * changed role and aria label tags to solve unsuccessful check issues * Implemented changes to create more successful checks after facing a testing Library ElementError: Found multiple elements with the text: /check your email/i * Linted my files * Remove additional hook for client validation * Fix linting * Add comments * rename apiClients variable to add clarity Co-authored-by: Kevin He <kevin.he@salesforce.com> Signed-off-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> * update variable name for apiClients * linted more files to fix unsuccessful check error * linted more files to fix unsuccessful check error * Update packages/template-retail-react-app/CHANGELOG.md Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> * taking off the visible focus outline around the modal border * Initial Commit Follow `plugin_einstein_api` implementation for event data creation. * Update CHANGELOG.md * Update CHANGELOG.md * Add some additional tests * PR Feedback * adding an a11y tag to changes made docuemented in the change log reading document * Fix bar reference to master.variantId * removed redundant aria label that repeating email confirmation title * mitigating the need for additional translations * feat: cursor rules for unit tests * Update packages/template-retail-react-app/CHANGELOG.md Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> * Update packages/template-retail-react-app/CHANGELOG.md Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> * Update change log * Fixing bad merge * Update sample query implementation in query.ts * [Fix E2E Tests] Improve E2E Test and Tracking Consent Banner Handling (@W-18764173@) (#2575) * Improve e2e tests and Tracking Consent banner handling * Clean up * More clean up * Remove spacing changes * PR Feedback * Remove comments * rules only * Update translations (#2616) * update translations * @W-18541294@ Private client proxy updates (#2608) * Ensure only requests to /shopper/auth/ are allowed by the SLAS private client proxy * Remove console.logs * Stop swallowing errors from SLAS * Update CHANGELOG.md * Fix login and logout * Remove console logs * Lint * Add and fix tests * Cleanup regex * skip changelog --------- Signed-off-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> Signed-off-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Jainam Sheth <j.sheth@salesforce.com> Co-authored-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> Co-authored-by: Larnelle Ankunda <lankunda@salesforce.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Co-authored-by: Ben Chypak <bchypak@salesforce.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Shailesh Zirpe <szirpe+sf@salesforce.com> Co-authored-by: Shailesh Zirpe <42553862+szirpesf@users.noreply.github.com> Co-authored-by: Adam Raya <adamraya@users.noreply.github.com> Co-authored-by: Alex Vuong <alex.vuong@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>

* Make API clients injectable to allow tree-shaking * Update changelog * Implemented commerce API provider proxy * Allow promise based response from the transformer * Restore comment * Revert lint change * Revert template changes * Revert template changes * Revert template changes * @W-18598001 improve order history test coverage prior to bonus changes * @W-18598001 improve order history test coverage prior to bonus changes * Extract injector types out of provider * Fix linting and add test cases * Trigger CI commit * Trigger CI commit * Restore isomorphic SDK * @W-18598001 improve order history test coverage prior to bonus changes * Rename withParameterInjection to be more self-explanatory * Fix linting * Added a test to PDP page for checking translations * skip changelog * skip changelog * Update changelog to point to correct PR * Linting errors * Moved the test over to product-view page and added translations for both the buttons * Linting changes * Handle SDK Client not initialized * Added tests for useResolvedClient * Handle missing SDK Client ShopperContext * ShopperCustomers - Handle SDK Client no init * ShopperExperience - Handle missing SDK Client * ShopperGiftCertificates - Handle missing SDK Client * ShopperLogin: Handle missing SDK client * ShopperOrders - Handle Missing SDK Client * ShopperProducts: Handle missing SDK Client * ShopperPromotions: Handle missing SDK client * ShopperSearch - Handle missing SDK Client * ShopperSEO: Handle missing SDK Client * ShopperStores: Handle missing SDK Client * Fix linting errors * Update useResolvedClient tests * Update changelog * implemented the voiceover feature for the email confirmation modal on PWA kit. * Update changelog * Extract CLIENT_KEY literal to constnt * updated the chanege log file to point to current changes and saved changes to email confirmation modal code * Remove unneeded hyphen from code comment * skip changelog * migrate store locator implementation * create index file * linted the files and built translations * add constants * remove path from store locator config * fix default page size * remove store-locator modal OLD implementation * fix intl * get search to work * fix types * move constants * fix tests * add tsconfig.json and lint * lint * commit translation changes * add diagram * Add apiClients as dependency * changed role and aria label tags to solve unsuccessful check issues * Review comments * Implemented changes to create more successful checks after facing a testing Library ElementError: Found multiple elements with the text: /check your email/i * Remove passing children to transformSDKClient * Linted my files * move use-store-locator to hooks folder * move use-geolocation to hooks folder * move store locator contants * remove unused file * move store locator contexts * convert store locator from ts to js * convert store locator from ts to js * remove tsconfig.json * linting issue * add proptypes / fix lint * Remove additional hook for client validation * Fix linting * fix lint * Add comments * rename apiClients variable to add clarity Co-authored-by: Kevin He <kevin.he@salesforce.com> Signed-off-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> * update variable name for apiClients * Update existing translations with updated localization (#2552) * update existing translations with updated localization * linted more files to fix unsuccessful check error * linted more files to fix unsuccessful check error * Update packages/template-retail-react-app/CHANGELOG.md Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> * taking off the visible focus outline around the modal border * Revert Bonus Label Change * Initial Commit Follow `plugin_einstein_api` implementation for event data creation. * Update CHANGELOG.md * Update CHANGELOG.md * Add some additional tests * PR Feedback * adding an a11y tag to changes made docuemented in the change log reading document * Fix bar reference to master.variantId * removed redundant aria label that repeating email confirmation title * mitigating the need for additional translations * feat: cursor rules for unit tests * Update packages/template-retail-react-app/CHANGELOG.md Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> * Update packages/template-retail-react-app/CHANGELOG.md Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> * Update change log * Fixing bad merge * Update sample query implementation in query.ts * [Fix E2E Tests] Improve E2E Test and Tracking Consent Banner Handling (@W-18764173@) (#2575) * Improve e2e tests and Tracking Consent banner handling * Clean up * More clean up * Remove spacing changes * PR Feedback * Remove comments * rules only * Update translations (#2616) * update translations * @W-18541294@ Private client proxy updates (#2608) * Ensure only requests to /shopper/auth/ are allowed by the SLAS private client proxy * Remove console.logs * Stop swallowing errors from SLAS * Update CHANGELOG.md * Fix login and logout * Remove console logs * Lint * Add and fix tests * Cleanup regex * Optionally disable auth init in commerce api provider * Update changelog * Add unit tests * Update PR link in changelog * @W-18794728: change demo instance, use a pod instead of sandbox (#2610) * Change demo instance * feat: load active data scripts on demand only @W-18708970 (#2623) * Fixed merge conflicts * Fixed bundle test to not be flappy --------- Signed-off-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> Signed-off-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Jainam Sheth <j.sheth@salesforce.com> Co-authored-by: Kyle Wright <kyle.wright@salesforce.com> Co-authored-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> Co-authored-by: snilakandan <snilakandan@salesforce.com> Co-authored-by: snilakandan13 <119348013+snilakandan13@users.noreply.github.com> Co-authored-by: Larnelle Ankunda <lankunda@salesforce.com> Co-authored-by: Kyle Wright <30636085+sf-kyle-wright@users.noreply.github.com> Co-authored-by: cboscenco <cboscenco@salesforce.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Co-authored-by: Alex Vuong <alex.vuong@salesforce.com> Co-authored-by: sf-deepali-bharmal <deepali.bharmal@salesforce.com> Co-authored-by: Ben Chypak <bchypak@salesforce.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Shailesh Zirpe <szirpe+sf@salesforce.com> Co-authored-by: Shailesh Zirpe <42553862+szirpesf@users.noreply.github.com> Co-authored-by: Adam Raya <adamraya@users.noreply.github.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Ujwala <59447810+unandyala@users.noreply.github.com> Co-authored-by: Steffen Eckardt <3235219+seckardt@users.noreply.github.com>

* Support standard product on PDP @W-12360908 (#2518) * update handleAddToCart and validate orderability * remove bundle changes, template test, and project config * add fallback if no image * linting * add validateOrderability tests * reorganize tests * fix lint errors * update validateOrderability logic * add product-detail tests * fix modal image link * add modal tests * changelog * pr suggestions * Handle SDK Client not initialized * Added tests for useResolvedClient * Handle missing SDK Client ShopperContext * ShopperCustomers - Handle SDK Client no init * ShopperExperience - Handle missing SDK Client * ShopperGiftCertificates - Handle missing SDK Client * ShopperLogin: Handle missing SDK client * ShopperOrders - Handle Missing SDK Client * ShopperProducts: Handle missing SDK Client * ShopperPromotions: Handle missing SDK client * ShopperSearch - Handle missing SDK Client * ShopperSEO: Handle missing SDK Client * ShopperStores: Handle missing SDK Client * Fix linting errors * Update useResolvedClient tests * Update changelog * Update changelog * Extract CLIENT_KEY literal to constnt * Remove additional hook for client validation * Fix linting * Add comments * rename apiClients variable to add clarity Co-authored-by: Kevin He <kevin.he@salesforce.com> Signed-off-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> * update variable name for apiClients * Update sample query implementation in query.ts * Initial Commit Follow `plugin_einstein_api` implementation for event data creation. * Update CHANGELOG.md * Add some additional tests * PR Feedback * Fix bar reference to master.variantId * feat: cursor rules for unit tests * Update change log * Support standard product on PDP @W-12360908 (#2518) * update handleAddToCart and validate orderability * remove bundle changes, template test, and project config * add fallback if no image * linting * add validateOrderability tests * reorganize tests * fix lint errors * update validateOrderability logic * add product-detail tests * fix modal image link * add modal tests * changelog * pr suggestions * Resolve merge conflict * Update files with conflicts * omg so we're not adding these * merge develop into standard product feature branch (#2626) * Handle SDK Client not initialized * Added tests for useResolvedClient * Handle missing SDK Client ShopperContext * ShopperCustomers - Handle SDK Client no init * ShopperExperience - Handle missing SDK Client * ShopperGiftCertificates - Handle missing SDK Client * ShopperLogin: Handle missing SDK client * ShopperOrders - Handle Missing SDK Client * ShopperProducts: Handle missing SDK Client * ShopperPromotions: Handle missing SDK client * ShopperSearch - Handle missing SDK Client * ShopperSEO: Handle missing SDK Client * ShopperStores: Handle missing SDK Client * Fix linting errors * Update useResolvedClient tests * Update changelog * implemented the voiceover feature for the email confirmation modal on PWA kit. * Update changelog * Extract CLIENT_KEY literal to constnt * updated the chanege log file to point to current changes and saved changes to email confirmation modal code * linted the files and built translations * changed role and aria label tags to solve unsuccessful check issues * Implemented changes to create more successful checks after facing a testing Library ElementError: Found multiple elements with the text: /check your email/i * Linted my files * Remove additional hook for client validation * Fix linting * Add comments * rename apiClients variable to add clarity Co-authored-by: Kevin He <kevin.he@salesforce.com> Signed-off-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> * update variable name for apiClients * linted more files to fix unsuccessful check error * linted more files to fix unsuccessful check error * Update packages/template-retail-react-app/CHANGELOG.md Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> * taking off the visible focus outline around the modal border * Initial Commit Follow `plugin_einstein_api` implementation for event data creation. * Update CHANGELOG.md * Update CHANGELOG.md * Add some additional tests * PR Feedback * adding an a11y tag to changes made docuemented in the change log reading document * Fix bar reference to master.variantId * removed redundant aria label that repeating email confirmation title * mitigating the need for additional translations * feat: cursor rules for unit tests * Update packages/template-retail-react-app/CHANGELOG.md Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> * Update packages/template-retail-react-app/CHANGELOG.md Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> * Update change log * Fixing bad merge * Update sample query implementation in query.ts * [Fix E2E Tests] Improve E2E Test and Tracking Consent Banner Handling (@W-18764173@) (#2575) * Improve e2e tests and Tracking Consent banner handling * Clean up * More clean up * Remove spacing changes * PR Feedback * Remove comments * rules only * Update translations (#2616) * update translations * @W-18541294@ Private client proxy updates (#2608) * Ensure only requests to /shopper/auth/ are allowed by the SLAS private client proxy * Remove console.logs * Stop swallowing errors from SLAS * Update CHANGELOG.md * Fix login and logout * Remove console logs * Lint * Add and fix tests * Cleanup regex --------- Signed-off-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> Signed-off-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Jainam Sheth <j.sheth@salesforce.com> Co-authored-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> Co-authored-by: Larnelle Ankunda <lankunda@salesforce.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Co-authored-by: Ben Chypak <bchypak@salesforce.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Shailesh Zirpe <szirpe+sf@salesforce.com> Co-authored-by: Shailesh Zirpe <42553862+szirpesf@users.noreply.github.com> Co-authored-by: Adam Raya <adamraya@users.noreply.github.com> Co-authored-by: Alex Vuong <alex.vuong@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> * @W-12360935 Modify the Product Card to support standard products (#2581) * remove 'edit'for std prd | Add unit tests * update changelog * lint fixes * show Edit button on bundleProducts * handle empty product bundles * better determination of if-standardProduct --------- Signed-off-by: sf-shikhar-prasoon <214730309+sf-shikhar-prasoon@users.noreply.github.com> * udpate changelog to resolve conflict * udpate changelog to resolve conflict 2 * udpate changelog to resolve conflict 3 * oops * Merge develop into standard-product-support (#2633) * Handle SDK Client not initialized * Added tests for useResolvedClient * Handle missing SDK Client ShopperContext * ShopperCustomers - Handle SDK Client no init * ShopperExperience - Handle missing SDK Client * ShopperGiftCertificates - Handle missing SDK Client * ShopperLogin: Handle missing SDK client * ShopperOrders - Handle Missing SDK Client * ShopperProducts: Handle missing SDK Client * ShopperPromotions: Handle missing SDK client * ShopperSearch - Handle missing SDK Client * ShopperSEO: Handle missing SDK Client * ShopperStores: Handle missing SDK Client * Fix linting errors * Update useResolvedClient tests * Update changelog * implemented the voiceover feature for the email confirmation modal on PWA kit. * Update changelog * Extract CLIENT_KEY literal to constnt * updated the chanege log file to point to current changes and saved changes to email confirmation modal code * linted the files and built translations * changed role and aria label tags to solve unsuccessful check issues * Implemented changes to create more successful checks after facing a testing Library ElementError: Found multiple elements with the text: /check your email/i * Linted my files * Remove additional hook for client validation * Fix linting * Add comments * rename apiClients variable to add clarity Co-authored-by: Kevin He <kevin.he@salesforce.com> Signed-off-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> * update variable name for apiClients * linted more files to fix unsuccessful check error * linted more files to fix unsuccessful check error * Update packages/template-retail-react-app/CHANGELOG.md Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> * taking off the visible focus outline around the modal border * Initial Commit Follow `plugin_einstein_api` implementation for event data creation. * Update CHANGELOG.md * Update CHANGELOG.md * Add some additional tests * PR Feedback * adding an a11y tag to changes made docuemented in the change log reading document * Fix bar reference to master.variantId * removed redundant aria label that repeating email confirmation title * mitigating the need for additional translations * feat: cursor rules for unit tests * Update packages/template-retail-react-app/CHANGELOG.md Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> * Update packages/template-retail-react-app/CHANGELOG.md Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> * Update change log * Fixing bad merge * Update sample query implementation in query.ts * [Fix E2E Tests] Improve E2E Test and Tracking Consent Banner Handling (@W-18764173@) (#2575) * Improve e2e tests and Tracking Consent banner handling * Clean up * More clean up * Remove spacing changes * PR Feedback * Remove comments * rules only * Update translations (#2616) * update translations * @W-18541294@ Private client proxy updates (#2608) * Ensure only requests to /shopper/auth/ are allowed by the SLAS private client proxy * Remove console.logs * Stop swallowing errors from SLAS * Update CHANGELOG.md * Fix login and logout * Remove console logs * Lint * Add and fix tests * Cleanup regex * skip changelog --------- Signed-off-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> Signed-off-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Jainam Sheth <j.sheth@salesforce.com> Co-authored-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> Co-authored-by: Larnelle Ankunda <lankunda@salesforce.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Co-authored-by: Ben Chypak <bchypak@salesforce.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Shailesh Zirpe <szirpe+sf@salesforce.com> Co-authored-by: Shailesh Zirpe <42553862+szirpesf@users.noreply.github.com> Co-authored-by: Adam Raya <adamraya@users.noreply.github.com> Co-authored-by: Alex Vuong <alex.vuong@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> * Support standard product as a child item in bundles @W-18790730 (#2574) * init commit * skip variation check for standard product * update modal logic * add product view test * add to cart modal test * add product detail test * update add to cart modal test * add product util test * update changelog * fix edit bundle * lint * Handle standard product shape in sendAddToCart * Update CHANGELOG.md * Support standard product as a child item in sets @W-18790730 (#2636) * fix adding set to cart * updae changelog * udpate util test * Add test * Lint tests * @W-18767088 refactor add to cart * @W-18767088 refactor add to cart * @W-18767088 fix lint errors * @W-18767088 do not move handleChildProductValidation * @W-12360935 2nd PR- fixing Edit button appearing briefly for standard products (#2649) * fix Edit button appearing briefly * fix tests * @W-18767088 utils rename * Revert CHANGELOG.md Signed-off-by: sf-emmyzhang <emmyzhang@salesforce.com> * increase bundle size for ci error * update use add to cart modal unit test * revert auto merge change * add image placeholder todo * rename bundleChildVariant * revert refactor work * add bundle test * lint * update test * lint * Handle out of stock for standard product * tests and linting * handle lack of type --------- Signed-off-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> Signed-off-by: Larnelle Ankunda <lankunda@salesforce.com> Signed-off-by: Ben Chypak <bchypak@mobify.com> Signed-off-by: sf-shikhar-prasoon <214730309+sf-shikhar-prasoon@users.noreply.github.com> Signed-off-by: Kyle Wright <30636085+sf-kyle-wright@users.noreply.github.com> Signed-off-by: sf-emmyzhang <emmyzhang@salesforce.com> Co-authored-by: Jainam Sheth <j.sheth@salesforce.com> Co-authored-by: Jainam Sheth <99490559+shethj@users.noreply.github.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> Co-authored-by: Ben Chypak <bchypak@salesforce.com> Co-authored-by: Shailesh Zirpe <szirpe+sf@salesforce.com> Co-authored-by: Larnelle Ankunda <lankunda@salesforce.com> Co-authored-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Shailesh Zirpe <42553862+szirpesf@users.noreply.github.com> Co-authored-by: Adam Raya <adamraya@users.noreply.github.com> Co-authored-by: Alex Vuong <alex.vuong@salesforce.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: sf-shikhar-prasoon <214730309+sf-shikhar-prasoon@users.noreply.github.com> Co-authored-by: Jang ho Jung <jangho.jung@salesforce.com> Co-authored-by: Kyle Wright <kyle.wright@salesforce.com> Co-authored-by: jeremy-jung1 <140001271+jeremy-jung1@users.noreply.github.com> Co-authored-by: Kyle Wright <30636085+sf-kyle-wright@users.noreply.github.com>

Improve e2e tests and Tracking Consent banner handling

bee1363

adamraya requested a review from a team as a code owner June 16, 2025 21:19

Clean up

1e12748

alexvuong reviewed Jun 17, 2025

View reviewed changes

adamraya added 4 commits June 17, 2025 13:04

More clean up

07314a1

Remove spacing changes

77d934a

PR Feedback

c17db5c

Merge branch 'develop' into adamraya/W-18764173-fix-e2e-test

720bd7b

alexvuong reviewed Jun 17, 2025

View reviewed changes

Merge branch 'develop' into adamraya/W-18764173-fix-e2e-test

8f2a078

shethj previously approved these changes Jun 18, 2025

View reviewed changes

adamraya added 2 commits June 18, 2025 14:48

Remove comments

345825c

Merge branch 'adamraya/W-18764173-fix-e2e-test' of https://github.com…

733d7fe

…/SalesforceCommerceCloud/pwa-kit into adamraya/W-18764173-fix-e2e-test

adamraya dismissed shethj’s stale review via 733d7fe June 18, 2025 21:48

Merge branch 'develop' into adamraya/W-18764173-fix-e2e-test

b83578b

alexvuong approved these changes Jun 18, 2025

View reviewed changes

shethj approved these changes Jun 18, 2025

View reviewed changes

adamraya merged commit d45078a into develop Jun 18, 2025
35 checks passed

adamraya deleted the adamraya/W-18764173-fix-e2e-test branch June 18, 2025 22:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix E2E Tests] Improve E2E Test and Tracking Consent Banner Handling (@W-18764173@)#2575

[Fix E2E Tests] Improve E2E Test and Tracking Consent Banner Handling (@W-18764173@)#2575
adamraya merged 10 commits intodevelopfrom
adamraya/W-18764173-fix-e2e-test

adamraya commented Jun 16, 2025 •

edited

Loading

Uh oh!

cc-prodsec commented Jun 16, 2025 •

edited

Loading

Uh oh!

alexvuong Jun 17, 2025

Uh oh!

shethj Jun 18, 2025

Uh oh!

alexvuong Jun 17, 2025

Uh oh!

shethj left a comment

Uh oh!

shethj Jun 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

adamraya commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of Changes

Changes

How to Test-Drive This PR

Checklists

General

Accessibility Compliance

Localization

Uh oh!

cc-prodsec commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Snyk checks have passed. No issues have been found so far.

Uh oh!

alexvuong Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

shethj Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

alexvuong Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

shethj left a comment

Choose a reason for hiding this comment

Uh oh!

shethj Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adamraya commented Jun 16, 2025 •

edited

Loading

cc-prodsec commented Jun 16, 2025 •

edited

Loading