Skip to content

@W-18672776 feat: PageNotFound chakra v3 upgrade#2639

Merged
sf-henry-semaganda merged 6 commits intofeature/chakra-ui-upgrade-v3from
W-18672776_page_not_found
Jun 27, 2025
Merged

@W-18672776 feat: PageNotFound chakra v3 upgrade#2639
sf-henry-semaganda merged 6 commits intofeature/chakra-ui-upgrade-v3from
W-18672776_page_not_found

Conversation

@sf-henry-semaganda
Copy link
Contributor

@sf-henry-semaganda sf-henry-semaganda commented Jun 24, 2025

Description

  • upgrade PageNotFound Chakra UI v2 to v3

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • modify url to an invalid site by appending to i.ehttp://localhost:3000/global/en-GB/not-found

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Jun 24, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sf-henry-semaganda sf-henry-semaganda marked this pull request as ready for review June 26, 2025 18:20
@sf-henry-semaganda sf-henry-semaganda requested a review from a team as a code owner June 26, 2025 18:20
"path": "/product/:productId"
},
"PageNotFound": {
"path": "/test"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks odd...

@sf-henry-semaganda sf-henry-semaganda merged commit d1f02a1 into feature/chakra-ui-upgrade-v3 Jun 27, 2025
33 checks passed
alexvuong pushed a commit that referenced this pull request Jul 16, 2025
…_not_found

@W-18672776 feat: PageNotFound chakra v3 upgrade
@alexvuong alexvuong deleted the W-18672776_page_not_found branch July 16, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants