Skip to content

@W-18895432 Cleanup feature branch#2659

Merged
yhsieh1 merged 5 commits intofeature/pwa-developer-agent-onlyfrom
feature/W-18895432/cleanup
Jun 27, 2025
Merged

@W-18895432 Cleanup feature branch#2659
yhsieh1 merged 5 commits intofeature/pwa-developer-agent-onlyfrom
feature/W-18895432/cleanup

Conversation

@yhsieh1
Copy link
Contributor

@yhsieh1 yhsieh1 commented Jun 26, 2025

Description

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@yhsieh1 yhsieh1 requested a review from a team as a code owner June 26, 2025 14:00
@yhsieh1 yhsieh1 requested review from bendvc, snilakandan13 and wei-liu-sf and removed request for a team June 26, 2025 14:02
@yhsieh1 yhsieh1 added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Jun 26, 2025
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Jun 26, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@yhsieh1 yhsieh1 requested a review from wei-liu-sf June 26, 2025 17:55
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that we don't want the data model tool. But will this data model be useful for other tools?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yhsieh1 - I am making use of the data models in the create_sample_component tool

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snilakandan13 I revert back all json files.

)
}

async getDataModelDocument(modelName, uriHref) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont need the tool of data_model, but the function of getDataModelDocument

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snilakandan13 this is not a right way to reference json data. You could simply export json data from a js file and import it into server.js or your tool js to consume it.

@yhsieh1 yhsieh1 merged commit a0891a4 into feature/pwa-developer-agent-only Jun 27, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants