@W-18685522 Password Reset and Passwordless Integration Test by jeremy-jung1 · Pull Request #2669 · SalesforceCommerceCloud/pwa-kit

jeremy-jung1 · 2025-06-27T06:47:48Z

Description

Currently, there are no active e2e tests in the PWA Kit for Password Reset and Passwordless Login. This is because these flows are more complex and require user interaction for successful completion. Although not end to end due to the limitation of not being able to programmatically access an email inbox without some commitments (https://salesforce.quip.com/7Ab4AT4aeKyj), we will test to ensure that at least the PWA kit features are communicating necessary information to external services (e.g. SLAS and marketing cloud) and showing the right views.

Some features in the template retail react app is defaulted to be "off" (e.g., if they are dependent on SLAS private client). Thus, these features are not reflected in the current E2E test sites. For these "extra" features, a separate E2E test site is nightly synced with the branch extra-features-e2e-branch, which will also merge develop into itself nightly. E2E tests on these features will run against this site.

Types of Changes

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Documentation update
Breaking change (could cause existing functionality to not work as expected)
Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

Removing a public function or component or prop

Adding a required argument to a function

Changing the data type of a function parameter or return value

Adding a new peer dependency to package.json

Changes

(change1) Added playwright test for passwordless login API call
(change2) Added playwright test for password reset initiation API call and the actual reset API call
(change3) Added tests for email sending in ssr.js
(change4) A nightly job to sync the extra features e2e branch with the extra features e2e test site

How to Test-Drive This PR

(step1) Do npm run test:e2e:ui. Check that login.spec.js tests pass for desktop and mobile

Checklists

General

Changes are covered by test cases
CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

There are no changes to UI

or...

Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
Changes comply with WCAG 2.0 guidelines levels A and AA
Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

Changes include a UI text update in the Retail React App (which requires translation)

cc-prodsec · 2025-06-27T06:47:56Z

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

hajinsuha1 · 2025-06-27T14:36:52Z

e2e/config.js

  PWA_E2E_USER_EMAIL: process.env.PWA_E2E_USER_EMAIL,
  PWA_E2E_USER_PASSWORD: process.env.PWA_E2E_USER_PASSWORD,
-  SOCIAL_LOGIN_RETAIL_APP_HOME: "https://wasatch-mrt-feature-public.mrt-storefront-staging.com"
+  MORE_LOGIN_OPTIONS_RETAIL_APP_HOME: "https://wasatch-mrt-feature-private.mrt-storefront-staging.com"


would we want to use an environment deployed in a pwa kit owned environment to make sure it doesnt get lost or deleted? I see in CI it uses this one:

pwa-kit/.github/workflows/e2e.yml

Line 374 in 8417719

run: export RETAIL_APP_HOME=https://scaffold-pwa-e2e-pwa-kit-private.mobify-storefront.com/

Also would we consider using a more generic name for the constant like RETAIL_REACT_APP_HOME_PRIVATE_CLIENT so it can be used for other private client E2E tests in the future?

The RETAIL_APP_HOME doesn't have social and passwordless enabled, so consolidating on one site will lose us an E2E test "branch" of the PWA kit site configured without the social and passwordless changes, which has an impact on the UI. Right now we have two sites: one with the additional login features and one not, and I thought that was a good variety of sites.

I can make the deployment on the pwa-kit environment instead to make it more visible

Oh sorry I meant, it looks like there are 2 PWA Kit sites:

https://scaffold-pwa-e2e-pwa-kit-private.mobify-storefront.com (defined in e2e.yaml and not in the config)

https://scaffold-pwa-e2e-tests-pwa-kit.mobify-storefront.com (defined in the config)

Was wondering if we should reuse https://scaffold-pwa-e2e-pwa-kit-private.mobify-storefront.com instead of creating a new one in the PWA Kit project

If we want to keep the tests for the old login paths then we should create a new site. https://scaffold-pwa-e2e-pwa-kit-private.mobify-storefront.com/ is the one that the e2e tests get executed on. The current e2e tests for shopper login assumes the UI for these new login features are turned off.

The new tests in this PR work on a UI where the passwordless login is enabled, so it has to go on a separate site. If we reuse a site, then we will lose the e2e test "coverage" on the old configuration without the features enabled.

Ah I think Jinsu is suggesting using the scaffold-pwa project because that is internal use only - so external non-PWA folks cannot alter or delete the environments

Updated the environment to be in scaffold-pwa and change the variable name to include other features that are defaulted to be off.

@jeremy-jung1 I know you already created the env, but is there potentially a better name that describes the configuration of the env?

I had originally thought the difference with this env vs the original e2e env is that it’s configured with a SLAS private client

The new environment is called EXTRA_FEATURES_E2E_RETAIL_APP_HOME. Instead of just features that has to be configured with SLAS Private Client, I thought a more encompassing name for features that are off by default would be good. Some features in the future might be dependent on other conditions. Social login is default to disabled too, but that isn't dependent on SLAS Private Client.

…tion-test

… do for now

jeremy-jung1 · 2025-07-02T20:29:53Z

packages/commerce-sdk-react/CHANGELOG.md

 - Gracefully handle missing SDK Clients in CommerceApiProvider [#2539](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2539)
 - Refactor commerce-sdk-react to allow injecting ApiClients [#2519](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2519)

+


For some reason the changelog_check required me to make an update to the commerce-sdk-react CHANGELOG, even though I don't have any changes here. Just putting a new line

shethj · 2025-07-03T16:02:53Z

e2e/tests/desktop/login.spec.js

+
+    expect(params.get('user_id')).toBe(config.PWA_E2E_USER_EMAIL)
+    expect(params.get('mode')).toBe('callback')
+    expect(params.get('channel_id')).toBe('RefArchGlobal')


Move the siteID to config as well. Incase we need to move the site we're pointing to.

shethj · 2025-07-03T16:05:29Z

e2e/tests/desktop/login.spec.js

+
+    expect(params.get('user_id')).toBe(config.PWA_E2E_USER_EMAIL)
+    expect(params.get('mode')).toBe('callback')
+    expect(params.get('channel_id')).toBe('RefArch')


Same. Avoid hardcoded config values.

shethj · 2025-07-03T16:37:47Z

Re-iterating for visibility:

Just curious about test orchestration.
So I see the new workflow you created deploys the code only for Node 22
However, the test runs for login.spec.js aren't really extracted into a separate playwright project . These tests will run with the other e2e tests.
And the main test workflow runs against a node matrix for Node 18, 20 and 22 x NPM 8, 9, 10, 11 x 3 setups
So what I suspect will happen is,
The social/passwordless login tests will run like 40 times like the other tests but since we're not deploying to the extra features instance.
All 40 runs will happen against the same Node 22 deployment which seems wasteful.

Consider extracting these tests into their own playwright project (add a new entry to the projects: [] where only these files run)
Create a new script in package.json for test:e2e:extra_features
In the main e2e.yml create a new job to run just these without the Node matrix.

…tion-test

jeremy-jung1 · 2025-07-07T06:28:02Z

^ See that the extra features tests are not run in the regular project. The tests are failing because the current e2e tests are failing due to a recent merge.

^ See that the extra features tests are run in the new project

shethj

Thanks for adding these in. LGTM 🚀

…tion-test

jeremy-jung1 added 4 commits June 24, 2025 17:52

playwright tests

c36c896

variable name change

cae80a9

Create ssr.test.js

98d6d75

fix the tests

14519ee

jeremy-jung1 requested a review from a team as a code owner June 27, 2025 06:47

jeremy-jung1 changed the title ~~@W-18685522 Reset and Passwordless Integration Test~~ @W-18685522 Password Reset and Passwordless Integration Test Jun 27, 2025

jeremy-jung1 added 3 commits June 26, 2025 23:49

Update CHANGELOG.md

ef7c280

Only keep tests relevant to the feature

f6940b0

Remove unused vars

8b1397c

hajinsuha1 reviewed Jun 27, 2025

View reviewed changes

jeremy-jung1 added 7 commits June 27, 2025 11:54

Merge branch 'develop' into W-18685522-reset-and-passwordless-integra…

de564d8

…tion-test

Linting

dceb6d9

More linting

f108b78

Try auto sync and deploy

da85267

for some reason need to update the commerce-sdk-react changelog. will…

a2cbaf2

… do for now

Try adding branch to dependency to test

d73e3c9

Try adding perms and removing notifications

ecd734d

jeremy-jung1 had a problem deploying to more-logins-e2e June 30, 2025 21:03 — with GitHub Actions Failure

Go to template retail react app

7203712

jeremy-jung1 temporarily deployed to more-logins-e2e June 30, 2025 21:21 — with GitHub Actions Inactive

Update project slug

c1e5387

jeremy-jung1 temporarily deployed to more-logins-e2e June 30, 2025 21:33 — with GitHub Actions Inactive

log some more info in push mrt

f8ad75c

jeremy-jung1 temporarily deployed to more-logins-e2e June 30, 2025 21:41 — with GitHub Actions Inactive

jeremy-jung1 added 2 commits June 30, 2025 22:06

Make some updates

9c24f62

Update yml file

b11782f

jeremy-jung1 deployed to more-logins-e2e July 1, 2025 16:28 — with GitHub Actions Active

jeremy-jung1 added 2 commits July 2, 2025 11:23

Change env name

eb4a480

Update branch name

52cec86

jeremy-jung1 commented Jul 2, 2025

View reviewed changes

jeremy-jung1 added 2 commits July 2, 2025 13:34

Remove force sync

1c96b6a

Add tests for when extra login features are not enabled

505f0af

shethj reviewed Jul 3, 2025

View reviewed changes

jeremy-jung1 and others added 14 commits July 3, 2025 23:27

Apply some feedback

70247cf

Update e2e.yml

e3cfcb4

Update command and comment some things for test

ec85ce8

Update e2e.yml

f6d34f0

Update e2e.yml

929d86c

Try to insert these env vars

10aa890

Apply feedback

2c94bc0

Update playwright.config.js

2ede681

Update separate mobile and desktop

9909caa

typo

0ab3fde

Fix the sites

6f59650

Update config.js

4caf056

Remove changes made for just testing

be5b871

Merge branch 'develop' into W-18685522-reset-and-passwordless-integra…

e584cdd

…tion-test

shethj previously approved these changes Jul 8, 2025

View reviewed changes

Remove dev only change

9de4b67

jeremy-jung1 dismissed shethj’s stale review via 9de4b67 July 8, 2025 16:17

jeremy-jung1 added 2 commits July 8, 2025 09:17

Merge branch 'develop' into W-18685522-reset-and-passwordless-integra…

6395135

…tion-test

Merge branch 'develop' into W-18685522-reset-and-passwordless-integra…

0123c9e

…tion-test

shethj approved these changes Jul 8, 2025

View reviewed changes

hajinsuha1 approved these changes Jul 8, 2025

View reviewed changes

Merge branch 'develop' into W-18685522-reset-and-passwordless-integra…

d3b026c

…tion-test

jeremy-jung1 merged commit e1306dc into develop Jul 8, 2025
36 checks passed

		- Gracefully handle missing SDK Clients in CommerceApiProvider [#2539](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2539)
		- Refactor commerce-sdk-react to allow injecting ApiClients [#2519](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2519)

Conversation

jeremy-jung1 commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of Changes

Changes

How to Test-Drive This PR

Checklists

General

Accessibility Compliance

Localization

Uh oh!

cc-prodsec commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Snyk checks have passed. No issues have been found so far.

Uh oh!

hajinsuha1 Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeremy-jung1 Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shethj Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shethj commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeremy-jung1 commented Jul 7, 2025

Uh oh!

shethj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jeremy-jung1 commented Jun 27, 2025 •

edited

Loading

cc-prodsec commented Jun 27, 2025 •

edited

Loading

hajinsuha1 Jun 27, 2025 •

edited

Loading

jeremy-jung1 Jul 3, 2025 •

edited

Loading

shethj Jul 3, 2025 •

edited

Loading

shethj commented Jul 3, 2025 •

edited

Loading