Skip to content

@W-18902403 - Select Off of Pickup in Store Option on PDP if New Store is Out of Stock#2679

Merged
shauryemahajanSF merged 1 commit intofeature/shop-in-storefrom
t/commerce/W-18902403/fixPDPRadioBehavior
Jun 27, 2025
Merged

@W-18902403 - Select Off of Pickup in Store Option on PDP if New Store is Out of Stock#2679
shauryemahajanSF merged 1 commit intofeature/shop-in-storefrom
t/commerce/W-18902403/fixPDPRadioBehavior

Conversation

@shauryemahajanSF
Copy link
Contributor

On PDP, going from a location that does have inventory to a store that doesnt still has pickup in store selected. Radio button should switch off pick up in store if its not a valid option.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

On PDP, going from a location that does have inventory to a store that doesnt still has pickup in store selected. Radio button should switch off pick up in store if its not a valid option.

How to Test-Drive This PR

See Video

Checklists

General

  • [] Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@shauryemahajanSF shauryemahajanSF added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Jun 27, 2025
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Jun 27, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@shauryemahajanSF shauryemahajanSF changed the title fix pdp radio button behavior @W-18902403 - Select Off of Pickup in Store Option on PDP if New Store is Out of Stock Jun 27, 2025
@shauryemahajanSF shauryemahajanSF marked this pull request as ready for review June 27, 2025 19:39
@shauryemahajanSF shauryemahajanSF requested a review from a team as a code owner June 27, 2025 19:39
Copy link
Contributor

@patricksullivansf patricksullivansf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for cleaning the obsolete storage references too

@shauryemahajanSF shauryemahajanSF merged commit d76268d into feature/shop-in-store Jun 27, 2025
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants