@W-18902403 - Select Off of Pickup in Store Option on PDP if New Store is Out of Stock#2679
Merged
shauryemahajanSF merged 1 commit intofeature/shop-in-storefrom Jun 27, 2025
Conversation
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
patricksullivansf
approved these changes
Jun 27, 2025
Contributor
patricksullivansf
left a comment
There was a problem hiding this comment.
thank you for cleaning the obsolete storage references too
d76268d
into
feature/shop-in-store
72 of 73 checks passed
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On PDP, going from a location that does have inventory to a store that doesnt still has pickup in store selected. Radio button should switch off pick up in store if its not a valid option.
Types of Changes
Changes
On PDP, going from a location that does have inventory to a store that doesnt still has pickup in store selected. Radio button should switch off pick up in store if its not a valid option.
How to Test-Drive This PR
See Video
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization