Skip to content

@W-18902413 - Fixed Incorrect Add to Cart Error #2681

Merged
shauryemahajanSF merged 4 commits intofeature/shop-in-storefrom
t/commerce/W-18902413/fixErrorMessageForAddToCartWithNoVariantSelected
Jun 30, 2025
Merged

@W-18902413 - Fixed Incorrect Add to Cart Error #2681
shauryemahajanSF merged 4 commits intofeature/shop-in-storefrom
t/commerce/W-18902413/fixErrorMessageForAddToCartWithNoVariantSelected

Conversation

@shauryemahajanSF
Copy link
Contributor

@shauryemahajanSF shauryemahajanSF commented Jun 27, 2025

Description

In a PDP, the error message in a variation group when the shopper does not choose a variation is "400" in the test site, but in the production storefront there is a "Please select all your options above" message.

Before:

Screen.Recording.2025-06-27.at.4.09.58.PM.mov

After:

Screen.Recording.2025-06-27.at.4.08.22.PM.mov

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • handleChildProductValidation is designed for product sets/bundles and doesn't properly validate individual products. ProductView component will use its default validateOrderability function as expected.

How to Test-Drive This PR

  • See vid

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@shauryemahajanSF shauryemahajanSF added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Jun 27, 2025
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Jun 27, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@shauryemahajanSF shauryemahajanSF marked this pull request as ready for review June 27, 2025 20:10
@shauryemahajanSF shauryemahajanSF requested a review from a team as a code owner June 27, 2025 20:10
@shauryemahajanSF shauryemahajanSF force-pushed the t/commerce/W-18902413/fixErrorMessageForAddToCartWithNoVariantSelected branch from 5346559 to 47917e0 Compare June 30, 2025 19:30
@shauryemahajanSF shauryemahajanSF merged commit e3649a9 into feature/shop-in-store Jun 30, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants