Cleanup from Select bonus button PR

[sf-deepali-bharmal]

Description

Taking care of minor comments from previous PR to add Select Bonus Product Button in cart - https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2569/files

Types of Changes

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Documentation update
• Breaking change (could cause existing functionality to not work as expected)
• Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

• Removing a public function or component or prop
• Adding a required argument to a function
• Changing the data type of a function parameter or return value
• Adding a new peer dependency to package.json

Changes

• Its a cleanup PR
• The text on top of 'Select Bonus Button" only shows up only when we have promotionName available.

How to Test-Drive This PR

• Make sure existing "Select Bonus products" from cart works as expected.
• Make sure text on top of 'Select Bonus Button" only shows up only when we have promotionName available.

Checklists

General

• Changes are covered by test cases
• CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

• There are no changes to UI

or...

• Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
• Changes comply with WCAG 2.0 guidelines levels A and AA
• Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

• Changes include a UI text update in the Retail React App (which requires translation)

[cc-prodsec]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

[alexvuong]

How about wrap the component inside skeleton?

<Skeleton isloading={!promotionName}>
<Text fontSize="lg" fontWeight="bold">
                    {promotionName} ({selectedOfferCount} of {maxOfferCount} selected)
                </Text>
<Skeleton>

[sf-deepali-bharmal]

Done

[alexvuong]

Disagree on this name. helpers tend to cater to function. How about cart-bonus-products.jsx?

[ddiazccrz]

Agree, helper doesnt feel right

[sf-deepali-bharmal]

cool. Changing to suggested name.