Skip to content

@W-18597952 - Scroll bar implementation for bonus products in the modal#2683

Open
sf-vrushal-kulkarni wants to merge 17 commits intofeature/bonus-productsfrom
t/cc-sharks/W-18597952
Open

@W-18597952 - Scroll bar implementation for bonus products in the modal#2683
sf-vrushal-kulkarni wants to merge 17 commits intofeature/bonus-productsfrom
t/cc-sharks/W-18597952

Conversation

@sf-vrushal-kulkarni
Copy link
Contributor

Screenshare.-.2025-06-27.1_00_50.PM.mp4

Description

  • Show bonus products in a fixed length view port so there’s a scroll bar when necessary but no lazy loading or infinite scrolling
  • Fixed bug related to horizontal scrolling on mobile
  • Fixed accessiblity bug for the checkbox to have a label
  • Refactored code to extract bonus product item sub-component

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • Show bonus products in a fixed length view port so there’s a scroll bar when necessary but no lazy loading or infinite scrolling
  • Fixed bug related to horizontal scrolling on mobile
  • Fixed accessiblity bug for the checkbox to have a label
  • Refactored code to extract bonus product item sub-component

How to Test-Drive This PR

  • Add a product which has list based promotions and scrolling should work as expected both in desktop and mobile
  • Add a product which has rule based promotions and scrolling should work as expected both in desktop and mobile. We should not see horizontal scrolling in the mobile view
  • Accessiblity check - When using keyboard, the screen reader should indicate and announce both checkbox and what item it is

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@sf-vrushal-kulkarni sf-vrushal-kulkarni requested a review from a team June 27, 2025 20:52
@sf-vrushal-kulkarni sf-vrushal-kulkarni requested a review from a team as a code owner June 27, 2025 20:52
@sf-vrushal-kulkarni sf-vrushal-kulkarni added ready for review PR is ready to be reviewed skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated labels Jun 27, 2025
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Jun 27, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sf-vrushal-kulkarni sf-vrushal-kulkarni changed the base branch from feature/bonus-products to feature/rule-based-bonus-products June 27, 2025 22:04
@sf-vrushal-kulkarni sf-vrushal-kulkarni changed the base branch from feature/rule-based-bonus-products to feature/bonus-products June 27, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review PR is ready to be reviewed skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants