[Chakra v3 upgrade] @W-18672580 migrate offline components#2684
Merged
sf-jie-dai merged 7 commits intofeature/chakra-ui-upgrade-v3from Jul 1, 2025
Merged
Conversation
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
sf-jie-dai
changed the title
sf-jie-dai
commented
Jun 30, 2025
| 'non-pwa/**/*.{js,jsx}', | ||
| 'worker/**/*.{js,jsx}', | ||
| 'scripts/generator/*.{js,jsx}', | ||
| 'src/**/*.{js,jsx}', |
Contributor
Author
There was a problem hiding this comment.
add unit test coverage report for extension-chakra-storefront folder
| import {useIntl} from 'react-intl' | ||
|
|
||
| // Components | ||
| import {Alert, AlertDescription, Flex} from '@chakra-ui/react' |
Contributor
Author
There was a problem hiding this comment.
In chakra v3, everything imported from Alert alone, AlertDescription is not needed anymore
| @@ -68,23 +68,13 @@ class OfflineBoundary extends React.Component { | |||
| return ( | |||
| <React.Fragment> | |||
Contributor
Author
There was a problem hiding this comment.
Every component in offline-boundary is v3 compatible already.
Removed legacy classnames
alexvuong
reviewed
Jun 30, 2025
packages/extension-chakra-storefront/src/components/offline-boundary/index.test.js
Outdated
Show resolved
Hide resolved
alexvuong
reviewed
Jun 30, 2025
packages/extension-chakra-storefront/src/components/offline-boundary/index.test.js
Outdated
Show resolved
Hide resolved
alexvuong
reviewed
Jun 30, 2025
packages/extension-chakra-storefront/src/components/offline-boundary/index.jsx
Outdated
Show resolved
Hide resolved
alexvuong
reviewed
Jun 30, 2025
packages/extension-chakra-storefront/src/components/offline-boundary/index.jsx
Outdated
Show resolved
Hide resolved
alexvuong
reviewed
Jun 30, 2025
packages/extension-chakra-storefront/src/components/offline-boundary/index.jsx
Outdated
Show resolved
Hide resolved
alexvuong
reviewed
Jun 30, 2025
packages/extension-chakra-storefront/src/components/offline-boundary/index.jsx
Outdated
Show resolved
Hide resolved
alexvuong
reviewed
Jun 30, 2025
|
|
||
| test('should render its children', () => { | ||
| renderWithRouter( | ||
| renderWithRouterAndChakra( |
Contributor
There was a problem hiding this comment.
Why cant we use renderWithProviders?
Contributor
Author
There was a problem hiding this comment.
In offline-boundary's index.jsx I saw
export default withRouter(OfflineBoundary)
From my understanding, with withRouter, the error boundary becomes "route-aware", in which normal renderWithProviders wouldn't be able to cover this use case. So use renderWithRouter for this special component
unandyala
approved these changes
Jun 30, 2025
alexvuong
approved these changes
Jun 30, 2025
sf-jie-dai
changed the title
alexvuong
pushed a commit
that referenced
this pull request
Jul 16, 2025
…om v2 to v3 (#2684) * update: migrate offline components from v2 to v3 * add unit test coverage report & cleanup * class name clean up * use renderWithRouter to test offline-boundary * use newer chakra UI component instead of basic html tags * wrap user.click with act * clean up comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate offline-banner & offline-boundary components to Chakra v3
Staging v2:
Local v3:
Unit test coverage:
Types of Changes
How to Test-Drive This PR
npm startIn staging env, https://pwa-kit.mobify-storefront.com/, everything works in Chakra v2.
For offline components, we could show them on purpose in staging env following:
No throttlingtoOfflineChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization