@W-18670301 - added prettier and improved tests for trim-extensions script#2688
Merged
kzheng-sfdc merged 4 commits intofeature/extensibility-v2from Jun 30, 2025
Merged
Conversation
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
kzheng-sfdc
commented
Jun 27, 2025
| // Replace the original file with the trimmed version | ||
| fs.writeFileSync(filePath, output) | ||
| // prettify the file | ||
| execSync(`npx prettier --write ${filePath}`) |
Contributor
Author
There was a problem hiding this comment.
Call prettier in a child process because it requires ES module, which this package doesn't support.
kzheng-sfdc
commented
Jun 27, 2025
| ) | ||
| }) | ||
|
|
||
| it('handles PropTypes declarations correctly', () => { |
Contributor
Author
There was a problem hiding this comment.
Added a new test case to demonstrate how to extend PropType declaration
kzheng-sfdc
added
the
skip changelog
bfeister
approved these changes
Jun 28, 2025
Contributor
bfeister
left a comment
bfeister
left a comment
There was a problem hiding this comment.
This is great, thanks for handling my suggestion around exact file contents versus "string contains" 🤝
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization