Skip to content

@W-18779257 BOPIS reviewer feedback small corrections#2692

Merged
patricksullivansf merged 4 commits intofeature/shop-in-storefrom
psullivan.W-18779257.bopisPrFeedback2
Jun 28, 2025
Merged

@W-18779257 BOPIS reviewer feedback small corrections#2692
patricksullivansf merged 4 commits intofeature/shop-in-storefrom
psullivan.W-18779257.bopisPrFeedback2

Conversation

@patricksullivansf
Copy link
Contributor

Description

Miscellaneous reviewer feedback in BOPIS PR

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@patricksullivansf patricksullivansf requested a review from a team as a code owner June 28, 2025 03:07
@patricksullivansf patricksullivansf added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Jun 28, 2025
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Jun 28, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@patricksullivansf patricksullivansf merged commit 0f46169 into feature/shop-in-store Jun 28, 2025
35 checks passed
@patricksullivansf patricksullivansf deleted the psullivan.W-18779257.bopisPrFeedback2 branch June 28, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants