Skip to content

@W-18942954 BOPIS revert unneeded swatch change#2700

Merged
patricksullivansf merged 3 commits intofeature/shop-in-storefrom
psullivan.W-18942954.bopisMorePrFeedback
Jul 1, 2025
Merged

@W-18942954 BOPIS revert unneeded swatch change#2700
patricksullivansf merged 3 commits intofeature/shop-in-storefrom
psullivan.W-18942954.bopisMorePrFeedback

Conversation

@patricksullivansf
Copy link
Contributor

@patricksullivansf patricksullivansf commented Jul 1, 2025

Description

  • reverting unexpected swatch group change
  • revert unneeded add to cart change
  • add constant for pickup radio

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@patricksullivansf patricksullivansf added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Jul 1, 2025
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Jul 1, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@patricksullivansf patricksullivansf marked this pull request as ready for review July 1, 2025 19:22
@patricksullivansf patricksullivansf requested a review from a team as a code owner July 1, 2025 19:22
Copy link
Contributor

@snilakandan13 snilakandan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@patricksullivansf patricksullivansf merged commit 27f92bd into feature/shop-in-store Jul 1, 2025
35 checks passed
@patricksullivansf patricksullivansf deleted the psullivan.W-18942954.bopisMorePrFeedback branch July 1, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants