@ W-18953852: Merge Feature/auto bonus product in to Develop #2704
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Copyright (c) 2025, salesforce.com, inc. | ||
| * All rights reserved. | ||
| * SPDX-License-Identifier: BSD-3-Clause | ||
| * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/BSD-3-Clause | ||
| */ | ||
| import React from 'react' | ||
| import PropTypes from 'prop-types' | ||
| import {FormattedMessage, useIntl} from 'react-intl' | ||
| import {Text, Skeleton} from '@salesforce/retail-react-app/app/components/shared/ui' | ||
|
|
||
| const BonusProductQuantity = ({product}) => { | ||
| const intl = useIntl() | ||
| return ( | ||
| <Skeleton isLoaded={product}> | ||
| <Text | ||
| fontSize="sm" | ||
| color="gray.700" | ||
| aria-label={intl.formatMessage( | ||
| { | ||
| id: 'item_variant.quantity.label', | ||
| defaultMessage: | ||
| 'Quantity selector for {productName}. Selected quantity is {quantity}' | ||
| }, | ||
| { | ||
| quantity: product?.quantity, | ||
| productName: product?.name | ||
| } | ||
| )} | ||
| > | ||
| <FormattedMessage | ||
| defaultMessage="Quantity: {quantity}" | ||
| id="bonus_product_item.label.quantity" | ||
| values={{quantity: product?.quantity}} | ||
| /> | ||
| </Text> | ||
| </Skeleton> | ||
| ) | ||
| } | ||
|
|
||
| BonusProductQuantity.propTypes = { | ||
| product: PropTypes.object | ||
| } | ||
|
|
||
| export default BonusProductQuantity | ||
|
Contributor
There was a problem hiding this comment. This is great, I love small components with a very specific purpose. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| /* | ||
| * Copyright (c) 2025, salesforce.com, inc. | ||
| * All rights reserved. | ||
| * SPDX-License-Identifier: BSD-3-Clause | ||
| * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/BSD-3-Clause | ||
| */ | ||
| import React from 'react' | ||
| import {render, screen} from '@testing-library/react' | ||
| import {IntlProvider} from 'react-intl' | ||
| import BonusProductQuantity from '@salesforce/retail-react-app/app/components/product-item/bonus-product-quantity' | ||
|
|
||
| const mockProduct = {quantity: 1} | ||
|
|
||
| const renderWithIntl = (component) => | ||
| render( | ||
| <IntlProvider locale="en" defaultLocale="en"> | ||
| {component} | ||
| </IntlProvider> | ||
| ) | ||
|
|
||
| describe('BonusProductQuantity', () => { | ||
| test('renders the quantity text', () => { | ||
|
Contributor
There was a problem hiding this comment. Add a test when skeleton is rendering
Contributor
Author
There was a problem hiding this comment. skeleton test added |
||
| renderWithIntl(<BonusProductQuantity product={mockProduct} />) | ||
| expect(screen.getByText(/Quantity: 1/)).toBeInTheDocument() | ||
| }) | ||
|
|
||
| test('applies correct aria-label', () => { | ||
| renderWithIntl(<BonusProductQuantity product={mockProduct} />) | ||
| const quantityElement = screen.getByText(/Quantity: 1/) | ||
| expect(quantityElement).toHaveAttribute('aria-label') | ||
| }) | ||
|
|
||
| test('renders skeleton when product is undefined', () => { | ||
| renderWithIntl(<BonusProductQuantity product={undefined} />) | ||
| // The Skeleton component from Chakra UI renders a div with class "chakra-skeleton" | ||
| expect(document.querySelector('.chakra-skeleton')).toBeInTheDocument() | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if product is
undefined. How about we wrap it in Skeleton component when product is still undefined? https://v2.chakra-ui.com/docs/components/skeletonThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexvuong done