[Generator] cursor rules are now copied for any type of project#2754
Merged
[Generator] cursor rules are now copied for any type of project#2754
Conversation
- Move cursor rules copying logic outside the 'if (extend)' conditional - This ensures .cursor/rules directory is copied for all generated projects - Previously only extended projects received cursor rules configuration - Now all PWA Kit projects get consistent Cursor IDE settings
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
vmarta
commented
Jul 8, 2025
| }) | ||
|
|
||
| // Copy the .cursor/rules directory if it exists | ||
| if (sh.test('-e', CURSOR_RULES_FROM_DIR)) { |
Contributor
Author
There was a problem hiding this comment.
This copying of cursor rules used to be run conditionally.. see line 342 above.
yhsieh1
approved these changes
Jul 8, 2025
Contributor
yhsieh1
left a comment
yhsieh1
left a comment
There was a problem hiding this comment.
It looks good. This change will help with any type of created app.
wei-liu-sf
approved these changes
Jul 8, 2025
kumaravinashcommercecloud
pushed a commit
that referenced
this pull request
Aug 12, 2025
* Move cursor rules copying outside extend block - Move cursor rules copying logic outside the 'if (extend)' conditional - This ensures .cursor/rules directory is copied for all generated projects - Previously only extended projects received cursor rules configuration - Now all PWA Kit projects get consistent Cursor IDE settings * Update CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It used to be that the generator would copy over the cursor rules only if the user chooses extensibility for their project. Now regardless of their selection, we will still copy the cursor rules.
Related PR: #2578
How to test drive the PR
node packages/pwa-kit-create-app/scripts/create-mobify-app-dev.js --outputDir /tmp/generated-projectto generate a new projectusing your own Commerce Cloud instanceand a non-extensible project./.cursor/rules.