@W-18669182 multiship cart support#2784
Conversation
patricksullivansf
added
the
skip changelog
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
packages/template-retail-react-app/app/pages/cart/partials/cart-shipment.jsx
Outdated
Show resolved
Hide resolved
| const isPickupOrder = STORE_LOCATOR_IS_ENABLED | ||
| ? basket?.shipments[0]?.shippingMethod?.c_storePickupEnabled === true | ||
| : false | ||
| const storeId = basket?.shipments?.[0]?.c_fromStoreId |
There was a problem hiding this comment.
When playing around, found a bug with our exisitng BOPIS that could make this buggy - currently, if pick up in store item is added and then removed, when adding a delivery item c_fromStoreId is still filled. I'll try and fix this in my WI.
| import {FormattedMessage} from 'react-intl' | ||
| import {Box, Text} from '@salesforce/retail-react-app/app/components/shared/ui' | ||
| import StoreDisplay from '@salesforce/retail-react-app/app/components/store-display' | ||
|
|
There was a problem hiding this comment.
Not sure if we want to disable it here or above, but guessing we don't want to display this if itemsInShipment is 0. For example - Delivery - 0 out of 1 items not really needed.
There was a problem hiding this comment.
An empty delivery group is supposed to be deleted. There's currently a bug around 'me' but otherwise 0 out of 1 should not happen
| defaultMessage: 'Sorry, there are no locations in this area.' | ||
| }) | ||
| if (hasItemsInBasket) { | ||
| if (storeSelectionDisabled && hasItemsInBasket) { |
There was a problem hiding this comment.
Is there reason to keep the hasItemsInBasket check and its message?
There was a problem hiding this comment.
yes, we still support BOPIS with MULTISHIP_IS_ENABLED false
4 participants
Description
Implements grouping by shipment type on the cart page. one group for each pickup shipment and one group for all delivery shipments.
Adds a combo to switch between shipment groups that moves items from a pickup group to the delivery group, or from the delivery group to a pickup group for the store locator's current store.
Allows store selection in the store locator even when the cart is not empty (it was restricted for BOPIS single shipment mode)
Aside:
Types of Changes
Changes
How to Test-Drive This PR
A test environment for this PR is cc-sparks-patrick
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization