@W-18954259 - [Multiship] Update Order Summary for multiship orders#2788
@W-18954259 - [Multiship] Update Order Summary for multiship orders#2788yunakim714 merged 19 commits intofeature/multishipfrom
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Signed-off-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
yunakim714
added
the
skip changelog
…forceCommerceCloud/pwa-kit into W-18954259-multiship-order-summary
|
Thank you for providing the test link!
|
| import {getCreditCardIcon} from '@salesforce/retail-react-app/app/utils/cc-utils' | ||
| import useNavigation from '@salesforce/retail-react-app/app/hooks/use-navigation' | ||
|
|
||
| // Components |
There was a problem hiding this comment.
grouping comments are a nice touch!
packages/template-retail-react-app/app/pages/checkout/confirmation.jsx
Outdated
Show resolved
Hide resolved
| } | ||
| }, | ||
| { | ||
| enabled: storeIds.length > 0 && onClient |
There was a problem hiding this comment.
oh! onClient tis is a good thing to consider that i haven't paid enough attention to. But in this case why are we restricting to client API only?
There was a problem hiding this comment.
Ack I believe this was a suggestion from Cursor because this pattern is found in some other hooks calls in the retail app - I believe it prevents SSR performance issues? I don't have a strong opinion on whether we should keep this
There was a problem hiding this comment.
i don't think we want to restrict this to client only? unless I'm missing something it should be able to pre-render?
| const pickupShipments = [] | ||
| const deliveryShipments = [] | ||
|
|
||
| order.shipments.forEach((shipment) => { |
There was a problem hiding this comment.
we have almost the same logic in cart. might be able to consolidate into a hook.
patricksullivansf
left a comment
patricksullivansf
left a comment
There was a problem hiding this comment.
LGTM for feature branch
4 participants
Description
When an order has multiple shipments containing both Pickup and Delivery shipping methods, we need to show the details of all shipments on the Order Confirmation page. There can be up to 20 shipments in a single order.
Types of Changes
Changes
multishipdirectory with the new<MultiShipConfirmation>and<MultiShipOrderSummary>components.<MultiShipConfirmation>component displays the pickup and delivery details of all shipments associated with the order<MultiShipOrderSummary>component displays which product items are Pickup and which are DeliveryHow to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization