W 18998603 Route 'Order Status' 'footer link to a new Order Status Page#2795
Conversation
sf-deepali-bharmal
added
the
skip changelog
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
sf-deepali-bharmal
changed the title
|
|
||
| test('renders mobile version by default', () => { | ||
| renderWithProviders(<Footer />) | ||
| // This link is hidden initially, but would be shown for desktop |
There was a problem hiding this comment.
I'm not quite sure I understand this. Is this saying some footer links aren't shown on initial store load?
There was a problem hiding this comment.
Footer shows different links in mobile vs desktop screens.
And mobile is the default/initial option for the app hence it says - mobile view might have few footer links hidden but has more links in desktop view.
There was a problem hiding this comment.
Ah ok, "rendered mobile version by default" was confusing - not sure how that hidden-then-shown part is tested here.
sf-emmyzhang
left a comment
sf-emmyzhang
left a comment
There was a problem hiding this comment.
Nitpick on one of the existing tests for mobile view, but other than that LGTM
| import OrderStatusPage from '@salesforce/retail-react-app/app/pages/order-status/index.jsx' | ||
|
|
||
| describe('OrderStatusPage', () => { | ||
| it('renders the order status page', () => { |
There was a problem hiding this comment.
preferably don't us "it" and i've been told before not to use getByTestId if possible
There was a problem hiding this comment.
My bad. I will take care of this in the next PR.
sf-deepali-bharmal
merged commit ccc0c81
into
feature/order-management-plugin
…ge (#2795) * Initial empty commit for order-management-plugin * Order Status footer link routes to a new Order Status Page
…ge (#2795) * Initial empty commit for order-management-plugin * Order Status footer link routes to a new Order Status Page
…ge (#2795) * Initial empty commit for order-management-plugin * Order Status footer link routes to a new Order Status Page
4 participants
Description
This is an initial PR to add routing from a footer
Order Statuslink to a new page.I will create more PRs to add details in this new page.
UX : https://www.figma.com/proto/FE1DzN6LPFOoP598gymW8U/-258--PWA-Kit-Order-Management-Plugin?page-id=5001%3A55009&node-id=7001-324713&p=f&t=GaZc2PTx5ppuAJGa-0&scaling=min-zoom&content-scaling=fixed&starting-point-node-id=7001%3A299133
Types of Changes
Changes
Order Statusnav link from footer to this pageHow to Test-Drive This PR
Order Statuslink from footerChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization