Skip to content

@W-19263207 [V4 Migration] Support standard product#3007

Merged
sf-jie-dai merged 7 commits intofeature/standard-product-v4from
jdai.W-19263207.supportStandardProductV4
Aug 8, 2025
Merged

@W-19263207 [V4 Migration] Support standard product#3007
sf-jie-dai merged 7 commits intofeature/standard-product-v4from
jdai.W-19263207.supportStandardProductV4

Conversation

@sf-jie-dai
Copy link
Contributor

@sf-jie-dai sf-jie-dai commented Aug 6, 2025 •
edited
Loading

Description

We planned to migrate standard product into v4 in feature/standard-product-v4 feature branch in 5 WIs then merge into next branch, just like this PR: #2697

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

How to Test-Drive This PR

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Aug 6, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

sf-jie-dai
sf-jie-dai commented Aug 6, 2025
View reviewed changes
packages/template-chakra-storefront/src/components/product-view/index.test.js
/>
)

// In Chakra UI v3, when a Button has loading={true}, the button text is hidden with a loading spinner.
Copy link
Contributor Author

@sf-jie-dai sf-jie-dai Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment @unandyala

@sf-jie-dai sf-jie-dai marked this pull request as ready for review August 6, 2025 19:14
@sf-jie-dai sf-jie-dai requested a review from a team as a code owner August 6, 2025 19:14
@sf-jie-dai sf-jie-dai requested a review from sf-emmyzhang August 7, 2025 20:41
patricksullivansf
patricksullivansf reviewed Aug 8, 2025
View reviewed changes
@sf-jie-dai sf-jie-dai added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Aug 8, 2025
@sf-jie-dai sf-jie-dai merged commit dad6546 into feature/standard-product-v4 Aug 8, 2025
33 checks passed
@sf-jie-dai sf-jie-dai deleted the jdai.W-19263207.supportStandardProductV4 branch August 8, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddiazccrz ddiazccrz ddiazccrz approved these changes

@sf-emmyzhang sf-emmyzhang Awaiting requested review from sf-emmyzhang

@patricksullivansf patricksullivansf Awaiting requested review from patricksullivansf

Assignees

No one assigned

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sf-jie-dai @cc-prodsec @ddiazccrz @patricksullivansf @sf-emmyzhang