[E2E][Bugfix] Fix usage for Object.hasOwn#3237
Merged
Conversation
shethj
added
the
skip changelog
Collaborator
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
vmarta
approved these changes
Sep 4, 2025
| }) | ||
|
|
||
| test.skip('should inject B3 headers when __server_timing param is passed', async ({page}) => { | ||
| test('should inject B3 headers when __server_timing param is passed', async ({page}) => { |
Contributor
There was a problem hiding this comment.
I see.. once we enable OTEL, then this test should pass.
Contributor
Author
There was a problem hiding this comment.
I set the env var in the workflow to enable OTEL so the test should pass.
alexvuong
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We updated usage of
hasOwnPropertywithhasOwnto align with latest ECMA updates.The usage in code was buggy as we were calling hasOwn on a plain JSON object while hasOwn is a static method of
Objectin JS. This caused TypeErrors.This PR fixes usage of
hasOwnTypes of Changes
Changes
How to Test-Drive This PR
node e2e/scripts/generate-project.js --project-key retail-app-ext --templateVersion 8.0.0-dev.1node e2e/scripts/validate-generated-project.js retail-app-ext --templateVersion 8.0.0-dev.1Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization