@W-19454052 feat: fix behavior where sometimes shipping options don't auto-summarize#3345
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
patricksullivansf
left a comment
There was a problem hiding this comment.
While i suspect this approach is functionally correct it bothers me that it duplicates the idea of the logic in this updateShipmentsWithoutMethods hook. Is there anyway to leverage that?
also the other flow assigns the default methods before reaching this merged selection partial. Since the gap we’re trifling to fill here is to catch shipments that are belatedly added during the previous multi ship step, is it possible to catch these cases there?
I’m not blocking this solution, just want to make s sure we’ve fully investigated the alternatives
@patricksullivansf I have tried some other approaches - unified hook for both cart and checkout (race condition in checkout), or bake |
shauryemahajanSF
left a comment
There was a problem hiding this comment.
PR looks good to me, but there a flakey unit test, worth looking looking into
test(�[32m'Can add address during checkout as a registered
Description
Fixed shipping method section expanding unnecessarily when default options are auto-selected. The section now remains collapsed (summary mode) when all shipments have valid shipping methods, improving the checkout user experience. Default shipping methods are automatically submitted to the basket when available, while preserving manual user selections.
demo video:
short_video.mov
Types of Changes
Changes
How to Test-Drive This PR
✅ Expected - Shipping method section stays collapsed (summary mode) with default method auto-selected
❌ Previous - Shipping method section expanded (edit mode) even with default selected
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization