Skip to content

@W-19649984 - Move Config.js#3346

Merged
shauryemahajanSF merged 2 commits into3.13.0-preview.5from
t/commerce/W-19649984/moveConfigjs
Sep 23, 2025
Merged

@W-19649984 - Move Config.js#3346
shauryemahajanSF merged 2 commits into3.13.0-preview.5from
t/commerce/W-19649984/moveConfigjs

Conversation

@shauryemahajanSF
Copy link
Contributor

@shauryemahajanSF shauryemahajanSF commented Sep 23, 2025

Description

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@shauryemahajanSF shauryemahajanSF requested a review from a team as a code owner September 23, 2025 19:30
@shauryemahajanSF shauryemahajanSF added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Sep 23, 2025
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Sep 23, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link
Contributor

@snilakandan13 snilakandan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@patricksullivansf patricksullivansf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we confirmed the rest of the build script properly handles json files? If not a shorter path might be to just move the configuration string into the js file like we originally had

@shauryemahajanSF
Copy link
Contributor Author

Have we confirmed the rest of the build script properly handles json files? If not a shorter path might be to just move the configuration string into the js file like we originally had

We used npm run build/start and it seems to work properly, before this, the config.js wasn't being added into the npm package.

@shauryemahajanSF shauryemahajanSF merged commit 8cd65b0 into 3.13.0-preview.5 Sep 23, 2025
42 checks passed
@shauryemahajanSF shauryemahajanSF deleted the t/commerce/W-19649984/moveConfigjs branch September 23, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants