Einstein suggestion phrases in search

.cursor/qa/rules/packages/template-retail-react-app/testing/retail-react-app-test-patterns.mdc

@@ -0,0 +1,59 @@
+---
+description: QA Tests for Template Retail React App Test Generation Rules
+globs: ["packages/template-retail-react-app/app/components/**/*-underTest.test.{js,jsx}"]
+alwaysApply: false
+---
+# QA Tests for Template Retail React App Test Patterns
+
+## Purpose
+This file contains test cases to verify that the `unit-tests-template-retail-react-app.mdc` rule effectively guides the creation of consistent and robust React component tests.
+
+## Test Cases
+
+### Test 1: DrawerMenu Component Test Generation
+**Workflow:** Generate → Analyze → Cleanup (NO test execution)
+
+**Steps:**
+1. **Generate:** Create new test file `drawer-menu-underTest.test.js` (colocated with existing drawer-menu component at `packages/template-retail-react-app/app/components/drawer-menu/`)
+2. **Apply Rules:** Use `@/testing` (located at `.cursor/rules/testing/unit-tests-generic.mdc` and `.cursor/rules/testing/unit-tests-template-retail-react-app.mdc`)
+3. **Prompt:** "Write unit test for drawer-menu component"
+4. **Analyze:** Perform static code analysis against verification patterns (see below)
+5. **Cleanup:** Delete the generated test file after validation
+
+**Important:** DO NOT run the test after creation - skip test execution entirely
+
+**Verify that the newly generated test file follows these patterns:**
+1. Test Setup
+   - Uses `renderWithProviders` from `@salesforce/retail-react-app/app/utils/test-utils`
+   - Gets user events from return value: `const {user} = renderWithProviders(...)`
+   - Includes `beforeEach(() => jest.clearAllMocks())`
+
+2. Import Structure
+   - Does NOT import `userEvent` directly
+   - Uses existing mock data from `@salesforce/retail-react-app/app/mocks/`
+   - Imports `screen` from `@testing-library/react`
+
+3. Test Organization
+   - Uses `describe` block with component name
+   - Individual `test` or `it` blocks for different scenarios
+   - Async/await patterns for user interactions
+
+4. API Mocking
+   - Uses `prependHandlersToServer` or `msw` for API mocking when needed
+
+**Failure Indicators:**
+- Direct import of `userEvent` from `@testing-library/user-event`
+- Using custom render function instead of `renderWithProviders`
+- Creating new mock data instead of using existing mocks
+- Missing Commerce SDK context providers
+- Not using async/await for user interactions
+
+**Expected Output:**
+Provide a clear, structured report based on **static code analysis only** (no test execution):
+- ✅ **PASS** or ❌ **FAIL** for each verification point
+- Specific line numbers and code snippets for any failures
+- Summary: `X/Y patterns followed correctly`
+- Overall result: **RULES EFFECTIVE** or **RULES NEED IMPROVEMENT**
+
+**Cleanup:**
+- Delete the generated test file `drawer-menu-underTest.test.js` after QA validation is complete

.github/CODEOWNERS

@@ -1,9 +1,64 @@
 # https://help.github.com/en/enterprise/2.17/user/articles/about-code-owners
 
-# These owners will be the default owners for everything in
-# the repo. Unless a later match takes precedence,
-# @global-owner1 and @global-owner2 will be requested for
-# review when someone opens a pull request.
+# Global directories
+.cursor/                                                    @SalesforceCommerceCloud/mobifyers
+.github/                                                    @SalesforceCommerceCloud/mobifyers
+e2e/                                                        @SalesforceCommerceCloud/mobifyers
+scripts/                                                    @SalesforceCommerceCloud/mobifyers
+
+# Package-specific ownership
+packages/commerce-sdk-react/                               @SalesforceCommerceCloud/mobifyers
+packages/internal-lib-build/                               @SalesforceCommerceCloud/mobifyers
+packages/pwa-kit-create-app/                               @SalesforceCommerceCloud/mobifyers
+packages/pwa-kit-dev/                                      @SalesforceCommerceCloud/mobifyers
+packages/pwa-kit-mcp/                                      @SalesforceCommerceCloud/mobifyers
+packages/pwa-kit-react-sdk/                                @SalesforceCommerceCloud/mobifyers
+packages/pwa-kit-runtime/                                  @SalesforceCommerceCloud/mobifyers
+packages/template-express-minimal/                         @SalesforceCommerceCloud/mobifyers
+packages/template-mrt-reference-app/                       @SalesforceCommerceCloud/mobifyers
+packages/template-retail-react-app/                        @SalesforceCommerceCloud/mobifyers
+packages/template-typescript-minimal/                      @SalesforceCommerceCloud/mobifyers
+packages/test-commerce-sdk-react/                          @SalesforceCommerceCloud/mobifyers
+
+# Root configuration and documentation files
+/README.md                                                  @SalesforceCommerceCloud/mobifyers
+/CODE_OF_CONDUCT.md                                         @SalesforceCommerceCloud/mobifyers
+/CONTRIBUTING.md                                            @SalesforceCommerceCloud/mobifyers
+/SECURITY.md                                                @SalesforceCommerceCloud/mobifyers
+/STATEMENTS.md                                              @SalesforceCommerceCloud/mobifyers
+/TERMS_OF_USE.md                                            @SalesforceCommerceCloud/mobifyers
+/LICENSE                                                    @SalesforceCommerceCloud/mobifyers
+/.eslintrc.js                                              @SalesforceCommerceCloud/mobifyers
+/.gitattributes                                            @SalesforceCommerceCloud/mobifyers
+/.gitignore                                                @SalesforceCommerceCloud/mobifyers
+/.prettierignore                                           @SalesforceCommerceCloud/mobifyers
+/.prettierrc.yaml                                          @SalesforceCommerceCloud/mobifyers
+/lerna.json                                                @SalesforceCommerceCloud/mobifyers
+/package.json                                              @SalesforceCommerceCloud/mobifyers
+/package-lock.json                                         @SalesforceCommerceCloud/mobifyers
+/playwright.config.js                                      @SalesforceCommerceCloud/mobifyers
+/.git2gus/                                                 @SalesforceCommerceCloud/mobifyers
+
+# Specific feature file ownership (overrides package-level rules above)
+
+# BOPIS (Buy Online Pick up In Store) feature files - PR #2646
+packages/template-retail-react-app/app/components/store-display/ @SalesforceCommerceCloud/cc-spark
+packages/template-retail-react-app/app/hooks/use-selected-store.js @SalesforceCommerceCloud/cc-spark
+packages/template-retail-react-app/app/hooks/use-pickup-shipment.js @SalesforceCommerceCloud/cc-spark
+packages/template-retail-react-app/app/hooks/use-pickup-shipment.test.js @SalesforceCommerceCloud/cc-spark
+e2e/tests/desktop/bopis.spec.js @SalesforceCommerceCloud/cc-spark
+
+# Bonus Products feature files - PR #2704
+packages/template-retail-react-app/app/components/product-item/bonus-product-quantity.jsx @SalesforceCommerceCloud/cc-sharks
+packages/template-retail-react-app/app/components/product-item/bonus-product-quantity.test.jsx @SalesforceCommerceCloud/cc-sharks
+packages/template-retail-react-app/app/components/product-item/product-quantity-picker.jsx @SalesforceCommerceCloud/cc-sharks
+packages/template-retail-react-app/app/components/product-item/product-quantity-picker.test.jsx @SalesforceCommerceCloud/cc-sharks
+packages/template-retail-react-app/app/pages/cart/partials/bonus-products-title.jsx @SalesforceCommerceCloud/cc-sharks
+packages/template-retail-react-app/app/pages/cart/partials/bonus-products-title.test.js @SalesforceCommerceCloud/cc-sharks
+
+# Standard Products feature files - PR #2697
+packages/template-retail-react-app/app/mocks/standard-product.js @SalesforceCommerceCloud/cc-sharks
+packages/template-retail-react-app/app/utils/add-to-cart-utils.js @SalesforceCommerceCloud/cc-sharks
+
 
-*       @SalesforceCommerceCloud/mobifyers
 #ECCN:Open Source

.github/actions/count_deps/action.yml

@@ -1,12 +1,16 @@
 name: count_deps
+inputs:
+  project_dir:
+    description: 'Path to the project directory'
+    required: true
 runs:
   using: composite
   steps:
   - name: Count Generated Project Dependencies
     # TODO: Can TOTAL_PACKAGES be exported in a cleaner way?
     run: |-
       MAX_PACKAGES="2260"
-      total=$(./scripts/count-dependencies.js generated-${{ matrix.template }})
+      total=$(./scripts/count-dependencies.js "${{ inputs.project_dir }}")
       echo "TOTAL_PACKAGES=${total}" >> $GITHUB_ENV
 
       if [ "$total" -gt "$MAX_PACKAGES" ]; then

.github/actions/e2e_acquire_mrt_target/action.yml

@@ -0,0 +1,36 @@
+name: e2e_acquire_mrt_target
+description: Acquire MRT Target from pool of available targets in the MRT staging org.
+inputs:
+    BRANCH:
+        description: 'GitHub branch name from workflow invoking this action'
+        required: false
+    RUN_ID:
+        description: 'GitHub workflow run ID from workflow invoking this action'
+        required: true
+    PR_NUMBER:
+        description: 'GitHub PR number from workflow invoking this action'
+        required: false
+    MAX_RETRIES:
+        description: 'Maximum retry attempts to acquire MRT target'
+        required: false
+        default: '3'
+    RETRY_DELAY:
+        description: 'Delay between retries in milliseconds'
+        required: false
+        default: '10000'
+
+runs:
+    using: composite
+    steps:
+        - name: Acquire MRT Target
+          id: acquire_mrt_target
+          shell: bash
+          run: |-
+              set -e
+              cmd="node e2e/scripts/mrt-target-manager.js acquire --run-id ${{inputs.RUN_ID}} --max-retries ${{inputs.MAX_RETRIES}} --retry-delay ${{inputs.RETRY_DELAY}}"
+              if [ -n "${{inputs.PR_NUMBER}}" ]; then
+                cmd="$cmd --pr-number ${{inputs.PR_NUMBER}}"
+              elif [ -n "${{inputs.BRANCH}}" ]; then
+                cmd="$cmd --branch ${{inputs.BRANCH}}"
+              fi
+              eval $cmd

.github/actions/e2e_generate_app/action.yml

@@ -10,14 +10,24 @@ inputs:
     required: false
     type: string
 
+outputs:
+  project_path:
+    description: Path to the generated project directory
+    value: ${{ steps.generate_project.outputs.project_path }}
+
 runs:
   using: composite
   steps:
   - name: Generate new project based on project-key
+    id: generate_project
     run: |
       COMMAND="node e2e/scripts/generate-project.js --project-key ${{ inputs.PROJECT_KEY }}"
       if [[ -n "${{ inputs.TEMPLATE_VERSION }}" ]]; then
         COMMAND="$COMMAND --templateVersion ${{ inputs.TEMPLATE_VERSION }}"
       fi
       $COMMAND
+
+      # Return path to the generated project
+      GENERATED_PROJECTS_DIR=$(node -e "console.log(require('./e2e/config.js').GENERATED_PROJECTS_DIR)")
+      echo "project_path=$GENERATED_PROJECTS_DIR/${{ inputs.PROJECT_KEY }}" >> $GITHUB_OUTPUT
     shell: bash

.github/actions/e2e_release_mrt_target/action.yml

@@ -0,0 +1,20 @@
+name: e2e_release_mrt_target
+description: Release MRT Target back to pool of available targets in the MRT staging org.
+inputs:
+    SLUG:
+        description: 'MRT target slug'
+        required: true
+    MAX_RETRIES:
+        description: 'Maximum retry attempts to release MRT target'
+        required: false
+        default: '3'
+    RETRY_DELAY:
+        description: 'Delay between retries in milliseconds'
+        required: false
+        default: '10000'
+
+runs:
+    using: node20 # Only 'node12', 'node16', 'node20' or 'node24' are supported.
+    main: dist/main.js
+    post: dist/post.js
+    post-if: always()

.github/actions/e2e_release_mrt_target/dist/main.js

@@ -0,0 +1,22 @@
+/*
+ * Copyright (c) 2025, Salesforce, Inc.
+ * All rights reserved.
+ * SPDX-License-Identifier: BSD-3-Clause
+ * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/BSD-3-Clause
+ */
+
+/**
+ * @file main.js
+ * @description Arms the post-release cleanup for MRT targets in CI. 
+ *
+ * Intentionally empty. This file just needs to exist. Post step will read INPUT_DETAILS_FILE and perform release.
+ * 
+ * Why:
+ * - GitHub Actions post steps execute even when a job fails or is manually cancelled,
+ *   providing best-effort cleanup of leased resources.
+ * - Keeping the actual release in post.js avoids releasing too early while the job
+ *   is still running and centralizes all teardown logic at job end.
+ *
+ * See also:
+ * - post.js (performs the actual release using the saved inputs)
+ */

.github/actions/e2e_release_mrt_target/dist/post.js

@@ -0,0 +1,48 @@
+/*
+ * Copyright (c) 2025, Salesforce, Inc.
+ * All rights reserved.
+ * SPDX-License-Identifier: BSD-3-Clause
+ * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/BSD-3-Clause
+ */
+
+/**
+ * @file post.js
+ * @description Performs the actual release of the MRT target back to the pool of available targets in the MRT staging org.
+ * This step is executed even when a job fails or is manually cancelled, providing best-effort cleanup of leased resources.
+ * This step is executed after the main step in the workflow.
+ */
+const fs = require('fs')
+const path = require('path')
+const {spawnSync} = require('child_process')
+const config = require('../../../../e2e/config.js')
+
+;(async () => {
+    try {
+        const workspace = process.env.GITHUB_WORKSPACE || process.cwd()
+        const detailsFile = config.MRT_TARGET_DETAILS_FILE
+        const absDetails = path.resolve(workspace, detailsFile)
+        console.log(`Reading MRT target details from ${absDetails}`)
+        if (!fs.existsSync(absDetails)) {
+            console.log(`No details file at ${absDetails}. Skipping release.`)
+            return
+        }
+
+        const details = JSON.parse(fs.readFileSync(absDetails, 'utf8'))
+        console.log(`Details: ${JSON.stringify(details)}`)
+        const slug = details && details.slug
+        if (!slug) {
+            console.log('No slug found in details file. Skipping release.')
+            return
+        }
+
+        const cli = path.resolve(workspace, 'e2e/scripts/mrt-target-manager.js')
+        console.log(`Releasing MRT target: ${slug}`)
+        const res = spawnSync('node', [cli, 'release', slug], {stdio: 'inherit', cwd: workspace})
+
+        if (res.status !== 0) {
+            console.log(`Release exited with status ${res.status}.`)
+        }
+    } catch (e) {
+        console.log(`Release step error: ${e.message}`)
+    }
+})()

.github/actions/e2e_validate_generated_app/action.yml

@@ -14,9 +14,21 @@ runs:
   steps:
   - name: Validate generated project
     run: |
-      COMMAND="node e2e/scripts/validate-generated-project.js ${{ inputs.PROJECT_KEY }}"
+      set -euo pipefail
+
+      COMMAND=(node e2e/scripts/validate-generated-project.js "${{ inputs.PROJECT_KEY }}")
+
       if [[ -n "${{ inputs.TEMPLATE_VERSION }}" ]]; then
-        COMMAND="$COMMAND --templateVersion ${{ inputs.TEMPLATE_VERSION }}"
+        COMMAND+=(--templateVersion "${{ inputs.TEMPLATE_VERSION }}")
       fi
-      $COMMAND
+
+      echo "Executing command: ${COMMAND[*]}"
+
+      if ! "${COMMAND[@]}"; then
+        echo "❌ Node.js validation script failed with exit code $?"
+        echo "::error::Validation of generated project failed"
+        exit 1
+      fi
+
+      echo "✅ Project validation completed successfully"
     shell: bash

.github/actions/generate_app/action.yml

@@ -22,6 +22,11 @@ inputs:
   project_dir:
     description: Project Directory
 
+outputs:
+  project_path:
+    description: Path to the generated project directory
+    value: ${{ steps.generate_project.outputs.project_path }}
+
 runs:
   using: composite
   steps:
@@ -31,20 +36,20 @@ runs:
       run: |
         use_extensibility_input="${{ inputs.use_extensibility }}"
         if [ "use_extensibility_input" = "true" ]; then
-         use_extensibility_value=2
-        else
          use_extensibility_value=1
+        else
+         use_extensibility_value=2
         fi
-        echo "USE_EXTENSIBILITY_VALUE=$use_extensibility_value" >> $GITHUB_ENV 
-        
+        echo "USE_EXTENSIBILITY_VALUE=$use_extensibility_value" >> $GITHUB_ENV
+
         is_private_client_input="${{ inputs.is_private_client }}"
         if [ "$is_private_client_input" = "true" ]; then
          is_private_client_value=1
         else
           is_private_client_value=2
         fi
         echo "IS_PRIVATE_CLIENT_VALUE=$is_private_client_value" >> $GITHUB_ENV
-        
+
         setup_hybrid_input="${{ inputs.setup_hybrid }}"
         if [ "$setup_hybrid_input" = "true" ]; then
           setup_hybrid_value=2
@@ -53,6 +58,8 @@ runs:
         fi
         echo "SETUP_HYBRID_VALUE=$setup_hybrid_value" >> $GITHUB_ENV
 
+    # TODO: update this to use the standard input feature that Ben created recently
+    # TODO: this action does not finish successfully because of a dirty-workspace error, due to creating this generator-responses.json
     - name: Build project generator inputs
       id: build_generator_inputs
       shell: bash
@@ -107,11 +114,16 @@ runs:
       run: |
         cat generator-responses.json
         node e2e/scripts/generate-project.js --project-config "$(jq -c . generator-responses.json)"
+
+        # Return path to the generated project
+        GENERATED_PROJECTS_DIR=$(node -e "console.log(require('./e2e/config.js').GENERATED_PROJECTS_DIR)")
+        echo "project_path=$GENERATED_PROJECTS_DIR/${{ inputs.project_dir }}" >> $GITHUB_OUTPUT
       shell: bash
 
+    # TODO: I think we can safely delete this step. We already install the dependencies in the previous step.
     - name: Build generated project
       id: build_generated_project
-      working-directory: ../generated-projects/${{ inputs.project_dir }}
+      working-directory: ${{ steps.generate_project.outputs.project_path }}
       run: |-
         npm ci
         npm run build