update feature branch bonus-products-rule-based-v3 with develop branch#3406
Merged
sf-shikhar-prasoon merged 20 commits intofeature/bonus-products-rule-based-v3from Oct 17, 2025
Merged
update feature branch bonus-products-rule-based-v3 with develop branch#3406sf-shikhar-prasoon merged 20 commits intofeature/bonus-products-rule-based-v3from
bonus-products-rule-based-v3 with develop branch#3406sf-shikhar-prasoon merged 20 commits intofeature/bonus-products-rule-based-v3from
Conversation
- Change "Be the first to know" heading from h1 to h2 for proper semantic hierarchy - Add responsive paddingTop to subscribeHeading (desktop: 3, mobile: 0) to align with other footer grid headings on desktop while maintaining clean positioning on mobile The h1 usage was semantically incorrect as footer sections should be h2 level, and the padding ensures visual alignment with LinksList headings in the 4-column desktop grid layout.
… pages to resolve the page-has-heading-one accessibility rule violation.
- Regenerated compiled translation files to include new h1 heading keys - Ensures all accessibility translation keys are available at runtime - Resolves Lerna EUNCOMMIT error for publishing
- Updated source translation files (en-US, en-GB) with extracted default messages - Regenerated pseudo-locale (en-XA) with new accessibility keys - Ensures all translation files are in sync for Lerna publishing - Resolves remaining EUNCOMMIT errors
…bility Improve E2E stability
- Fix DNT test selector to target button instead of heading role
The test was failing due to strict mode violation where multiple
'My Account' headings existed (h1 on page + h2 in accordion).
Changed selector from getByRole('heading') to getByRole('button')
to specifically target the accordion button.
- Add h1 heading to Product Listing Page for accessibility
Changed page header from h2 to h1 to ensure PLP has proper
semantic heading structure and resolves page-has-heading-one
violation for both mobile and desktop a11y tests.
- Update checkout a11y snapshots to reflect h1 heading fix
The checkout page now has proper h1 heading (fixed elsewhere),
so removed page-has-heading-one violation from test snapshots
for both guest and registered user flows.
Fixes test failures:
- [mobile-chrome] dnt.spec.js - Shopper can use consent tracking form
- [a11y-mobile-slas-private-client] PLP accessibility tests
- [a11y-desktop-slas-private-client] PLP accessibility tests
- [a11y-desktop-slas-private-client] Checkout accessibility tests (guest + registered)
- Make DNT test selector more specific by targeting 'My Account chevron-down' to uniquely identify the accordion button and avoid matching the header icon button - Update checkout step-1 accessibility snapshots for guest and registered users to remove page-has-heading-one violation (checkout now has proper h1 heading)
- Update guest checkout step-3 snapshot to remove page-has-heading-one violation - Update registered checkout step-2 and step-3 snapshots - Update guest checkout step-4-order-confirmation snapshot All checkout steps now properly reflect that pages have h1 headings.
- Fixed 3 failing login tests where 'Sign In' text matched both h1 heading and button
- Changed from getByText(/sign in/i) to getByRole('button', {name: /sign in/i})
- Follows same pattern as DNT test fix for specificity
- Updated use-auth-modal test to expect 3 'My Account' headings (was 2) - Updated registration test to expect 3 'My Account' headings (was 2) - Fixed registration test button selector to use getByRole for specificity - Account page now has h1 (sr-only), h2 (accordion), and h2 (sidebar)
…9721000 Fix footer heading semantic consistency and alignment
…3405) * implement fix * update changelog * lint
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
ddiazccrz
approved these changes
Oct 17, 2025
sf-shikhar-prasoon
merged commit 82e2550
into
feature/bonus-products-rule-based-v3
114 of 116 checks passed
jeremy-jung1
temporarily deployed
to
extra-features-e2e
GitHub Actions
Inactive
jeremy-jung1
temporarily deployed
to
extra-features-e2e
GitHub Actions
Inactive
jeremy-jung1
had a problem deploying
to
extra-features-e2e
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
update feature branch
bonus-products-rule-based-v3with develop branchTypes of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization