@W-20002879 Register guest save addresses is multi-ship aware#3412
Merged
patricksullivansf merged 4 commits intodevelopfrom Oct 21, 2025
Merged
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| }) | ||
| }) | ||
|
|
||
| test('does not save pickup addresses when store locator is enabled', async () => { |
Contributor
There was a problem hiding this comment.
does it make more sense to also have a test that only "delivery" addresses are saved in the user’s address book? It is kind of inferred here though
Contributor
Author
There was a problem hiding this comment.
Thanks, renamed the test to be more clear
shauryemahajanSF
approved these changes
Oct 21, 2025
yhsieh1
reviewed
Oct 21, 2025
| const {id, _type, ...shippingAddressWithoutId} = shippingAddress | ||
| const bodyShippingAddress = { | ||
| addressId: nanoid(), | ||
| ...shippingAddressWithoutId |
Contributor
There was a problem hiding this comment.
nit: ...omit(shippingAddress, ['id', '_type'])
yhsieh1
approved these changes
Oct 21, 2025
wei-liu-sf
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a guest user completes checkout they have the option to create an account on the order confirmation page. The new account should have all the delivery shipping addresses and none of the pick up in store addresses from the newly created guest order.
Before this fix, only the first shipment address was saved and if it wad a pick-up order the store address was incorrectly saved as the customer address.
Types of Changes
Changes
How to Test-Drive This PR
Steps to reproduce:
Observe no store addresses are saved and other 2 addresses are saved
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization