Skip to content

@W-19990736 render salesforce payments paypal#3415

Merged
alafemina merged 2 commits intot/team404/sfp-on-pwafrom
sfp-paypal-on-pwa
Oct 22, 2025
Merged

@W-19990736 render salesforce payments paypal#3415
alafemina merged 2 commits intot/team404/sfp-on-pwafrom
sfp-paypal-on-pwa

Conversation

@alafemina
Copy link
Collaborator

@alafemina alafemina commented Oct 22, 2025

Description

Updates to render paypal buttons in checkout payment sheet and express on checkout, cart, mini cart, PDP. Also generalized the useShopperConfigurations hooks.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • (change1)

How to Test-Drive This PR

  • (step1)

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@alafemina alafemina requested a review from a team as a code owner October 22, 2025 13:14
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Oct 22, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Licenses 0 0 0 0 0 issues
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@alafemina alafemina requested review from jeffraab-sfdc and removed request for a team October 22, 2025 13:23
const storeName = selectedStore?.name
const inventoryId = selectedStore?.inventoryId
const sfPaymentsEnabled = useSalesforcePayments()
const sfPaymentsEnabled = useShopperConfiguration('SalesforcePaymentsAllowed') === true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put this useShopperConfiguration('SalesforcePaymentsAllowed') === true check in a place where it doesn't have to be duplicated? For example if a thing is already importing useSalesforcePayments could that hook result include an enabled property?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took a note to address this in my next iteration

@alafemina alafemina merged commit ad86d94 into t/team404/sfp-on-pwa Oct 22, 2025
8 of 16 checks passed
@alafemina alafemina deleted the sfp-paypal-on-pwa branch October 22, 2025 14:36
rasbhat pushed a commit that referenced this pull request Mar 5, 2026
* render paypal

* refactor shopper config checker
rasbhat pushed a commit that referenced this pull request Mar 5, 2026
* render paypal

* refactor shopper config checker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants