@W-20398991 - Forgot Password link not working from Account Profile password update form#3493
Merged
giridhari-gupta merged 2 commits intodevelopfrom Dec 5, 2025
Merged
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
adamraya
reviewed
Dec 5, 2025
| @@ -1,4 +1,5 @@ | |||
| ## v8.3.0-dev (Nov 05, 2025) | |||
| - [Bugfix] Fix Forgot Password link not working from Account Profile password update form [#3487](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3487) | |||
Contributor
There was a problem hiding this comment.
nit: updated PR number in changelog
Suggested change
| - [Bugfix] Fix Forgot Password link not working from Account Profile password update form [#3487](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3487) | |
| - [Bugfix] Fix Forgot Password link not working from Account Profile password update form [#3493](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/3493) |
Also, Should we close PR #3487 as a duplicate?
| /> | ||
| </Button> | ||
| </Box> | ||
| {handleForgotPasswordClick && ( |
Contributor
There was a problem hiding this comment.
We could consider adding small tests covering the new branching logic, E.g. it does not render Forgot Password button when handleForgotPasswordClick is not provided, and clicking the Forgot Password calls handleForgotPasswordClick, etc.
Contributor
There was a problem hiding this comment.
I agree can we get a little bit of test created around this
Contributor
Author
There was a problem hiding this comment.
I have added unit test cases.
Closed
12 tasks
adamraya
approved these changes
Dec 5, 2025
bfeister
approved these changes
Dec 5, 2025
fix(account): Correct "Forgot Password" link behavior The link within the `UpdatePasswordFields` component, which is intended to navigate to `/reset-password`, was not working when accessed from the main Account Profile page (`/account`). This change ensures that clicking the link bypasses any potential form submission or event propagation interference, allowing the user to navigate to the password reset flow as expected. Fixes #3486
- Added Unit test cases to code coverage.
6a30e72 to
3495a3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix(account): Correct "Forgot Password" link behavior
The link within the
UpdatePasswordFieldscomponent, which is intended to navigate to/reset-password, was not working when accessed from the main Account Profile page (/account).This change ensures that clicking the link allowing the user to navigate to the password reset flow as expected.
Fixes #3486
Screen.Recording.2025-12-03.at.3.04.49.PM.mov
Types of Changes
Changes
Files involved:
packages/template-retail-react-app/app/pages/account/index.jsx(line 234 - passeshandleForgotPasswordClickprop)packages/template-retail-react-app/app/pages/account/profile.jsx(line 367 - receives and passes prop toPasswordCard)packages/template-retail-react-app/app/components/forms/update-password-fields.jsx(line 34 - button with onClick handler)Code reference:
The
handleForgotPasswordClickprop is defined inapp/pages/account/index.jsx:avascriptAnd is used in
app/components/forms/update-password-fields.jsx:scriptNote: The same pattern works correctly on the login page (
/login), where the "Forgot password?" link successfully navigates to/reset-password. This suggests the issue may be specific to the account profile context or form submission interference.How to Test-Drive This PR
Screen.Recording.2025-12-03.at.2.53.36.PM.mov
Sandbox Deployment: https://cc-pulse-giri-testing-space.sfdc-3vx9f4-commerceecom.exp-delivery-staging.com/
/account)/reset-passwordwill work now.Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization