Skip to content

@W-20223950 - Add config for passkey login#3497

Merged
yunakim714 merged 5 commits intofeature/webauthn-loginfrom
W-20223950-add-config-passkey-login
Dec 8, 2025
Merged

@W-20223950 - Add config for passkey login#3497
yunakim714 merged 5 commits intofeature/webauthn-loginfrom
W-20223950-add-config-passkey-login

Conversation

@yunakim714
Copy link
Collaborator

@yunakim714 yunakim714 commented Dec 8, 2025

Description

This PR adds a feature flag for passkey login that is disabled by default. This feature flag will be located in the config file, where the merchant can configure the callback URI to send the OTP during passkey registration.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • Add a new passkey config key within the login config with enabled and callbackURI fields

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

@yunakim714 yunakim714 requested a review from a team as a code owner December 8, 2025 15:21
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Dec 8, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@yunakim714 yunakim714 changed the base branch from develop to feature/webauthn-login December 8, 2025 15:24
@yunakim714 yunakim714 added the skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated label Dec 8, 2025
@yunakim714 yunakim714 merged commit df2cdc0 into feature/webauthn-login Dec 8, 2025
42 checks passed
@yunakim714 yunakim714 deleted the W-20223950-add-config-passkey-login branch December 8, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog Skip the "Changelog Check" GitHub Actions step even if the Changelog.md files are not updated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants