W-20504299: refactor of clientSecret(Stripe) and shippingPreference(PayPal)

[sf-mkosak]

The API's were changed in a way where any properties specific to a particular payment gateway will be embedded in a new API req/resp object called gatewayProperties.

PATCH /orders/{id}/payment-instruments/{id} response payload with Stripe for example

{
  paymentReference: {
    gatewayProperties: {
       stripe: {
           clientSecret: 'secret'
       }
    }
}

PayPal request payload

{
  paymentReferenceRequest: {
    gatewayProperties: {
       paypal: {
           shippingPreference: '...'
       }
    }
}

Description

Types of Changes

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Documentation update
• Breaking change (could cause existing functionality to not work as expected)
• Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

• Removing a public function or component or prop
• Adding a required argument to a function
• Changing the data type of a function parameter or return value
• Adding a new peer dependency to package.json

Changes

• (change1)

How to Test-Drive This PR

• (step1)

Checklists

General

• Changes are covered by test cases
• CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

• There are no changes to UI

or...

• Changes were tested with a Screen Reader (iOS VoiceOver or Android Talkback) and had no issues
• Changes comply with WCAG 2.0 guidelines levels A and AA
• Changes to common UI patterns and interactions comply with WAI-ARIA best practices

Localization

• Changes include a UI text update in the Retail React App (which requires translation)

[cc-prodsec]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[sf-mkosak]

This is obviously very stripe specific. I dont think the branch supports Adyen in any way yet but keep me honest

[amittapalli]

I actually addressed this in my PR since it was blocking me testing the fail order if I didn't. I created a separate util function so that we can add gateway specific logic the instead

[amittapalli]

I actually addressed this in my PR since it was blocking me testing the fail order if I didn't.