Skip to content

@W-20540715 MERGE 1CC TO DEVELOP#3552

Merged
syadupathi-sf merged 39 commits intodevelopfrom
feature/1cc_merge
Feb 2, 2026
Merged

@W-20540715 MERGE 1CC TO DEVELOP#3552
syadupathi-sf merged 39 commits intodevelopfrom
feature/1cc_merge

Conversation

@syadupathi-sf
Copy link
Collaborator

@syadupathi-sf syadupathi-sf commented Dec 30, 2025 •
edited by vmarta
Loading

Description

One click checkout with passwordless OTP login
Demo: https://drive.google.com/file/d/1n1z0Qiy1NGPTiSMNYuNwDOTWHMuqxr13/view
Epic: https://gus.lightning.force.com/lightning/_classic/%2Fa3QEE000001rZzx2AE
HLD: https://docs.google.com/document/d/1qV1CVhtWWUGv_Q5On--PjohkNhDInUdUkqN-H4_VgE8/edit?tab=t.0#heading=h.pr8srykhn2xj
1Pager: https://docs.google.com/document/d/16njWYWOOhQuVRALryhhb_c1umrbk_O5nRRPmnCAmMe8/edit?tab=t.0#heading=h.ai6sqcu8tvi1
Spike: https://docs.google.com/document/d/18ZlH17FSn6WZ8oYuLwkF77F4_Ojq5rj8Dueqs4lqlyU/edit?tab=t.0#heading=h.w655bh7w26r4
MRT with 1CC ON: https://ecom-1cc-poc-bugbash-jan26.sfdc-8tgtt5-ecom1.exp-delivery.com/
MRT with 1CC OFF: https://ecom-1cc-poc-1cc-off.sfdc-8tgtt5-ecom1.exp-delivery.com/
Setup doc: https://docs.google.com/document/d/1JpKCMRiQScYiWw4sxzBNa1HwdW7kzmVNZs7yTnRfagY/edit?pli=1&tab=t.0#heading=h.rd1jx4z8inoh
History of commits: #3391

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Changes

  • One click checkout has a feature switch, which is defaulted to true.
  • Private SLAS client has to be setup and related configurations have to be setup in PWA kit as a pre-requisite
  • SLAS Passwordless login is used with native email support to get OTP in the email in returning shopper(registered shopper) and new user registration flows (see demo link in the desc)
  • Separate page and partials for one click checkout is maintained to reduce friction with regular checkout

How to Test-Drive This PR

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@syadupathi-sf syadupathi-sf requested review from a team as code owners December 30, 2025 20:23
@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Dec 30, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@syadupathi-sf syadupathi-sf changed the title @W-20540715 DRAFT PR TO MERGE 1CC TO DEVELOP - DOES NOT NEED REVIEW RIGHT NOW @W-20540715 MERGE 1CC TO DEVELOP Jan 8, 2026
@yunakim714 yunakim714 mentioned this pull request Jan 13, 2026
Merged
12 tasks
@syadupathi-sf
W-20892453 Remove store pickup shipping option (#3575)
8fd1ab2
@syadupathi-sf
@W-20892497 Show Phone number in Contact Info summary (#3576)
81973db 
* W-20892497 Show Phone number in Contact Info summary

* fix lint
@syadupathi-sf
@W-20892554 Show spinner when user registration checkbox is clicked (#…
128ccd5 
…3578)

* W-20892554 Show spinner when user registration checkbox is clicked

* add test
@syadupathi-sf
@W-20892592 Remove gift messaging for multi shipment (#3579)
a5deb6c 
* W-20892592 Remove gift messaging for multi shipment

* translations
@syadupathi-sf
@W-20892530 @W-20892577 Billing Address Validation and Using contact …
80c1c80 
…phone for user registration (#3583)

* W-20892530 Billing Address Validation

* W-20892577 save contact info phone
@syadupathi-sf
Merge branch 'develop' into feature/1cc_merge
0e79176
@syadupathi-sf
@W-20931438 Add spinner for place order button (#3587)
a0d8325 
* Add spinner for place order button

* skip changelog
@syadupathi-sf
Update isomorphic version to the newly released version (#3592)
35a9a4d
@syadupathi-sf
Merge branch 'develop' into feature/1cc_merge
d6fe32c
@syadupathi-sf
Fix SDK tests (#3593)
b9cb29d 
* fix sdk tests and app bundle size

* fix lint
syadupathi-sf and others added 4 commits January 22, 2026 15:25
@syadupathi-sf
@W-20931758 Allow guest shopper to change payment (#3591)
b7515c4 
* W-20931758 Allow guest shopper to change payment after applying it

* changed the error code to use an existing one
@dannyphan2000
@W-21000333: [BOPIS] Should skip pick up address (#3601)
c292a78 
Signed-off-by: d.phan <d.phan@salesforce.com>
@syadupathi-sf
W-21005962 Disable user registration when billing address is not valid (
9fa4455 
#3605)
@dannyphan2000
@W-21000338: [BOPIS] Auto-populate billing address with default addre…
411fc67 
…ss (#3602)

Signed-off-by: d.phan <d.phan@salesforce.com>
hajinsuha1
hajinsuha1 reviewed Jan 30, 2026
View reviewed changes
Copy link
Collaborator

@hajinsuha1 hajinsuha1 left a comment •
edited by syadupathi-sf
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team, I'm finding that the Resend Code button is not making a new /passwordless/login call
Screenshot 2026-01-30 at 3 09 08 PM

@hajinsuha1 We have a ticket for it - @dannyphan2000 is working on it.

@syadupathi-sf @hajinsuha1
Update packages/template-retail-react-app/app/pages/checkout-one-clic…
6649505 
…k/partials/one-click-contact-info.jsx

Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Signed-off-by: syadupathi-sf <66088780+syadupathi-sf@users.noreply.github.com>
dannyphan2000
dannyphan2000 previously approved these changes Jan 30, 2026
View reviewed changes
hajinsuha1
hajinsuha1 previously approved these changes Jan 30, 2026
View reviewed changes
vmarta
vmarta previously approved these changes Jan 30, 2026
View reviewed changes
Copy link
Contributor

@vmarta vmarta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side of things, thank you for addressing the feedback 👍

@kumaravinashcommercecloud kumaravinashcommercecloud dismissed stale reviews from vmarta and themself via 1eb4f7b January 31, 2026 02:56
@syadupathi-sf syadupathi-sf requested a review from vmarta February 2, 2026 16:18
patricksullivansf
patricksullivansf reviewed Feb 2, 2026
View reviewed changes
Copy link
Contributor

@patricksullivansf patricksullivansf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look very reasonable from a multiship and bopis perspective. thank you

@syadupathi-sf syadupathi-sf merged commit 3533930 into develop Feb 2, 2026
42 checks passed
@syadupathi-sf syadupathi-sf deleted the feature/1cc_merge branch February 2, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmarta vmarta vmarta approved these changes

@hajinsuha1 hajinsuha1 hajinsuha1 approved these changes

@patricksullivansf patricksullivansf patricksullivansf approved these changes

@kumaravinashcommercecloud kumaravinashcommercecloud kumaravinashcommercecloud approved these changes

@dannyphan2000 dannyphan2000 Awaiting requested review from dannyphan2000

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@syadupathi-sf @cc-prodsec @vmarta @hajinsuha1 @patricksullivansf @dannyphan2000 @kumaravinashcommercecloud