Skip to content

Conversation

@yunakim714
Copy link
Collaborator

@yunakim714 yunakim714 commented Jan 6, 2026

Description

⚠️The latest release of commerce-sdk-isomorphic does not yet have the updated Shopper Login OAS with the new WebAuthN endpoints added. Therefore, some of the tests are failing

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • Add the following WebAuthN endpoints to commerce-sdk-react AuthHelpers
    • POST /webauthn/register/authorize - authorizeWebauthnRegistration
    • POST /webauthn/register/start - startWebauthnUserRegistration
    • POST /webauthn/register/finish - finishWebauthnUserRegistration
    • POST /webauthn/authenticate/start - startWebAuthnAuthentication
    • POST /webauthn/authenticate/finish - finishWebAuthnAuthentication

How to Test-Drive This PR

  • To test these changes locally, we need to manually update a local version of commerce-sdk-isomorphic then drop the minified SDK bundle from the /lib directory into commerce-sdk-react: packages/commerce-sdk-react/node_modules/commerce-sdk-isomorphic/lib
  • Then in commerce-sdk-react root, run npm run test -- src/auth/index.test.ts

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

@cc-prodsec
Copy link
Collaborator

cc-prodsec commented Jan 6, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@yunakim714 yunakim714 changed the base branch from develop to feature/webauthn-login January 7, 2026 14:33
@yunakim714 yunakim714 changed the base branch from feature/webauthn-login to develop January 7, 2026 14:42
@yunakim714 yunakim714 changed the base branch from develop to feature/webauthn-login January 7, 2026 14:44
@yunakim714 yunakim714 requested a review from hajinsuha1 January 7, 2026 20:56
@yunakim714 yunakim714 marked this pull request as ready for review January 8, 2026 16:15
@yunakim714 yunakim714 requested a review from a team as a code owner January 8, 2026 16:15
Copy link
Collaborator

@hajinsuha1 hajinsuha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about optional params but otherwise looks good!

@yunakim714 yunakim714 requested a review from alexvuong January 9, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants