-
Notifications
You must be signed in to change notification settings - Fork 205
@W-20328381 - Add Webauthn Register/Authenticate APIs to commerce-sdk-react
#3561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yunakim714
wants to merge
10
commits into
feature/webauthn-login
Choose a base branch
from
W-20328381-webauthn-api-commerce-react
base: feature/webauthn-login
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
@W-20328381 - Add Webauthn Register/Authenticate APIs to commerce-sdk-react
#3561
yunakim714
wants to merge
10
commits into
feature/webauthn-login
from
W-20328381-webauthn-api-commerce-react
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…alesforceCommerceCloud/pwa-kit into W-20328381-webauthn-api-commerce-react
hajinsuha1
reviewed
Jan 8, 2026
hajinsuha1
approved these changes
Jan 8, 2026
Collaborator
hajinsuha1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment about optional params but otherwise looks good!
alexvuong
reviewed
Jan 8, 2026
alexvuong
reviewed
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
commerce-sdk-isomorphicdoes not yet have the updated Shopper Login OAS with the new WebAuthN endpoints added. Therefore, some of the tests are failingTypes of Changes
Changes
commerce-sdk-reactAuthHelpersauthorizeWebauthnRegistrationstartWebauthnUserRegistrationfinishWebauthnUserRegistrationstartWebAuthnAuthenticationfinishWebAuthnAuthenticationHow to Test-Drive This PR
commerce-sdk-isomorphicthen drop the minified SDK bundle from the/libdirectory intocommerce-sdk-react:packages/commerce-sdk-react/node_modules/commerce-sdk-isomorphic/libcommerce-sdk-reactroot, runnpm run test -- src/auth/index.test.tsChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists: