-
Notifications
You must be signed in to change notification settings - Fork 205
@W-20452321: Migrate AWS SDK V2 to V3 #3566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
packages/pwa-kit-runtime/src/utils/ssr-server/metrics-sender.js
Outdated
Show resolved
Hide resolved
|
Followed test instructions, seeing metrics as expected from a bundle built from this branch 🙌 📈 . Happy to approve review once you address the nit above. The one failing check I'm seeing from CI right now (SalesforceCommerceCloud/pwa-kit/test / pwa-kit-windows (22, 8) (pull_request)) seems unrelated to your change. |
noahadams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, CI happy 👍

Migrate AWS SDK FROM Version 2 TO Version 3
Description
End of life support FOR AWS-SDK was reached on September 8, 2025
The JS AWS SDK is used to send metrics to cloudwatch from pwa kit runtime library. The goal is to update the library to use v3 version. We utilize codemod scripts for the migration (recommended by AWS) and manually adjust discrepancies between the two versions
Types of Changes
Changes
client-cloudwatchinstead for v3How to Test-Drive This PR
npm installandnpm ciat the rootpackages/template-mrt-reference-appcurl -s -o /dev/null -w "%{http_code}\n" https://{project}-{target}.[mobify-storefront-staging.com](http://mobify-storefront-staging.comWait for a few minutes and then check your subaccount of the target for the following metrics
Cloudwatch > Metrics > ssr > Project, TargetEnsure
RequestTimeandRequestSuccessare displayed in metricscurl -s -o /dev/null -w "%{http_code}\n" https://{project}-{target}.[mobify-storefront-staging.com](http://mobify-storefront-staging.com/exceptionWait for a few minutes and then check your subaccount of the target for the following metrics
Cloudwatch > Metrics > ssr > Project, TargetEnsure
RequestTimeandRequestFailed500are displayed in metricsChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization