-
Notifications
You must be signed in to change notification settings - Fork 205
Fix reset password #3567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix reset password #3567
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
bfeister
previously approved these changes
Jan 8, 2026
Contributor
bfeister
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a million for setting this up in a deployment for easier manual validation 🏆
Validated myself, looks great!
shethj
reviewed
Jan 8, 2026
shethj
previously approved these changes
Jan 8, 2026
shethj
previously approved these changes
Jan 8, 2026
bfeister
previously approved these changes
Jan 8, 2026
shethj
approved these changes
Jan 8, 2026
bfeister
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some customers has complained they received 400 error when calling resetPassword api regarding
code_verifierRoot cause
code_verifieris completely optional when the feature was implemented, but the api has changed and document has not been updated, which results in a mis connection between pwa-kit and SCAP calls.hintanduser_idparams are defined. hint needs to be 'cross_device`Solution
cross_deviceas default value for hint and user_id parm to resetPassword call (password/action). This is confirmed will fix the issue on 400 error that customers are facingTypes of Changes
Changes
How to Test-Drive This PR
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization