-
Notifications
You must be signed in to change notification settings - Fork 212
@W-20890250 Handle request limit and monthly quota error states for passwordless and reset password #3574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hajinsuha1
merged 8 commits into
feature/email-otp
from
W-20890250-handle-error-states-passwordless-and-reset-password
Jan 16, 2026
Merged
@W-20890250 Handle request limit and monthly quota error states for passwordless and reset password #3574
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bf61c9b
Reapply "Enable SLAS private client and passwordless login email mode…
hajinsuha1 ceb2b79
Enhance error handling for password reset functionality and add new e…
hajinsuha1 ec15311
create getTokenBasedAuthErrorMessage util and use it for authorizePas…
hajinsuha1 6167eb8
Revert "Reapply "Enable SLAS private client and passwordless login em…
hajinsuha1 c4e15b1
split error message utility into one for passwordless and one for res…
hajinsuha1 e8dc05e
add unit tests
hajinsuha1 ab643f5
Enhance PasswordlessEmailConfirmation component to display global err…
hajinsuha1 4620ff0
changelog updates and translations
hajinsuha1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,13 @@ | |
| import React from 'react' | ||
| import PropTypes from 'prop-types' | ||
| import {FormattedMessage} from 'react-intl' | ||
| import {Button, Stack, Text} from '@salesforce/retail-react-app/app/components/shared/ui' | ||
| import { | ||
| Button, | ||
| Stack, | ||
| Text, | ||
| Alert, | ||
| AlertIcon | ||
| } from '@salesforce/retail-react-app/app/components/shared/ui' | ||
| import {BrandLogo} from '@salesforce/retail-react-app/app/components/icons' | ||
|
|
||
| const PasswordlessEmailConfirmation = ({form, submitForm, email = ''}) => { | ||
|
|
@@ -40,6 +46,14 @@ const PasswordlessEmailConfirmation = ({form, submitForm, email = ''}) => { | |
| id="auth_modal.check_email.title.check_your_email" | ||
| /> | ||
| </Text> | ||
| {form.formState.errors?.global && ( | ||
| <Alert status="error"> | ||
| <AlertIcon color="red.500" boxSize={4} /> | ||
| <Text fontSize="sm" ml={3}> | ||
| {form.formState.errors.global.message} | ||
| </Text> | ||
| </Alert> | ||
| )} | ||
|
Comment on lines
+49
to
+56
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| <Stack spacing={10}> | ||
| <Text align="center" fontSize="md" id="email-confirmation-desc"> | ||
| <FormattedMessage | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -251,12 +251,6 @@ export const LOGIN_TYPES = { | |
| SOCIAL: 'social' | ||
| } | ||
|
|
||
| export const PASSWORDLESS_ERROR_MESSAGES = [ | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this has been moved to auth-utils.js above and renamed to |
||
| /callback_uri doesn't match/i, | ||
| /passwordless permissions error/i, | ||
| /client secret is not provided/i | ||
| ] | ||
|
|
||
| export const INVALID_TOKEN_ERROR = /invalid token/i | ||
|
|
||
| /** | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
calling
getPasswordResetToken(options, true)returns therawResponsewhich was need to pass the error message to retail-react-app for determining which error message to display